From: "Zha, Qipeng" <qipeng.zha@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Darren Hart <dvhart@infradead.org>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: RE: [PATCH V8 1/2] intel_pmc_ipc: update acpi resource structure for Punit
Date: Thu, 10 Dec 2015 02:39:07 +0000 [thread overview]
Message-ID: <C6287702A945AC47BE5DB5DFD4B5C6DD03832063@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1449580757.30729.52.camel@linux.intel.com>
>> +Andriy who originally raised the concern over the ACPI resource
>> assumptions in
>> the previous version. Andriy, this resource allocation looks to be a
>> substantial improvement to me. Do you have any further concerns?
>So, regarding to the second patch
>1. In excerpts like following
>if (IS_ERR(addr)) {
> dev_err(&pdev->dev, "Failed to map resouce for BIOS DATA\n");
> return PTR_ERR(addr);
> }
>No need to have an error message. Core already has something to print at that point.
Core error message will not show which resource is failed,
Anyway, I will made this change
prev parent reply other threads:[~2015-12-10 2:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 16:55 [PATCH V8 1/2] intel_pmc_ipc: update acpi resource structure for Punit Qipeng Zha
2015-12-07 16:55 ` [PATCH V8 2/2] platform:x86: add Intel P-Unit mailbox IPC driver Qipeng Zha
2015-12-07 23:45 ` [PATCH V8 1/2] intel_pmc_ipc: update acpi resource structure for Punit Darren Hart
2015-12-08 11:10 ` Andy Shevchenko
2015-12-08 12:57 ` Andy Shevchenko
2015-12-08 22:59 ` Darren Hart
2015-12-09 0:21 ` Darren Hart
2015-12-09 11:09 ` Andy Shevchenko
2015-12-09 16:33 ` Darren Hart
2015-12-08 13:19 ` Andy Shevchenko
2015-12-08 23:02 ` Darren Hart
2015-12-08 23:28 ` Darren Hart
2015-12-10 2:39 ` Zha, Qipeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6287702A945AC47BE5DB5DFD4B5C6DD03832063@SHSMSX104.ccr.corp.intel.com \
--to=qipeng.zha@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.