From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: shmobile: r8a7793: Describe DMA for the serial ports
Date: Thu, 10 Dec 2015 13:54:45 +0900 [thread overview]
Message-ID: <20151210045444.GC6964@verge.net.au> (raw)
In-Reply-To: <CAMuHMdVfMp0awRZh6S7YiSPFpUyAvwGXSQb2RYU7DkK_SOwH9Q@mail.gmail.com>
On Wed, Dec 09, 2015 at 11:47:36AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Fri, Nov 27, 2015 at 2:52 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Add DMA properties to all SCIF, SCIFA, SCIFB, and HSCIF device nodes.
> >
> > Based on similar work for the r8a7791 by Geert Uytterhoeven.
> >
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/boot/dts/r8a7793.dtsi | 36 ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 36 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> > index 3ac2ec0414a0..8d5cbdfc3d5d 100644
> > --- a/arch/arm/boot/dts/r8a7793.dtsi
> > +++ b/arch/arm/boot/dts/r8a7793.dtsi
>
> > @@ -394,6 +412,8 @@
> > interrupts = <0 152 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&mstp7_clks R8A7793_CLK_SCIF0>;
> > clock-names = "sci_ick";
> > + dmas = <&dmac0 0x29>, <&dmac0 0x2a>;
> > + dma-names = "tx", "rx";
> > power-domains = <&cpg_clocks>;
> > status = "disabled";
> > };
> > @@ -404,6 +424,8 @@
> > interrupts = <0 153 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&mstp7_clks R8A7793_CLK_SCIF1>;
> > clock-names = "sci_ick";
> > + dmas = <&dmac0 0x29>, <&dmac0 0x2a>;
>
> This is duplicated from scif0, and should be:
>
> dmas = <&dmac0 0x2d>, <&dmac0 0x2e>;
>
> > + dma-names = "tx", "rx";
>
> After
>
> sed -i -e 's/7791/779x/g' arch/arm/boot/dts/r8a7791.dtsi
> sed -i -e 's/7793/779x/g' arch/arm/boot/dts/r8a7793.dtsi
>
> arch/arm/boot/dts/r8a7791.dtsi and arch/arm/boot/dts/r8a7793.dtsi should
> be identical ;-)
Thanks, I have fixed that in v2.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7793: Describe DMA for the serial ports
Date: Thu, 10 Dec 2015 04:54:45 +0000 [thread overview]
Message-ID: <20151210045444.GC6964@verge.net.au> (raw)
In-Reply-To: <CAMuHMdVfMp0awRZh6S7YiSPFpUyAvwGXSQb2RYU7DkK_SOwH9Q@mail.gmail.com>
On Wed, Dec 09, 2015 at 11:47:36AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Fri, Nov 27, 2015 at 2:52 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Add DMA properties to all SCIF, SCIFA, SCIFB, and HSCIF device nodes.
> >
> > Based on similar work for the r8a7791 by Geert Uytterhoeven.
> >
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/boot/dts/r8a7793.dtsi | 36 ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 36 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> > index 3ac2ec0414a0..8d5cbdfc3d5d 100644
> > --- a/arch/arm/boot/dts/r8a7793.dtsi
> > +++ b/arch/arm/boot/dts/r8a7793.dtsi
>
> > @@ -394,6 +412,8 @@
> > interrupts = <0 152 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&mstp7_clks R8A7793_CLK_SCIF0>;
> > clock-names = "sci_ick";
> > + dmas = <&dmac0 0x29>, <&dmac0 0x2a>;
> > + dma-names = "tx", "rx";
> > power-domains = <&cpg_clocks>;
> > status = "disabled";
> > };
> > @@ -404,6 +424,8 @@
> > interrupts = <0 153 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&mstp7_clks R8A7793_CLK_SCIF1>;
> > clock-names = "sci_ick";
> > + dmas = <&dmac0 0x29>, <&dmac0 0x2a>;
>
> This is duplicated from scif0, and should be:
>
> dmas = <&dmac0 0x2d>, <&dmac0 0x2e>;
>
> > + dma-names = "tx", "rx";
>
> After
>
> sed -i -e 's/7791/779x/g' arch/arm/boot/dts/r8a7791.dtsi
> sed -i -e 's/7793/779x/g' arch/arm/boot/dts/r8a7793.dtsi
>
> arch/arm/boot/dts/r8a7791.dtsi and arch/arm/boot/dts/r8a7793.dtsi should
> be identical ;-)
Thanks, I have fixed that in v2.
next prev parent reply other threads:[~2015-12-10 4:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 1:52 [PATCH 0/2] ARM: shmobile: r8a7793: Increase scif support Simon Horman
2015-11-27 1:52 ` Simon Horman
2015-11-27 1:52 ` [PATCH 1/2] ARM: shmobile: r8a7793: Add missing serial devices to DT Simon Horman
2015-11-27 1:52 ` Simon Horman
2015-12-09 10:42 ` Geert Uytterhoeven
2015-12-09 10:42 ` Geert Uytterhoeven
2015-12-10 4:48 ` Simon Horman
2015-12-10 4:48 ` Simon Horman
2015-11-27 1:52 ` [PATCH 2/2] ARM: shmobile: r8a7793: Describe DMA for the serial ports Simon Horman
2015-11-27 1:52 ` Simon Horman
2015-12-09 10:47 ` Geert Uytterhoeven
2015-12-09 10:47 ` Geert Uytterhoeven
2015-12-10 4:54 ` Simon Horman [this message]
2015-12-10 4:54 ` Simon Horman
2015-12-10 10:14 ` Geert Uytterhoeven
2015-12-10 10:14 ` Geert Uytterhoeven
2015-12-11 1:08 ` Simon Horman
2015-12-11 1:08 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210045444.GC6964@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.