All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts/pkg-stats: properly handle host packages with -c option
Date: Fri, 8 Jan 2021 22:37:37 +0100	[thread overview]
Message-ID: <20210108213737.GP1485369@scaer> (raw)
In-Reply-To: <20210107223447.4a2b8674@windsurf.home>

Thomas, All,

On 2021-01-07 22:34 +0100, Thomas Petazzoni spake thusly:
> On Thu, 7 Jan 2021 22:32:07 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> 
> > I think the correct fix would be for the json output to already contain
> > the base name of the package, and the script to use that field, rather
> > than the key, as a package name. That way, the behaviour would be the
> > same for both target and host packages.
> 
> Right, that could certainly work as well.
> 
> > 
> > Something like:
> > 
> >     diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> >     index a2cc160d0b..0f9d612f12 100644
> >     --- a/package/pkg-utils.mk
> >     +++ b/package/pkg-utils.mk
> >     @@ -91,6 +91,7 @@ endef
> >      # $(1): upper-case package or filesystem name
> >      define json-info
> >      	"$($(1)_NAME)": {
> >     +		"name": "$($(1)_RAWNAME)",
> 
> "name" or "rawname" ?

"rawname" is a detail of the naming of our internal variables. WE do not
want to propagate that to the outside world.

"name" is really that: the name of the package, by which people know it
and talk about.

Regards,
Yann E. MORIN.

> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-01-08 21:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 21:13 [Buildroot] [PATCH] linux: indicate proper CPE prefix Thomas Petazzoni
2021-01-07 21:13 ` [Buildroot] [PATCH] support/scripts/pkg-stats: properly handle host packages with -c option Thomas Petazzoni
2021-01-07 21:27   ` Matthew Weber
2021-01-07 21:32   ` Yann E. MORIN
2021-01-07 21:34     ` Thomas Petazzoni
2021-01-08 21:37       ` Yann E. MORIN [this message]
2021-01-11 21:25         ` Arnout Vandecappelle
2021-01-07 21:26 ` [Buildroot] [PATCH] linux: indicate proper CPE prefix Matthew Weber
2021-01-09 16:06 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108213737.GP1485369@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.