All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Bilal Wasim <bilalwasim676@gmail.com>
To: linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, matthias.bgg@gmail.com,
	enric.balletbo@collabora.com, hsinyi@chromium.org,
	weiyi.lu@mediatek.com
Subject: [PATCH v2 1/3] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr
Date: Mon,  1 Feb 2021 17:14:14 +0500	[thread overview]
Message-ID: <20210201121416.1488439-2-Bilal.Wasim@imgtec.com> (raw)
In-Reply-To: <20210201121416.1488439-1-Bilal.Wasim@imgtec.com>

When "bus_prot_reg_update" is true, the driver should use
INFRA_TOPAXI_PROTECTEN for both setting and clearing the bus
protection. However, the driver does not use this mask for
clearing bus protection which causes failure when booting
the imgtec gpu.

Corrected and tested with mt8173 chromebook.

Signed-off-by: Bilal Wasim <Bilal.Wasim@imgtec.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
 drivers/soc/mediatek/mtk-pm-domains.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h
index 141dc76054e6..7454c0b4f768 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.h
+++ b/drivers/soc/mediatek/mtk-pm-domains.h
@@ -60,7 +60,7 @@
 #define BUS_PROT_UPDATE_TOPAXI(_mask)				\
 		BUS_PROT_UPDATE(_mask,				\
 				INFRA_TOPAXI_PROTECTEN,		\
-				INFRA_TOPAXI_PROTECTEN_CLR,	\
+				INFRA_TOPAXI_PROTECTEN,		\
 				INFRA_TOPAXI_PROTECTSTA1)
 
 struct scpsys_bus_prot_data {
-- 
2.25.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Bilal Wasim <bilalwasim676@gmail.com>
To: linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, matthias.bgg@gmail.com,
	enric.balletbo@collabora.com, hsinyi@chromium.org,
	weiyi.lu@mediatek.com
Subject: [PATCH v2 1/3] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr
Date: Mon,  1 Feb 2021 17:14:14 +0500	[thread overview]
Message-ID: <20210201121416.1488439-2-Bilal.Wasim@imgtec.com> (raw)
In-Reply-To: <20210201121416.1488439-1-Bilal.Wasim@imgtec.com>

When "bus_prot_reg_update" is true, the driver should use
INFRA_TOPAXI_PROTECTEN for both setting and clearing the bus
protection. However, the driver does not use this mask for
clearing bus protection which causes failure when booting
the imgtec gpu.

Corrected and tested with mt8173 chromebook.

Signed-off-by: Bilal Wasim <Bilal.Wasim@imgtec.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
 drivers/soc/mediatek/mtk-pm-domains.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h
index 141dc76054e6..7454c0b4f768 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.h
+++ b/drivers/soc/mediatek/mtk-pm-domains.h
@@ -60,7 +60,7 @@
 #define BUS_PROT_UPDATE_TOPAXI(_mask)				\
 		BUS_PROT_UPDATE(_mask,				\
 				INFRA_TOPAXI_PROTECTEN,		\
-				INFRA_TOPAXI_PROTECTEN_CLR,	\
+				INFRA_TOPAXI_PROTECTEN,		\
 				INFRA_TOPAXI_PROTECTSTA1)
 
 struct scpsys_bus_prot_data {
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Bilal Wasim <bilalwasim676@gmail.com>
To: linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, matthias.bgg@gmail.com,
	enric.balletbo@collabora.com, hsinyi@chromium.org,
	weiyi.lu@mediatek.com
Subject: [PATCH v2 1/3] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr
Date: Mon,  1 Feb 2021 17:14:14 +0500	[thread overview]
Message-ID: <20210201121416.1488439-2-Bilal.Wasim@imgtec.com> (raw)
In-Reply-To: <20210201121416.1488439-1-Bilal.Wasim@imgtec.com>

When "bus_prot_reg_update" is true, the driver should use
INFRA_TOPAXI_PROTECTEN for both setting and clearing the bus
protection. However, the driver does not use this mask for
clearing bus protection which causes failure when booting
the imgtec gpu.

Corrected and tested with mt8173 chromebook.

Signed-off-by: Bilal Wasim <Bilal.Wasim@imgtec.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
 drivers/soc/mediatek/mtk-pm-domains.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h
index 141dc76054e6..7454c0b4f768 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.h
+++ b/drivers/soc/mediatek/mtk-pm-domains.h
@@ -60,7 +60,7 @@
 #define BUS_PROT_UPDATE_TOPAXI(_mask)				\
 		BUS_PROT_UPDATE(_mask,				\
 				INFRA_TOPAXI_PROTECTEN,		\
-				INFRA_TOPAXI_PROTECTEN_CLR,	\
+				INFRA_TOPAXI_PROTECTEN,		\
 				INFRA_TOPAXI_PROTECTSTA1)
 
 struct scpsys_bus_prot_data {
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-01 12:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 12:14 [PATCH v2 0/3] Misc bug fixes in mtk power domain driver Bilal Wasim
2021-02-01 12:14 ` Bilal Wasim
2021-02-01 12:14 ` Bilal Wasim
2021-02-01 12:14 ` Bilal Wasim [this message]
2021-02-01 12:14   ` [PATCH v2 1/3] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr Bilal Wasim
2021-02-01 12:14   ` Bilal Wasim
2021-03-31 11:01   ` Matthias Brugger
2021-03-31 11:01     ` Matthias Brugger
2021-03-31 11:01     ` Matthias Brugger
2021-02-01 12:14 ` [PATCH v2 2/3] soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD Bilal Wasim
2021-02-01 12:14   ` Bilal Wasim
2021-02-01 12:14   ` Bilal Wasim
2021-02-01 16:56   ` kernel test robot
2021-02-01 16:56     ` kernel test robot
2021-02-01 16:56     ` kernel test robot
2021-02-01 16:56     ` kernel test robot
2021-03-31 10:48   ` Matthias Brugger
2021-03-31 10:48     ` Matthias Brugger
2021-03-31 10:48     ` Matthias Brugger
2021-02-01 12:14 ` [PATCH v2 3/3] arm64: dts: mediatek: mt8173: Add domain supply for mfg_async Bilal Wasim
2021-02-01 12:14   ` Bilal Wasim
2021-02-01 12:14   ` Bilal Wasim
2021-02-16 11:59 ` [PATCH v2 0/3] Misc bug fixes in mtk power domain driver Bilal Wasim
2021-02-16 11:59   ` Bilal Wasim
2021-02-16 11:59   ` Bilal Wasim
2021-03-31  8:46   ` Enric Balletbo Serra
2021-03-31  8:46     ` Enric Balletbo Serra
2021-03-31  8:46     ` Enric Balletbo Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201121416.1488439-2-Bilal.Wasim@imgtec.com \
    --to=bilalwasim676@gmail.com \
    --cc=enric.balletbo@collabora.com \
    --cc=hsinyi@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=weiyi.lu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.