From: Henning Schild <henning.schild@siemens.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Claudius Heine <ch@denx.de>,
johannes hahn <johannes-hahn@siemens.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
werner zeh <werner.zeh@siemens.com>,
"martin mantel" <martin.mantel@siemens.com>,
val krutov <val.krutov@erd.epson.com>
Subject: Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C
Date: Tue, 16 Mar 2021 12:52:51 +0100 [thread overview]
Message-ID: <20210316125251.64484b3a@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <YFCW3Kx9MPm0MT8H@smile.fi.intel.com>
Am Tue, 16 Mar 2021 13:30:36 +0200
schrieb Andy Shevchenko <andriy.shevchenko@intel.com>:
> On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote:
> > From: Johannes Hahn <johannes-hahn@siemens.com>
> >
> > This allows the RX6110 driver to be automatically assigned to the
> > right device on the I2C bus.
>
> Thanks for all effort!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> after addressing the below comments.
>
> > Signed-off-by: Johannes Hahn <johannes-hahn@siemens.com>
> > Signed-off-by: Claudius Heine <ch@denx.de>
>
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
Claudius, just remove that. I guess just add yours and mention authors
in the code if they should receive some recognition.
Henning
> I think this is somehow confusing. Either you need to add
> Co-developed-by of the corresponding people, or remove SoB (because
> of From line), i.o.w seems like Co-dB tag is needed for Johannes or
> you and something should be done with Henning's SoB.
>
> > ---
> > drivers/rtc/rtc-rx6110.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c
> > index 79161d4c6ce4..29bd697f82cb 100644
> > --- a/drivers/rtc/rtc-rx6110.c
> > +++ b/drivers/rtc/rtc-rx6110.c
> > @@ -13,6 +13,7 @@
> > #include <linux/of_gpio.h>
> > #include <linux/regmap.h>
> > #include <linux/rtc.h>
>
> > +#include <linux/acpi.h>
>
> Usually it's not needed if you leave IDs always to be compiled.
> Instead mod_devicetable.h is used. But it's all up to you and
> maintainer.
>
> > #include <linux/of.h>
> > #include <linux/of_device.h>
> > #include <linux/spi/spi.h>
> > @@ -447,6 +448,14 @@ static int rx6110_i2c_probe(struct i2c_client
> > *client, return rx6110_probe(rx6110, &client->dev);
> > }
> >
> > +#ifdef CONFIG_ACPI
> > +static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
> > + { "SECC6110", },
> > + { },
> > +};
> > +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
> > +#endif
> > +
> > static const struct i2c_device_id rx6110_i2c_id[] = {
> > { "rx6110", 0 },
> > { }
> > @@ -456,6 +465,9 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
> > static struct i2c_driver rx6110_i2c_driver = {
> > .driver = {
> > .name = RX6110_DRIVER_NAME,
> > +#ifdef CONFIG_ACPI
>
> This is implied by the stub ACPI_PTR() macro for ACPI=n case.
> I.o.w drop this ugly and redundant ifdeffery.
>
> > + .acpi_match_table =
> > ACPI_PTR(rx6110_i2c_acpi_match), +#endif
> > },
> > .probe = rx6110_i2c_probe,
> > .id_table = rx6110_i2c_id,
> > --
> > 2.30.1
> >
>
next prev parent reply other threads:[~2021-03-16 12:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 13:07 [PATCH v2 0/3] Adding I2C support to RX6110 RTC Claudius Heine
2020-11-12 13:07 ` [PATCH v2 1/3] rtc: rx6110: add i2c support Claudius Heine
2020-11-12 13:19 ` Claudius Heine
2020-11-16 14:43 ` Andy Shevchenko
2020-11-16 17:36 ` Alexandre Belloni
2020-11-16 17:58 ` Andy Shevchenko
2020-11-12 13:07 ` [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C Claudius Heine
2020-11-16 14:46 ` Andy Shevchenko
2020-11-16 15:30 ` Henning Schild
2020-11-16 16:05 ` Andy Shevchenko
2020-11-16 16:08 ` Andy Shevchenko
2020-11-17 7:37 ` AW: " johannes-hahn
2020-11-17 11:10 ` Andy Shevchenko
2020-11-17 11:17 ` Andy Shevchenko
2020-11-17 9:46 ` AW: " johannes-hahn
2020-11-17 11:33 ` Andy Shevchenko
2020-11-17 11:41 ` Andy Shevchenko
2020-11-18 10:04 ` Henning Schild
2020-11-18 10:58 ` AW: " werner.zeh
2021-03-16 10:08 ` [PATCH v3 0/1] add ACPI binding to RX6110 driver Claudius Heine
2021-03-16 14:48 ` [PATCH v4] rtc: rx6110: add ACPI bindings to I2C Claudius Heine
2021-03-16 16:55 ` Andy Shevchenko
2021-03-17 7:53 ` Claudius Heine
2021-03-16 19:04 ` kernel test robot
2021-03-16 19:04 ` kernel test robot
2021-03-16 20:44 ` Andy Shevchenko
2021-03-16 20:44 ` Andy Shevchenko
2021-03-16 10:08 ` [PATCH v3 1/1] " Claudius Heine
2021-03-16 11:30 ` Andy Shevchenko
2021-03-16 11:33 ` Andy Shevchenko
2021-03-16 11:52 ` Henning Schild [this message]
2021-03-16 13:46 ` Andy Shevchenko
2020-11-12 13:07 ` [PATCH v2 3/3] rtc: Kconfig: Fix typo in help message of rx 6110 Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316125251.64484b3a@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@intel.com \
--cc=ch@denx.de \
--cc=johannes-hahn@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=martin.mantel@siemens.com \
--cc=val.krutov@erd.epson.com \
--cc=werner.zeh@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.