From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "johannes-hahn@siemens.com" <johannes-hahn@siemens.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Claudius Heine <ch@denx.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"werner.zeh@siemens.com" <werner.zeh@siemens.com>,
"henning.schild@siemens.com" <henning.schild@siemens.com>
Subject: Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C
Date: Tue, 17 Nov 2020 13:17:18 +0200 [thread overview]
Message-ID: <CAHp75Vdunx0pjwKBXv5OEjHk_E=sAu_N4xyCBRFoU3GKK8nnnA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Ve3UuzRj+0GNRT__XriuYihGx5sLjDYG=JMFooy=4j_dQ@mail.gmail.com>
On Tue, Nov 17, 2020 at 1:10 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Nov 17, 2020 at 9:39 AM johannes-hahn@siemens.com
> <johannes-hahn@siemens.com> wrote:
> >
> > Hello Andy,
> >
> > when comparing the ACPI IDs used in rtc-ds1307.c, which is already on mainline
> >
> > https://elixir.bootlin.com/linux/latest/source/drivers/rtc/rtc-ds1307.c#L1141
> >
> > for example. Every ID listed there is also not formatted the ACPI ID , PNP ID way defined in the ACPI spec.
> >
> > How about that ?
>
> Bad examples should not prevent you from doing the right thing, correct?
>
> JFYI: https://lore.kernel.org/linux-rtc/20201116142859.31257-1-andriy.shevchenko@linux.intel.com/
Moreover, this seems to be the last driver which was broken by the
same guy who "invented" ACPI IDs for them. The rest had been reverted
already.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-17 11:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 13:07 [PATCH v2 0/3] Adding I2C support to RX6110 RTC Claudius Heine
2020-11-12 13:07 ` [PATCH v2 1/3] rtc: rx6110: add i2c support Claudius Heine
2020-11-12 13:19 ` Claudius Heine
2020-11-16 14:43 ` Andy Shevchenko
2020-11-16 17:36 ` Alexandre Belloni
2020-11-16 17:58 ` Andy Shevchenko
2020-11-12 13:07 ` [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C Claudius Heine
2020-11-16 14:46 ` Andy Shevchenko
2020-11-16 15:30 ` Henning Schild
2020-11-16 16:05 ` Andy Shevchenko
2020-11-16 16:08 ` Andy Shevchenko
2020-11-17 7:37 ` AW: " johannes-hahn
2020-11-17 11:10 ` Andy Shevchenko
2020-11-17 11:17 ` Andy Shevchenko [this message]
2020-11-17 9:46 ` AW: " johannes-hahn
2020-11-17 11:33 ` Andy Shevchenko
2020-11-17 11:41 ` Andy Shevchenko
2020-11-18 10:04 ` Henning Schild
2020-11-18 10:58 ` AW: " werner.zeh
2021-03-16 10:08 ` [PATCH v3 0/1] add ACPI binding to RX6110 driver Claudius Heine
2021-03-16 14:48 ` [PATCH v4] rtc: rx6110: add ACPI bindings to I2C Claudius Heine
2021-03-16 16:55 ` Andy Shevchenko
2021-03-17 7:53 ` Claudius Heine
2021-03-16 19:04 ` kernel test robot
2021-03-16 19:04 ` kernel test robot
2021-03-16 20:44 ` Andy Shevchenko
2021-03-16 20:44 ` Andy Shevchenko
2021-03-16 10:08 ` [PATCH v3 1/1] " Claudius Heine
2021-03-16 11:30 ` Andy Shevchenko
2021-03-16 11:33 ` Andy Shevchenko
2021-03-16 11:52 ` Henning Schild
2021-03-16 13:46 ` Andy Shevchenko
2020-11-12 13:07 ` [PATCH v2 3/3] rtc: Kconfig: Fix typo in help message of rx 6110 Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vdunx0pjwKBXv5OEjHk_E=sAu_N4xyCBRFoU3GKK8nnnA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@intel.com \
--cc=ch@denx.de \
--cc=henning.schild@siemens.com \
--cc=johannes-hahn@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=werner.zeh@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.