From: Yannick Vignon <yannick.vignon@oss.nxp.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Antoine Tenart <atenart@kernel.org>, Wei Wang <weiwan@google.com>,
Taehee Yoo <ap420073@gmail.com>,
Alexander Lobakin <alobakin@pm.me>,
netdev@vger.kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
sebastien.laveze@oss.nxp.com
Cc: Yannick Vignon <yannick.vignon@nxp.com>
Subject: [RFC PATCH net-next v1 2/2] net: stmmac: use specific name for each NAPI instance
Date: Thu, 6 May 2021 19:20:21 +0200 [thread overview]
Message-ID: <20210506172021.7327-3-yannick.vignon@oss.nxp.com> (raw)
In-Reply-To: <20210506172021.7327-1-yannick.vignon@oss.nxp.com>
From: Yannick Vignon <yannick.vignon@nxp.com>
Use the newly introduced name field of the NAPI struct to identify which
queue each NAPI instance works on.
Signed-off-by: Yannick Vignon <yannick.vignon@nxp.com>
---
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 21 ++++++++++++-------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index e0b7eebcb512..d7fc3eddb7b7 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -6615,6 +6615,7 @@ static void stmmac_napi_add(struct net_device *dev)
{
struct stmmac_priv *priv = netdev_priv(dev);
u32 queue, maxq;
+ char name[NAPINAMSIZ];
maxq = max(priv->plat->rx_queues_to_use, priv->plat->tx_queues_to_use);
@@ -6626,19 +6627,23 @@ static void stmmac_napi_add(struct net_device *dev)
spin_lock_init(&ch->lock);
if (queue < priv->plat->rx_queues_to_use) {
- netif_napi_add(dev, &ch->rx_napi, stmmac_napi_poll_rx,
- NAPI_POLL_WEIGHT);
+ snprintf(name, NAPINAMSIZ, "rx-%d", queue);
+ netif_napi_add_named(dev, &ch->rx_napi,
+ stmmac_napi_poll_rx,
+ NAPI_POLL_WEIGHT, name);
}
if (queue < priv->plat->tx_queues_to_use) {
- netif_tx_napi_add(dev, &ch->tx_napi,
- stmmac_napi_poll_tx,
- NAPI_POLL_WEIGHT);
+ snprintf(name, NAPINAMSIZ, "tx-%d", queue);
+ netif_tx_napi_add_named(dev, &ch->tx_napi,
+ stmmac_napi_poll_tx,
+ NAPI_POLL_WEIGHT, name);
}
if (queue < priv->plat->rx_queues_to_use &&
queue < priv->plat->tx_queues_to_use) {
- netif_napi_add(dev, &ch->rxtx_napi,
- stmmac_napi_poll_rxtx,
- NAPI_POLL_WEIGHT);
+ snprintf(name, NAPINAMSIZ, "rxtx-%d", queue);
+ netif_napi_add_named(dev, &ch->rxtx_napi,
+ stmmac_napi_poll_rxtx,
+ NAPI_POLL_WEIGHT, name);
}
}
}
--
2.17.1
next prev parent reply other threads:[~2021-05-06 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 17:20 [RFC PATCH net-next v1 0/2] Threaded NAPI configurability Yannick Vignon
2021-05-06 17:20 ` [RFC PATCH net-next v1 1/2] net: add name field to napi struct Yannick Vignon
2021-05-06 17:35 ` Eric Dumazet
2021-05-11 16:44 ` Yannick Vignon
2021-05-06 17:20 ` Yannick Vignon [this message]
2021-05-06 22:18 ` [RFC PATCH net-next v1 0/2] Threaded NAPI configurability Jakub Kicinski
2021-05-11 16:46 ` Yannick Vignon
2021-05-12 1:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506172021.7327-3-yannick.vignon@oss.nxp.com \
--to=yannick.vignon@oss.nxp.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alobakin@pm.me \
--cc=ap420073@gmail.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=sebastien.laveze@oss.nxp.com \
--cc=weiwan@google.com \
--cc=yannick.vignon@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.