From: Jakub Kicinski <kuba@kernel.org>
To: Yannick Vignon <yannick.vignon@oss.nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Antoine Tenart <atenart@kernel.org>, Wei Wang <weiwan@google.com>,
Taehee Yoo <ap420073@gmail.com>,
Alexander Lobakin <alobakin@pm.me>,
netdev@vger.kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
sebastien.laveze@oss.nxp.com,
Yannick Vignon <yannick.vignon@nxp.com>
Subject: Re: [RFC PATCH net-next v1 0/2] Threaded NAPI configurability
Date: Tue, 11 May 2021 18:07:52 -0700 [thread overview]
Message-ID: <20210511180752.5d51da1f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <aab2fda9-b838-e367-75ef-3a0e13d066b3@oss.nxp.com>
On Tue, 11 May 2021 18:46:16 +0200 Yannick Vignon wrote:
> On 5/7/2021 12:18 AM, Jakub Kicinski wrote:
> > On Thu, 6 May 2021 19:20:19 +0200 Yannick Vignon wrote:
> >> The purpose of these 2 patches is to be able to configure the scheduling
> >> properties (e.g. affinity, priority...) of the NAPI threads more easily
> >> at run-time, based on the hardware queues each thread is handling.
> >> The main goal is really to expose which thread does what, as the current
> >> naming doesn't exactly make that clear.
> >>
> >> Posting this as an RFC in case people have different opinions on how to
> >> do that.
> >
> > WQ <-> CQ <-> irq <-> napi mapping needs an exhaustive netlink
> > interface. We've been saying this for a while. Neither hard coded
> > naming schemes nor one-off sysfs files are a great idea IMHO.
>
> Could you elaborate on the kind of netlink interface you are thinking about?
> We already have standard ways of configuring process priorities and
> affinities, what we need is rather to expose which queue(s) each NAPI
> thread/instance is responsible for (and as I just said, I fear this will
> involve driver changes).
An interface to carry information about the queues, interrupts and NAPI
instances, and relationship between them.
As you noted in your reply to Eric such API would require driver
changes, but one driver using it is enough to add the API.
> Now, one place were a netlink API could be of use is for statistics: we
> currently do not have any per-queue counters, and that would be useful
> when working on multi-queue setups.
Yup, such API is exactly where we should add standard per queue
statistics.
prev parent reply other threads:[~2021-05-12 1:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 17:20 [RFC PATCH net-next v1 0/2] Threaded NAPI configurability Yannick Vignon
2021-05-06 17:20 ` [RFC PATCH net-next v1 1/2] net: add name field to napi struct Yannick Vignon
2021-05-06 17:35 ` Eric Dumazet
2021-05-11 16:44 ` Yannick Vignon
2021-05-06 17:20 ` [RFC PATCH net-next v1 2/2] net: stmmac: use specific name for each NAPI instance Yannick Vignon
2021-05-06 22:18 ` [RFC PATCH net-next v1 0/2] Threaded NAPI configurability Jakub Kicinski
2021-05-11 16:46 ` Yannick Vignon
2021-05-12 1:07 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511180752.5d51da1f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alobakin@pm.me \
--cc=ap420073@gmail.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=sebastien.laveze@oss.nxp.com \
--cc=weiwan@google.com \
--cc=yannick.vignon@nxp.com \
--cc=yannick.vignon@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.