* [PATCH 1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe()
@ 2021-05-11 12:04 ` Zhen Lei
0 siblings, 0 replies; 6+ messages in thread
From: Zhen Lei @ 2021-05-11 12:04 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier,
Matthias Brugger, linux-remoteproc, linux-mediatek,
linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/remoteproc/mtk_scp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 9679cc26895e578..edb7f7842cb12ad 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -749,7 +749,6 @@ static int scp_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram");
scp->sram_base = devm_ioremap_resource(dev, res);
if (IS_ERR((__force void *)scp->sram_base)) {
- dev_err(dev, "Failed to parse and map sram memory\n");
ret = PTR_ERR((__force void *)scp->sram_base);
goto free_rproc;
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe()
@ 2021-05-11 12:04 ` Zhen Lei
0 siblings, 0 replies; 6+ messages in thread
From: Zhen Lei @ 2021-05-11 12:04 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier,
Matthias Brugger, linux-remoteproc, linux-mediatek,
linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/remoteproc/mtk_scp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 9679cc26895e578..edb7f7842cb12ad 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -749,7 +749,6 @@ static int scp_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram");
scp->sram_base = devm_ioremap_resource(dev, res);
if (IS_ERR((__force void *)scp->sram_base)) {
- dev_err(dev, "Failed to parse and map sram memory\n");
ret = PTR_ERR((__force void *)scp->sram_base);
goto free_rproc;
}
--
2.26.0.106.g9fadedd
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe()
@ 2021-05-11 12:04 ` Zhen Lei
0 siblings, 0 replies; 6+ messages in thread
From: Zhen Lei @ 2021-05-11 12:04 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier,
Matthias Brugger, linux-remoteproc, linux-mediatek,
linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/remoteproc/mtk_scp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 9679cc26895e578..edb7f7842cb12ad 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -749,7 +749,6 @@ static int scp_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram");
scp->sram_base = devm_ioremap_resource(dev, res);
if (IS_ERR((__force void *)scp->sram_base)) {
- dev_err(dev, "Failed to parse and map sram memory\n");
ret = PTR_ERR((__force void *)scp->sram_base);
goto free_rproc;
}
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe()
2021-05-11 12:04 ` Zhen Lei
(?)
@ 2021-05-12 16:42 ` Mathieu Poirier
-1 siblings, 0 replies; 6+ messages in thread
From: Mathieu Poirier @ 2021-05-12 16:42 UTC (permalink / raw)
To: Zhen Lei
Cc: Ohad Ben-Cohen, Bjorn Andersson, Matthias Brugger,
linux-remoteproc, linux-mediatek, linux-arm-kernel
Hi Lei,
On Tue, May 11, 2021 at 08:04:26PM +0800, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/remoteproc/mtk_scp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 9679cc26895e578..edb7f7842cb12ad 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -749,7 +749,6 @@ static int scp_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram");
> scp->sram_base = devm_ioremap_resource(dev, res);
> if (IS_ERR((__force void *)scp->sram_base)) {
> - dev_err(dev, "Failed to parse and map sram memory\n");
This kind of construct can be found several times in the remoteproc subsystem
and is also ubiquitous throughout the kernel. Moveover removing the error
notification does not simplify the code and does little to reduce the binary
size.
As such I do not think this patch is warranted and will not move forward with
it.
Thanks,
Mathieu
> ret = PTR_ERR((__force void *)scp->sram_base);
> goto free_rproc;
> }
> --
> 2.26.0.106.g9fadedd
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe()
@ 2021-05-12 16:42 ` Mathieu Poirier
0 siblings, 0 replies; 6+ messages in thread
From: Mathieu Poirier @ 2021-05-12 16:42 UTC (permalink / raw)
To: Zhen Lei
Cc: Ohad Ben-Cohen, Bjorn Andersson, Matthias Brugger,
linux-remoteproc, linux-mediatek, linux-arm-kernel
Hi Lei,
On Tue, May 11, 2021 at 08:04:26PM +0800, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/remoteproc/mtk_scp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 9679cc26895e578..edb7f7842cb12ad 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -749,7 +749,6 @@ static int scp_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram");
> scp->sram_base = devm_ioremap_resource(dev, res);
> if (IS_ERR((__force void *)scp->sram_base)) {
> - dev_err(dev, "Failed to parse and map sram memory\n");
This kind of construct can be found several times in the remoteproc subsystem
and is also ubiquitous throughout the kernel. Moveover removing the error
notification does not simplify the code and does little to reduce the binary
size.
As such I do not think this patch is warranted and will not move forward with
it.
Thanks,
Mathieu
> ret = PTR_ERR((__force void *)scp->sram_base);
> goto free_rproc;
> }
> --
> 2.26.0.106.g9fadedd
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe()
@ 2021-05-12 16:42 ` Mathieu Poirier
0 siblings, 0 replies; 6+ messages in thread
From: Mathieu Poirier @ 2021-05-12 16:42 UTC (permalink / raw)
To: Zhen Lei
Cc: Ohad Ben-Cohen, Bjorn Andersson, Matthias Brugger,
linux-remoteproc, linux-mediatek, linux-arm-kernel
Hi Lei,
On Tue, May 11, 2021 at 08:04:26PM +0800, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/remoteproc/mtk_scp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 9679cc26895e578..edb7f7842cb12ad 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -749,7 +749,6 @@ static int scp_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram");
> scp->sram_base = devm_ioremap_resource(dev, res);
> if (IS_ERR((__force void *)scp->sram_base)) {
> - dev_err(dev, "Failed to parse and map sram memory\n");
This kind of construct can be found several times in the remoteproc subsystem
and is also ubiquitous throughout the kernel. Moveover removing the error
notification does not simplify the code and does little to reduce the binary
size.
As such I do not think this patch is warranted and will not move forward with
it.
Thanks,
Mathieu
> ret = PTR_ERR((__force void *)scp->sram_base);
> goto free_rproc;
> }
> --
> 2.26.0.106.g9fadedd
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-12 17:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 12:04 [PATCH 1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe() Zhen Lei
2021-05-11 12:04 ` Zhen Lei
2021-05-11 12:04 ` Zhen Lei
2021-05-12 16:42 ` Mathieu Poirier
2021-05-12 16:42 ` Mathieu Poirier
2021-05-12 16:42 ` Mathieu Poirier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.