All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] configs: ti: enable TFTP_SIZE
@ 2021-05-11  7:40 Tero Kristo
  2021-05-11 12:07 ` Tom Rini
  0 siblings, 1 reply; 3+ messages in thread
From: Tero Kristo @ 2021-05-11  7:40 UTC (permalink / raw)
  To: u-boot

This fits the TFTP progress bar on single line based on the size of the
file being downloaded, reducing unnecessary spam and also making it
easier to track the download progress.

Signed-off-by: Tero Kristo <kristo@kernel.org>
---
 include/configs/ti_armv7_common.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
index f13e9e5264..f40089a3fd 100644
--- a/include/configs/ti_armv7_common.h
+++ b/include/configs/ti_armv7_common.h
@@ -205,6 +205,8 @@
 		"run netloadfdt; " \
 		"run netargs; " \
 		"bootz ${loadaddr} - ${fdtaddr}\0"
+
+#define CONFIG_TFTP_TSIZE
 #else
 #define NETARGS ""
 #endif
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] configs: ti: enable TFTP_SIZE
  2021-05-11  7:40 [PATCH] configs: ti: enable TFTP_SIZE Tero Kristo
@ 2021-05-11 12:07 ` Tom Rini
  2021-05-11 12:37   ` Tero Kristo
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2021-05-11 12:07 UTC (permalink / raw)
  To: u-boot

On Tue, May 11, 2021 at 10:40:15AM +0300, Tero Kristo wrote:

> This fits the TFTP progress bar on single line based on the size of the
> file being downloaded, reducing unnecessary spam and also making it
> easier to track the download progress.
> 
> Signed-off-by: Tero Kristo <kristo@kernel.org>
> ---
>  include/configs/ti_armv7_common.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
> index f13e9e5264..f40089a3fd 100644
> --- a/include/configs/ti_armv7_common.h
> +++ b/include/configs/ti_armv7_common.h
> @@ -205,6 +205,8 @@
>  		"run netloadfdt; " \
>  		"run netargs; " \
>  		"bootz ${loadaddr} - ${fdtaddr}\0"
> +
> +#define CONFIG_TFTP_TSIZE
>  #else
>  #define NETARGS ""
>  #endif

That's pretty handy.  Can you please convert it to Kconfig (it should go
in net/Kconfig) and default y if ARCH_OMAP2PLUS should be fine.  Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210511/7f32256e/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] configs: ti: enable TFTP_SIZE
  2021-05-11 12:07 ` Tom Rini
@ 2021-05-11 12:37   ` Tero Kristo
  0 siblings, 0 replies; 3+ messages in thread
From: Tero Kristo @ 2021-05-11 12:37 UTC (permalink / raw)
  To: u-boot

On 11/05/2021 15:07, Tom Rini wrote:
> On Tue, May 11, 2021 at 10:40:15AM +0300, Tero Kristo wrote:
> 
>> This fits the TFTP progress bar on single line based on the size of the
>> file being downloaded, reducing unnecessary spam and also making it
>> easier to track the download progress.
>>
>> Signed-off-by: Tero Kristo <kristo@kernel.org>
>> ---
>>   include/configs/ti_armv7_common.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
>> index f13e9e5264..f40089a3fd 100644
>> --- a/include/configs/ti_armv7_common.h
>> +++ b/include/configs/ti_armv7_common.h
>> @@ -205,6 +205,8 @@
>>   		"run netloadfdt; " \
>>   		"run netargs; " \
>>   		"bootz ${loadaddr} - ${fdtaddr}\0"
>> +
>> +#define CONFIG_TFTP_TSIZE
>>   #else
>>   #define NETARGS ""
>>   #endif
> 
> That's pretty handy.  Can you please convert it to Kconfig (it should go
> in net/Kconfig) and default y if ARCH_OMAP2PLUS should be fine.  Thanks.
> 

Yea, I can take a shot at that.

-Tero

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-11 12:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11  7:40 [PATCH] configs: ti: enable TFTP_SIZE Tero Kristo
2021-05-11 12:07 ` Tom Rini
2021-05-11 12:37   ` Tero Kristo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.