* [PATCH -next v2] EDAC: ti: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12 3:37 Bixuan Cui
2021-05-14 10:22 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Bixuan Cui @ 2021-05-12 3:37 UTC (permalink / raw)
To: bp; +Cc: kristo, mchehab, tony.luck, linux-edac, kernel-janitors
The module misses MODULE_DEVICE_TABLE() for of_device_id tables
and thus never autoloads on ID matches.
Add the missing declarations.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
Changes v2:
* Modify the commit message to make it more suitable.
drivers/edac/ti_edac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
index e7eae20f83d1..169f96e51c29 100644
--- a/drivers/edac/ti_edac.c
+++ b/drivers/edac/ti_edac.c
@@ -197,6 +197,7 @@ static const struct of_device_id ti_edac_of_match[] = {
{ .compatible = "ti,emif-dra7xx", .data = (void *)EMIF_TYPE_DRA7 },
{},
};
+MODULE_DEVICE_TABLE(of, ti_edac_of_match);
static int _emif_get_id(struct device_node *node)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next v2] EDAC: ti: Add missing MODULE_DEVICE_TABLE
2021-05-12 3:37 [PATCH -next v2] EDAC: ti: Add missing MODULE_DEVICE_TABLE Bixuan Cui
@ 2021-05-14 10:22 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2021-05-14 10:22 UTC (permalink / raw)
To: Bixuan Cui; +Cc: kristo, mchehab, tony.luck, linux-edac, kernel-janitors
On Wed, May 12, 2021 at 11:37:27AM +0800, Bixuan Cui wrote:
> The module misses MODULE_DEVICE_TABLE() for of_device_id tables
> and thus never autoloads on ID matches.
> Add the missing declarations.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> ---
> Changes v2:
> * Modify the commit message to make it more suitable.
>
> drivers/edac/ti_edac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
> index e7eae20f83d1..169f96e51c29 100644
> --- a/drivers/edac/ti_edac.c
> +++ b/drivers/edac/ti_edac.c
> @@ -197,6 +197,7 @@ static const struct of_device_id ti_edac_of_match[] = {
> { .compatible = "ti,emif-dra7xx", .data = (void *)EMIF_TYPE_DRA7 },
> {},
> };
> +MODULE_DEVICE_TABLE(of, ti_edac_of_match);
>
> static int _emif_get_id(struct device_node *node)
> {
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-14 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 3:37 [PATCH -next v2] EDAC: ti: Add missing MODULE_DEVICE_TABLE Bixuan Cui
2021-05-14 10:22 ` Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.