From: Zhen Lei <thunder.leizhen@huawei.com> To: Lee Jones <lee.jones@linaro.org>, patches <patches@opensource.cirrus.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org> Cc: Zhen Lei <thunder.leizhen@huawei.com> Subject: [PATCH 1/9] mfd: wm831x: use DEVICE_ATTR_RO macro Date: Wed, 2 Jun 2021 19:43:31 +0800 [thread overview] Message-ID: <20210602114339.11223-2-thunder.leizhen@huawei.com> (raw) In-Reply-To: <20210602114339.11223-1-thunder.leizhen@huawei.com> Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/mfd/wm831x-otp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/wm831x-otp.c b/drivers/mfd/wm831x-otp.c index afe59d52dd74d55..25f5d9fe33a18e2 100644 --- a/drivers/mfd/wm831x-otp.c +++ b/drivers/mfd/wm831x-otp.c @@ -38,8 +38,8 @@ static int wm831x_unique_id_read(struct wm831x *wm831x, char *id) return 0; } -static ssize_t wm831x_unique_id_show(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t unique_id_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct wm831x *wm831x = dev_get_drvdata(dev); int rval; @@ -52,7 +52,7 @@ static ssize_t wm831x_unique_id_show(struct device *dev, return sprintf(buf, "%*phN\n", WM831X_UNIQUE_ID_LEN, id); } -static DEVICE_ATTR(unique_id, 0444, wm831x_unique_id_show, NULL); +static DEVICE_ATTR_RO(unique_id); int wm831x_otp_init(struct wm831x *wm831x) { -- 2.26.0.106.g9fadedd
WARNING: multiple messages have this Message-ID (diff)
From: Zhen Lei <thunder.leizhen@huawei.com> To: Lee Jones <lee.jones@linaro.org>, patches <patches@opensource.cirrus.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org> Cc: Zhen Lei <thunder.leizhen@huawei.com> Subject: [PATCH 1/9] mfd: wm831x: use DEVICE_ATTR_RO macro Date: Wed, 2 Jun 2021 19:43:31 +0800 [thread overview] Message-ID: <20210602114339.11223-2-thunder.leizhen@huawei.com> (raw) In-Reply-To: <20210602114339.11223-1-thunder.leizhen@huawei.com> Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/mfd/wm831x-otp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/wm831x-otp.c b/drivers/mfd/wm831x-otp.c index afe59d52dd74d55..25f5d9fe33a18e2 100644 --- a/drivers/mfd/wm831x-otp.c +++ b/drivers/mfd/wm831x-otp.c @@ -38,8 +38,8 @@ static int wm831x_unique_id_read(struct wm831x *wm831x, char *id) return 0; } -static ssize_t wm831x_unique_id_show(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t unique_id_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct wm831x *wm831x = dev_get_drvdata(dev); int rval; @@ -52,7 +52,7 @@ static ssize_t wm831x_unique_id_show(struct device *dev, return sprintf(buf, "%*phN\n", WM831X_UNIQUE_ID_LEN, id); } -static DEVICE_ATTR(unique_id, 0444, wm831x_unique_id_show, NULL); +static DEVICE_ATTR_RO(unique_id); int wm831x_otp_init(struct wm831x *wm831x) { -- 2.26.0.106.g9fadedd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-02 11:44 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 11:43 [PATCH 0/9] mfd: use DEVICE_ATTR_* macro to simplify code Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-02 11:43 ` Zhen Lei [this message] 2021-06-02 11:43 ` [PATCH 1/9] mfd: wm831x: use DEVICE_ATTR_RO macro Zhen Lei 2021-06-02 12:39 ` Charles Keepax 2021-06-02 12:39 ` Charles Keepax 2021-06-15 11:50 ` Lee Jones 2021-06-15 11:50 ` Lee Jones 2021-06-02 11:43 ` [PATCH 2/9] mfd: ucb1x00-assabet: " Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-15 11:51 ` Lee Jones 2021-06-15 11:51 ` Lee Jones 2021-06-02 11:43 ` [PATCH 3/9] mfd: timberdale: " Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-15 11:51 ` Lee Jones 2021-06-15 11:51 ` Lee Jones 2021-06-02 11:43 ` [PATCH 4/9] mfd: sm501: " Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-15 12:03 ` Lee Jones 2021-06-15 12:03 ` Lee Jones 2021-06-02 11:43 ` [PATCH 5/9] mfd: pcf50633: use DEVICE_ATTR_ADMIN_RO macro Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-15 12:03 ` Lee Jones 2021-06-15 12:03 ` Lee Jones 2021-06-02 11:43 ` [PATCH 6/9] mfd: kempld-core: use DEVICE_ATTR_RO macro Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-15 12:14 ` Lee Jones 2021-06-15 12:14 ` Lee Jones 2021-06-02 11:43 ` [PATCH 7/9] mfd: janz-cmodio: " Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-15 12:14 ` Lee Jones 2021-06-15 12:14 ` Lee Jones 2021-06-02 11:43 ` [PATCH 8/9] mfd: intel_soc_pmic_bxtwc: use DEVICE_ATTR_ADMIN_RW macro Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-15 12:14 ` Lee Jones 2021-06-15 12:14 ` Lee Jones 2021-06-02 11:43 ` [PATCH 9/9] mfd: ab8500-core: use DEVICE_ATTR_RO/RW macro Zhen Lei 2021-06-02 11:43 ` Zhen Lei 2021-06-15 12:15 ` Lee Jones 2021-06-15 12:15 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210602114339.11223-2-thunder.leizhen@huawei.com \ --to=thunder.leizhen@huawei.com \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@opensource.cirrus.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.