* [PATCH] cobalt/thread: initialize sigarray in __xnthread_init
@ 2021-06-16 2:14 Hongzhan Chen
0 siblings, 0 replies; 3+ messages in thread
From: Hongzhan Chen @ 2021-06-16 2:14 UTC (permalink / raw)
To: xenomai
Add missing sigarray initialization to avoid missing signal in
__xnthread_signal.
Signed-off-by: Hongzhan Chen <hongzhan.chen@intel.com>
diff --git a/kernel/cobalt/thread.c b/kernel/cobalt/thread.c
index d096a20d3..65a666ada 100644
--- a/kernel/cobalt/thread.c
+++ b/kernel/cobalt/thread.c
@@ -287,6 +287,8 @@ int __xnthread_init(struct xnthread *thread,
thread->cookie = NULL;
init_completion(&thread->exited);
memset(xnthread_archtcb(thread), 0, sizeof(struct xnarchtcb));
+ memset(thread->sigarray, 0 ,sizeof(thread->sigarray[0]) *
+ XNTHREAD_MAX_SIGNALS);
gravity = flags & XNUSER ? XNTIMER_UGRAVITY : XNTIMER_KGRAVITY;
xntimer_init(&thread->rtimer, &nkclock, timeout_handler,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] cobalt/thread: initialize sigarray in __xnthread_init
@ 2021-06-16 2:19 Hongzhan Chen
2021-06-16 5:35 ` Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Hongzhan Chen @ 2021-06-16 2:19 UTC (permalink / raw)
To: xenomai
Add missing sigarray initialization to avoid missing signal in
__xnthread_signal.
Signed-off-by: Hongzhan Chen <hongzhan.chen@intel.com>
diff --git a/kernel/cobalt/thread.c b/kernel/cobalt/thread.c
index d096a20d3..49913accc 100644
--- a/kernel/cobalt/thread.c
+++ b/kernel/cobalt/thread.c
@@ -287,6 +287,8 @@ int __xnthread_init(struct xnthread *thread,
thread->cookie = NULL;
init_completion(&thread->exited);
memset(xnthread_archtcb(thread), 0, sizeof(struct xnarchtcb));
+ memset(thread->sigarray, 0, sizeof(thread->sigarray[0]) *
+ XNTHREAD_MAX_SIGNALS);
gravity = flags & XNUSER ? XNTIMER_UGRAVITY : XNTIMER_KGRAVITY;
xntimer_init(&thread->rtimer, &nkclock, timeout_handler,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cobalt/thread: initialize sigarray in __xnthread_init
2021-06-16 2:19 [PATCH] cobalt/thread: initialize sigarray in __xnthread_init Hongzhan Chen
@ 2021-06-16 5:35 ` Jan Kiszka
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2021-06-16 5:35 UTC (permalink / raw)
To: Hongzhan Chen, xenomai
On 16.06.21 04:19, Hongzhan Chen via Xenomai wrote:
> Add missing sigarray initialization to avoid missing signal in
> __xnthread_signal.
>
> Signed-off-by: Hongzhan Chen <hongzhan.chen@intel.com>
>
> diff --git a/kernel/cobalt/thread.c b/kernel/cobalt/thread.c
> index d096a20d3..49913accc 100644
> --- a/kernel/cobalt/thread.c
> +++ b/kernel/cobalt/thread.c
> @@ -287,6 +287,8 @@ int __xnthread_init(struct xnthread *thread,
> thread->cookie = NULL;
> init_completion(&thread->exited);
> memset(xnthread_archtcb(thread), 0, sizeof(struct xnarchtcb));
> + memset(thread->sigarray, 0, sizeof(thread->sigarray[0]) *
> + XNTHREAD_MAX_SIGNALS);
>
> gravity = flags & XNUSER ? XNTIMER_UGRAVITY : XNTIMER_KGRAVITY;
> xntimer_init(&thread->rtimer, &nkclock, timeout_handler,
>
Good catch! Queued, though like this:
memset(thread->sigarray, 0, sizeof(thread->sigarray));
Thanks,
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-16 5:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 2:19 [PATCH] cobalt/thread: initialize sigarray in __xnthread_init Hongzhan Chen
2021-06-16 5:35 ` Jan Kiszka
-- strict thread matches above, loose matches on Subject: below --
2021-06-16 2:14 Hongzhan Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.