* [agd5f:drm-next 53/84] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3628:17: warning: variable 'status' set but not used
@ 2021-06-16 2:58 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-06-16 2:58 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 7387 bytes --]
tree: https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head: 5fedbd64e1c0eedd28f478f280c6315d18ff7762
commit: ee9b1992f1fdf3726af010cd771b12205e0ce346 [53/84] drm/amd/display: Move LTTPR cap read into its own function
config: riscv-randconfig-r033-20210615 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f drm-next
git checkout ee9b1992f1fdf3726af010cd771b12205e0ce346
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1378:16: warning: no previous prototype for 'configure_lttpr_mode_transparent' [-Wmissing-prototypes]
1378 | enum dc_status configure_lttpr_mode_transparent(struct dc_link *link)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1389:16: warning: no previous prototype for 'configure_lttpr_mode_non_transparent' [-Wmissing-prototypes]
1389 | enum dc_status configure_lttpr_mode_non_transparent(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1637:16: warning: no previous prototype for 'dpcd_configure_channel_coding' [-Wmissing-prototypes]
1637 | enum dc_status dpcd_configure_channel_coding(struct dc_link *link,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3622:6: warning: no previous prototype for 'dp_retrieve_lttpr_cap' [-Wmissing-prototypes]
3622 | bool dp_retrieve_lttpr_cap(struct dc_link *link)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_retrieve_lttpr_cap':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3628:17: warning: variable 'status' set but not used [-Wunused-but-set-variable]
3628 | enum dc_status status = DC_ERROR_UNEXPECTED;
| ^~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for LOCKDEP
Depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && (FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86)
Selected by
- PROVE_LOCKING && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
- DEBUG_LOCK_ALLOC && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
vim +/status +3628 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c
3621
3622 bool dp_retrieve_lttpr_cap(struct dc_link *link)
3623 {
3624 uint8_t lttpr_dpcd_data[6];
3625 bool vbios_lttpr_enable = false;
3626 bool vbios_lttpr_interop = false;
3627 struct dc_bios *bios = link->dc->ctx->dc_bios;
> 3628 enum dc_status status = DC_ERROR_UNEXPECTED;
3629 bool is_lttpr_present = false;
3630
3631 memset(lttpr_dpcd_data, '\0', sizeof(lttpr_dpcd_data));
3632 /* Query BIOS to determine if LTTPR functionality is forced on by system */
3633 if (bios->funcs->get_lttpr_caps) {
3634 enum bp_result bp_query_result;
3635 uint8_t is_vbios_lttpr_enable = 0;
3636
3637 bp_query_result = bios->funcs->get_lttpr_caps(bios, &is_vbios_lttpr_enable);
3638 vbios_lttpr_enable = (bp_query_result == BP_RESULT_OK) && !!is_vbios_lttpr_enable;
3639 }
3640
3641 if (bios->funcs->get_lttpr_interop) {
3642 enum bp_result bp_query_result;
3643 uint8_t is_vbios_interop_enabled = 0;
3644
3645 bp_query_result = bios->funcs->get_lttpr_interop(bios, &is_vbios_interop_enabled);
3646 vbios_lttpr_interop = (bp_query_result == BP_RESULT_OK) && !!is_vbios_interop_enabled;
3647 }
3648
3649 /*
3650 * Logic to determine LTTPR mode
3651 */
3652 link->lttpr_mode = LTTPR_MODE_NON_LTTPR;
3653 if (vbios_lttpr_enable && vbios_lttpr_interop)
3654 link->lttpr_mode = LTTPR_MODE_NON_TRANSPARENT;
3655 else if (!vbios_lttpr_enable && vbios_lttpr_interop) {
3656 if (link->dc->config.allow_lttpr_non_transparent_mode)
3657 link->lttpr_mode = LTTPR_MODE_NON_TRANSPARENT;
3658 else
3659 link->lttpr_mode = LTTPR_MODE_TRANSPARENT;
3660 } else if (!vbios_lttpr_enable && !vbios_lttpr_interop) {
3661 if (!link->dc->config.allow_lttpr_non_transparent_mode
3662 || !link->dc->caps.extended_aux_timeout_support)
3663 link->lttpr_mode = LTTPR_MODE_NON_LTTPR;
3664 else
3665 link->lttpr_mode = LTTPR_MODE_NON_TRANSPARENT;
3666 }
3667
3668 if (link->lttpr_mode == LTTPR_MODE_NON_TRANSPARENT || link->lttpr_mode == LTTPR_MODE_TRANSPARENT) {
3669 /* By reading LTTPR capability, RX assumes that we will enable
3670 * LTTPR extended aux timeout if LTTPR is present.
3671 */
3672 status = core_link_read_dpcd(
3673 link,
3674 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV,
3675 lttpr_dpcd_data,
3676 sizeof(lttpr_dpcd_data));
3677
3678 link->dpcd_caps.lttpr_caps.revision.raw =
3679 lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV -
3680 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
3681
3682 link->dpcd_caps.lttpr_caps.max_link_rate =
3683 lttpr_dpcd_data[DP_MAX_LINK_RATE_PHY_REPEATER -
3684 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
3685
3686 link->dpcd_caps.lttpr_caps.phy_repeater_cnt =
3687 lttpr_dpcd_data[DP_PHY_REPEATER_CNT -
3688 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
3689
3690 link->dpcd_caps.lttpr_caps.max_lane_count =
3691 lttpr_dpcd_data[DP_MAX_LANE_COUNT_PHY_REPEATER -
3692 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
3693
3694 link->dpcd_caps.lttpr_caps.mode =
3695 lttpr_dpcd_data[DP_PHY_REPEATER_MODE -
3696 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
3697
3698 link->dpcd_caps.lttpr_caps.max_ext_timeout =
3699 lttpr_dpcd_data[DP_PHY_REPEATER_EXTENDED_WAIT_TIMEOUT -
3700 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
3701
3702 /* Attempt to train in LTTPR transparent mode if repeater count exceeds 8. */
3703 is_lttpr_present = (link->dpcd_caps.lttpr_caps.phy_repeater_cnt > 0 &&
3704 link->dpcd_caps.lttpr_caps.phy_repeater_cnt < 0xff &&
3705 link->dpcd_caps.lttpr_caps.max_lane_count > 0 &&
3706 link->dpcd_caps.lttpr_caps.max_lane_count <= 4 &&
3707 link->dpcd_caps.lttpr_caps.revision.raw >= 0x14);
3708 if (is_lttpr_present)
3709 CONN_DATA_DETECT(link, lttpr_dpcd_data, sizeof(lttpr_dpcd_data), "LTTPR Caps: ");
3710 else
3711 link->lttpr_mode = LTTPR_MODE_NON_LTTPR;
3712 }
3713 return is_lttpr_present;
3714 }
3715
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42342 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-16 2:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 2:58 [agd5f:drm-next 53/84] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3628:17: warning: variable 'status' set but not used kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.