From: kernel test robot <lkp@intel.com>
To: Chris Down <chris@chrisdown.name>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Petr Mladek <pmladek@suse.com>,
Jessica Yu <jeyu@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
John Ogness <john.ogness@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Kees Cook <keescook@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v7 4/5] printk: Userspace format indexing support
Date: Thu, 17 Jun 2021 15:36:08 +0800 [thread overview]
Message-ID: <202106171546.7koPrJBA-lkp@intel.com> (raw)
In-Reply-To: <e42070983637ac5e384f17fbdbe86d19c7b212a5.1623775748.git.chris@chrisdown.name>
[-- Attachment #1: Type: text/plain, Size: 4819 bytes --]
Hi Chris,
I love your patch! Perhaps something to improve:
[auto build test WARNING on jeyu/modules-next]
[also build test WARNING on linux/master soc/for-next openrisc/for-next powerpc/next asm-generic/master driver-core/driver-core-testing linus/master v5.13-rc6 next-20210616]
[cannot apply to uml/linux-next tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chris-Down/printk-Userspace-format-indexing-support/20210617-101450
base: https://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git modules-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/819166a91ddffdbf04d0b4e6905a5ab3b568194f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chris-Down/printk-Userspace-format-indexing-support/20210617-101450
git checkout 819166a91ddffdbf04d0b4e6905a5ab3b568194f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/printk/index.c: In function 'pi_show':
kernel/printk/index.c:72:2: error: implicit declaration of function 'seq_escape_str'; did you mean 'seq_escape'? [-Werror=implicit-function-declaration]
72 | seq_escape_str(s, src, ESCAPE_ANY | ESCAPE_NAP | ESCAPE_APPEND, "\"\\")
| ^~~~~~~~~~~~~~
kernel/printk/index.c:110:3: note: in expansion of macro 'seq_escape_printf_format'
110 | seq_escape_printf_format(s, entry->subsys_fmt_prefix);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/printk/index.c:72:38: error: 'ESCAPE_NAP' undeclared (first use in this function); did you mean 'ESCAPE_NP'?
72 | seq_escape_str(s, src, ESCAPE_ANY | ESCAPE_NAP | ESCAPE_APPEND, "\"\\")
| ^~~~~~~~~~
kernel/printk/index.c:110:3: note: in expansion of macro 'seq_escape_printf_format'
110 | seq_escape_printf_format(s, entry->subsys_fmt_prefix);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/printk/index.c:72:38: note: each undeclared identifier is reported only once for each function it appears in
72 | seq_escape_str(s, src, ESCAPE_ANY | ESCAPE_NAP | ESCAPE_APPEND, "\"\\")
| ^~~~~~~~~~
kernel/printk/index.c:110:3: note: in expansion of macro 'seq_escape_printf_format'
110 | seq_escape_printf_format(s, entry->subsys_fmt_prefix);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/printk/index.c:72:51: error: 'ESCAPE_APPEND' undeclared (first use in this function); did you mean 'ESCAPE_ANY'?
72 | seq_escape_str(s, src, ESCAPE_ANY | ESCAPE_NAP | ESCAPE_APPEND, "\"\\")
| ^~~~~~~~~~~~~
kernel/printk/index.c:110:3: note: in expansion of macro 'seq_escape_printf_format'
110 | seq_escape_printf_format(s, entry->subsys_fmt_prefix);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/printk/index.c: At top level:
>> kernel/printk/index.c:140:6: warning: no previous prototype for 'pi_create_file' [-Wmissing-prototypes]
140 | void pi_create_file(struct module *mod)
| ^~~~~~~~~~~~~~
>> kernel/printk/index.c:146:6: warning: no previous prototype for 'pi_remove_file' [-Wmissing-prototypes]
146 | void pi_remove_file(struct module *mod)
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +/pi_create_file +140 kernel/printk/index.c
139
> 140 void pi_create_file(struct module *mod)
141 {
142 debugfs_create_file(pi_get_module_name(mod), 0444, dfs_index,
143 mod, &dfs_index_fops);
144 }
145
> 146 void pi_remove_file(struct module *mod)
147 {
148 debugfs_remove(debugfs_lookup(pi_get_module_name(mod), dfs_index));
149 }
150
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54784 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v7 4/5] printk: Userspace format indexing support
Date: Thu, 17 Jun 2021 15:36:08 +0800 [thread overview]
Message-ID: <202106171546.7koPrJBA-lkp@intel.com> (raw)
In-Reply-To: <e42070983637ac5e384f17fbdbe86d19c7b212a5.1623775748.git.chris@chrisdown.name>
[-- Attachment #1: Type: text/plain, Size: 4911 bytes --]
Hi Chris,
I love your patch! Perhaps something to improve:
[auto build test WARNING on jeyu/modules-next]
[also build test WARNING on linux/master soc/for-next openrisc/for-next powerpc/next asm-generic/master driver-core/driver-core-testing linus/master v5.13-rc6 next-20210616]
[cannot apply to uml/linux-next tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chris-Down/printk-Userspace-format-indexing-support/20210617-101450
base: https://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git modules-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/819166a91ddffdbf04d0b4e6905a5ab3b568194f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chris-Down/printk-Userspace-format-indexing-support/20210617-101450
git checkout 819166a91ddffdbf04d0b4e6905a5ab3b568194f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/printk/index.c: In function 'pi_show':
kernel/printk/index.c:72:2: error: implicit declaration of function 'seq_escape_str'; did you mean 'seq_escape'? [-Werror=implicit-function-declaration]
72 | seq_escape_str(s, src, ESCAPE_ANY | ESCAPE_NAP | ESCAPE_APPEND, "\"\\")
| ^~~~~~~~~~~~~~
kernel/printk/index.c:110:3: note: in expansion of macro 'seq_escape_printf_format'
110 | seq_escape_printf_format(s, entry->subsys_fmt_prefix);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/printk/index.c:72:38: error: 'ESCAPE_NAP' undeclared (first use in this function); did you mean 'ESCAPE_NP'?
72 | seq_escape_str(s, src, ESCAPE_ANY | ESCAPE_NAP | ESCAPE_APPEND, "\"\\")
| ^~~~~~~~~~
kernel/printk/index.c:110:3: note: in expansion of macro 'seq_escape_printf_format'
110 | seq_escape_printf_format(s, entry->subsys_fmt_prefix);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/printk/index.c:72:38: note: each undeclared identifier is reported only once for each function it appears in
72 | seq_escape_str(s, src, ESCAPE_ANY | ESCAPE_NAP | ESCAPE_APPEND, "\"\\")
| ^~~~~~~~~~
kernel/printk/index.c:110:3: note: in expansion of macro 'seq_escape_printf_format'
110 | seq_escape_printf_format(s, entry->subsys_fmt_prefix);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/printk/index.c:72:51: error: 'ESCAPE_APPEND' undeclared (first use in this function); did you mean 'ESCAPE_ANY'?
72 | seq_escape_str(s, src, ESCAPE_ANY | ESCAPE_NAP | ESCAPE_APPEND, "\"\\")
| ^~~~~~~~~~~~~
kernel/printk/index.c:110:3: note: in expansion of macro 'seq_escape_printf_format'
110 | seq_escape_printf_format(s, entry->subsys_fmt_prefix);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/printk/index.c: At top level:
>> kernel/printk/index.c:140:6: warning: no previous prototype for 'pi_create_file' [-Wmissing-prototypes]
140 | void pi_create_file(struct module *mod)
| ^~~~~~~~~~~~~~
>> kernel/printk/index.c:146:6: warning: no previous prototype for 'pi_remove_file' [-Wmissing-prototypes]
146 | void pi_remove_file(struct module *mod)
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +/pi_create_file +140 kernel/printk/index.c
139
> 140 void pi_create_file(struct module *mod)
141 {
142 debugfs_create_file(pi_get_module_name(mod), 0444, dfs_index,
143 mod, &dfs_index_fops);
144 }
145
> 146 void pi_remove_file(struct module *mod)
147 {
148 debugfs_remove(debugfs_lookup(pi_get_module_name(mod), dfs_index));
149 }
150
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54784 bytes --]
next prev parent reply other threads:[~2021-06-17 7:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 16:52 [PATCH v7 0/5] printk: Userspace format indexing support Chris Down
2021-06-15 16:52 ` [PATCH v7 1/5] string_helpers: Escape double quotes in escape_special Chris Down
2021-06-15 21:42 ` Andy Shevchenko
2021-06-16 0:00 ` Chris Down
2021-06-16 2:05 ` Randy Dunlap
2021-06-16 8:08 ` Andy Shevchenko
2021-06-16 13:30 ` Steven Rostedt
2021-06-15 16:52 ` [PATCH v7 2/5] printk: Straighten out log_flags into printk_info_flags Chris Down
2021-06-15 16:52 ` [PATCH v7 3/5] printk: Rework parse_prefix into printk_parse_prefix Chris Down
2021-06-17 8:02 ` Petr Mladek
2021-06-15 16:52 ` [PATCH v7 4/5] printk: Userspace format indexing support Chris Down
2021-06-17 7:36 ` kernel test robot [this message]
2021-06-17 7:36 ` kernel test robot
2021-06-17 8:38 ` Andy Shevchenko
2021-06-17 8:38 ` Andy Shevchenko
2021-06-17 9:39 ` Petr Mladek
2021-06-17 9:39 ` Petr Mladek
2021-06-17 11:57 ` Chris Down
2021-06-17 11:57 ` Chris Down
2021-06-17 9:43 ` Petr Mladek
2021-06-18 11:48 ` kernel test robot
2021-06-18 11:48 ` kernel test robot
2021-06-18 12:19 ` Chris Down
2021-06-18 12:19 ` Chris Down
2021-06-18 15:00 ` Petr Mladek
2021-06-18 15:00 ` Petr Mladek
2021-06-15 16:52 ` [PATCH v7 5/5] printk: index: Add indexing support to dev_printk Chris Down
2021-06-17 10:02 ` Petr Mladek
2021-06-17 10:10 ` [PATCH v7 0/5] printk: Userspace format indexing support Petr Mladek
2021-06-17 12:33 ` Andy Shevchenko
2021-06-17 14:50 ` Chris Down
2021-06-17 14:52 ` Chris Down
2021-06-17 12:36 ` Jessica Yu
2021-06-21 8:54 ` Petr Mladek
2021-06-23 21:08 ` Andrew Morton
2021-06-25 9:35 ` Petr Mladek
2021-07-19 13:06 ` Petr Mladek
2021-07-19 13:08 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106171546.7koPrJBA-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=jeyu@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.