From: Clark Wang <xiaoning.wang@nxp.com>
To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
xiaoning.wang@nxp.com
Subject: [PATCH V2 1/5] i3c: master: svc: move module reset behind clk enable
Date: Fri, 16 Jul 2021 15:37:19 +0800 [thread overview]
Message-ID: <20210716073723.3490180-2-xiaoning.wang@nxp.com> (raw)
In-Reply-To: <20210716073723.3490180-1-xiaoning.wang@nxp.com>
Reset I3C module will R/W its regs, so enable its clocks first.
Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
V2: No change.
---
drivers/i3c/master/svc-i3c-master.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 879e5a64acaf..c25a372f6820 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1381,8 +1381,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
master->dev = dev;
- svc_i3c_master_reset(master);
-
ret = clk_prepare_enable(master->pclk);
if (ret)
return ret;
@@ -1419,6 +1417,8 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, master);
+ svc_i3c_master_reset(master);
+
/* Register the master */
ret = i3c_master_register(&master->base, &pdev->dev,
&svc_i3c_master_ops, false);
--
2.25.1
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Clark Wang <xiaoning.wang@nxp.com>
To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
xiaoning.wang@nxp.com
Subject: [PATCH V2 1/5] i3c: master: svc: move module reset behind clk enable
Date: Fri, 16 Jul 2021 15:37:19 +0800 [thread overview]
Message-ID: <20210716073723.3490180-2-xiaoning.wang@nxp.com> (raw)
In-Reply-To: <20210716073723.3490180-1-xiaoning.wang@nxp.com>
Reset I3C module will R/W its regs, so enable its clocks first.
Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
V2: No change.
---
drivers/i3c/master/svc-i3c-master.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 879e5a64acaf..c25a372f6820 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1381,8 +1381,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
master->dev = dev;
- svc_i3c_master_reset(master);
-
ret = clk_prepare_enable(master->pclk);
if (ret)
return ret;
@@ -1419,6 +1417,8 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, master);
+ svc_i3c_master_reset(master);
+
/* Register the master */
ret = i3c_master_register(&master->base, &pdev->dev,
&svc_i3c_master_ops, false);
--
2.25.1
next prev parent reply other threads:[~2021-07-16 7:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 7:37 [PATCH V2 0/5] i3c: master: svc: some bug fixes and add runtime pm support Clark Wang
2021-07-16 7:37 ` Clark Wang
2021-07-16 7:37 ` Clark Wang [this message]
2021-07-16 7:37 ` [PATCH V2 1/5] i3c: master: svc: move module reset behind clk enable Clark Wang
2021-07-16 7:37 ` [PATCH V2 2/5] i3c: master: svc: fix atomic issue Clark Wang
2021-07-16 7:37 ` Clark Wang
2021-07-16 7:37 ` [PATCH V2 3/5] i3c: master: svc: add support for slave to stop returning data Clark Wang
2021-07-16 7:37 ` Clark Wang
2021-07-16 7:37 ` [PATCH V2 4/5] i3c: master: svc: set ODSTOP to let I2C device see the STOP signal Clark Wang
2021-07-16 7:37 ` Clark Wang
2021-07-16 7:37 ` [PATCH V2 5/5] i3c: master: svc: add runtime pm support Clark Wang
2021-07-16 7:37 ` Clark Wang
2021-07-16 7:59 ` Miquel Raynal
2021-07-16 7:59 ` Miquel Raynal
2021-07-16 8:43 ` Clark Wang
2021-07-16 8:43 ` Clark Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716073723.3490180-2-xiaoning.wang@nxp.com \
--to=xiaoning.wang@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.