From: kernel test robot <lkp@intel.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator
Date: Sat, 27 Nov 2021 05:36:23 +0800 [thread overview]
Message-ID: <202111270521.Fwtu770n-lkp@intel.com> (raw)
In-Reply-To: <20211124084620.628-2-caihuoqing@baidu.com>
Hi Cai,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Cai-Huoqing/staging-zynpu-Add-driver-support-for-ARM-China-ZHOUYI-AI-accelerator/20211124-164741
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 1189d2fb15a4b09b2e8dd01d60a0817d985d933d
config: arm64-buildonly-randconfig-r006-20211126 (https://download.01.org/0day-ci/archive/20211127/202111270521.Fwtu770n-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5162b558d8c0b542e752b037e72a69d5fd51eb1e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/95965c589ea2e279e082e3c9aa18c2ddd8494d64
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Cai-Huoqing/staging-zynpu-Add-driver-support-for-ARM-China-ZHOUYI-AI-accelerator/20211124-164741
git checkout 95965c589ea2e279e082e3c9aa18c2ddd8494d64
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/iio/ drivers/irqchip/ drivers/spi/ drivers/staging/zynpu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/zynpu/zynpu_session.c:747:20: warning: no previous prototype for function 'zynpu_session_get_wait_queue' [-Wmissing-prototypes]
wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
^
drivers/staging/zynpu/zynpu_session.c:747:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
^
static
1 warning generated.
vim +/zynpu_session_get_wait_queue +747 drivers/staging/zynpu/zynpu_session.c
746
> 747 wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
748 {
749 struct zynpu_thread_wait_queue *queue = NULL;
750
751 if (!session) {
752 pr_err("invalid input session to be null!");
753 return NULL;
754 }
755
756 /* LOCK */
757 spin_lock(&session->job_lock);
758 queue = get_thread_wait_queue_no_lock(session->wait_queue_head, uthread_id);
759 spin_unlock(&session->job_lock);
760 /* UNLOCK */
761
762 if (queue)
763 return &queue->p_wait;
764
765 return NULL;
766 }
767
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator
Date: Sat, 27 Nov 2021 05:36:23 +0800 [thread overview]
Message-ID: <202111270521.Fwtu770n-lkp@intel.com> (raw)
In-Reply-To: <20211124084620.628-2-caihuoqing@baidu.com>
[-- Attachment #1: Type: text/plain, Size: 3108 bytes --]
Hi Cai,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Cai-Huoqing/staging-zynpu-Add-driver-support-for-ARM-China-ZHOUYI-AI-accelerator/20211124-164741
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 1189d2fb15a4b09b2e8dd01d60a0817d985d933d
config: arm64-buildonly-randconfig-r006-20211126 (https://download.01.org/0day-ci/archive/20211127/202111270521.Fwtu770n-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5162b558d8c0b542e752b037e72a69d5fd51eb1e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/95965c589ea2e279e082e3c9aa18c2ddd8494d64
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Cai-Huoqing/staging-zynpu-Add-driver-support-for-ARM-China-ZHOUYI-AI-accelerator/20211124-164741
git checkout 95965c589ea2e279e082e3c9aa18c2ddd8494d64
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/iio/ drivers/irqchip/ drivers/spi/ drivers/staging/zynpu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/zynpu/zynpu_session.c:747:20: warning: no previous prototype for function 'zynpu_session_get_wait_queue' [-Wmissing-prototypes]
wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
^
drivers/staging/zynpu/zynpu_session.c:747:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
^
static
1 warning generated.
vim +/zynpu_session_get_wait_queue +747 drivers/staging/zynpu/zynpu_session.c
746
> 747 wait_queue_head_t *zynpu_session_get_wait_queue(struct zynpu_session *session, int uthread_id)
748 {
749 struct zynpu_thread_wait_queue *queue = NULL;
750
751 if (!session) {
752 pr_err("invalid input session to be null!");
753 return NULL;
754 }
755
756 /* LOCK */
757 spin_lock(&session->job_lock);
758 queue = get_thread_wait_queue_no_lock(session->wait_queue_head, uthread_id);
759 spin_unlock(&session->job_lock);
760 /* UNLOCK */
761
762 if (queue)
763 return &queue->p_wait;
764
765 return NULL;
766 }
767
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-11-26 21:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 8:46 [PATCH v2 0/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator Cai Huoqing
2021-11-24 8:46 ` [PATCH v2 1/3] " Cai Huoqing
2021-11-24 8:52 ` Greg Kroah-Hartman
2021-11-24 9:09 ` Cai Huoqing
2021-11-24 12:25 ` Cai Huoqing
2021-11-26 21:36 ` kernel test robot [this message]
2021-11-26 21:36 ` kernel test robot
2021-11-27 0:34 ` kernel test robot
2021-11-27 0:34 ` kernel test robot
2021-11-27 1:04 ` kernel test robot
2021-11-27 1:04 ` kernel test robot
2021-11-24 8:46 ` [PATCH v2 2/3] dt-bindings: staging: Add the binding documentation for " Cai Huoqing
2021-11-25 21:26 ` Rob Herring
2021-11-24 8:46 ` [PATCH v2 3/3] MAINTAINERS: Add the driver info of the " Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111270521.Fwtu770n-lkp@intel.com \
--to=lkp@intel.com \
--cc=caihuoqing@baidu.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=llvm@lists.linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.