From: kernel test robot <lkp@intel.com>
To: Vasily Averin <vvs@virtuozzo.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, kernel@openvz.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs4: handle async processing of F_SETLK with FL_SLEEP
Date: Tue, 28 Dec 2021 01:58:15 +0800 [thread overview]
Message-ID: <202112280146.yo82FThq-lkp@intel.com> (raw)
In-Reply-To: <3a2c6cb9-abe7-ab32-b11c-d78621361555@virtuozzo.com>
Hi Vasily,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on trondmy-nfs/linux-next]
[also build test WARNING on v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vasily-Averin/nfs4-handle-async-processing-of-F_SETLK-with-FL_SLEEP/20211227-184632
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-r005-20211227 (https://download.01.org/0day-ci/archive/20211228/202112280146.yo82FThq-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 511726c64d3b6cca66f7c54d457d586aa3129f67)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7ae55d384b2f337e6630509e451c35dda45ae185
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vasily-Averin/nfs4-handle-async-processing-of-F_SETLK-with-FL_SLEEP/20211227-184632
git checkout 7ae55d384b2f337e6630509e451c35dda45ae185
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/nfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/nfs/nfs4proc.c:7202:25: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
if ((request->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
^ ~~~~~~~~
fs/nfs/nfs4proc.c:7202:25: note: use '&' for a bitwise operation
if ((request->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
^~
&
fs/nfs/nfs4proc.c:7202:25: note: remove constant to silence this warning
if ((request->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
~^~~~~~~~~~~
1 warning generated.
vim +7202 fs/nfs/nfs4proc.c
7193
7194 static int _nfs4_proc_setlk(struct nfs4_state *state, int cmd, struct file_lock *request)
7195 {
7196 struct nfs_inode *nfsi = NFS_I(state->inode);
7197 struct nfs4_state_owner *sp = state->owner;
7198 unsigned char fl_flags = request->fl_flags;
7199 int status;
7200
7201 request->fl_flags |= FL_ACCESS;
> 7202 if ((request->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
7203 status = posix_lock_file(request->fl_file, request, NULL);
7204 else
7205 status = locks_lock_inode_wait(state->inode, request);
7206 if (status)
7207 goto out;
7208 mutex_lock(&sp->so_delegreturn_mutex);
7209 down_read(&nfsi->rwsem);
7210 if (test_bit(NFS_DELEGATED_STATE, &state->flags)) {
7211 /* Yes: cache locks! */
7212 /* ...but avoid races with delegation recall... */
7213 request->fl_flags = fl_flags & ~FL_SLEEP;
7214 status = locks_lock_inode_wait(state->inode, request);
7215 up_read(&nfsi->rwsem);
7216 mutex_unlock(&sp->so_delegreturn_mutex);
7217 goto out;
7218 }
7219 up_read(&nfsi->rwsem);
7220 mutex_unlock(&sp->so_delegreturn_mutex);
7221 status = _nfs4_do_setlk(state, cmd, request, NFS_LOCK_NEW);
7222 out:
7223 request->fl_flags = fl_flags;
7224 return status;
7225 }
7226
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] nfs4: handle async processing of F_SETLK with FL_SLEEP
Date: Tue, 28 Dec 2021 01:58:15 +0800 [thread overview]
Message-ID: <202112280146.yo82FThq-lkp@intel.com> (raw)
In-Reply-To: <3a2c6cb9-abe7-ab32-b11c-d78621361555@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 3825 bytes --]
Hi Vasily,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on trondmy-nfs/linux-next]
[also build test WARNING on v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vasily-Averin/nfs4-handle-async-processing-of-F_SETLK-with-FL_SLEEP/20211227-184632
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-r005-20211227 (https://download.01.org/0day-ci/archive/20211228/202112280146.yo82FThq-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 511726c64d3b6cca66f7c54d457d586aa3129f67)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7ae55d384b2f337e6630509e451c35dda45ae185
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vasily-Averin/nfs4-handle-async-processing-of-F_SETLK-with-FL_SLEEP/20211227-184632
git checkout 7ae55d384b2f337e6630509e451c35dda45ae185
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/nfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/nfs/nfs4proc.c:7202:25: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
if ((request->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
^ ~~~~~~~~
fs/nfs/nfs4proc.c:7202:25: note: use '&' for a bitwise operation
if ((request->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
^~
&
fs/nfs/nfs4proc.c:7202:25: note: remove constant to silence this warning
if ((request->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
~^~~~~~~~~~~
1 warning generated.
vim +7202 fs/nfs/nfs4proc.c
7193
7194 static int _nfs4_proc_setlk(struct nfs4_state *state, int cmd, struct file_lock *request)
7195 {
7196 struct nfs_inode *nfsi = NFS_I(state->inode);
7197 struct nfs4_state_owner *sp = state->owner;
7198 unsigned char fl_flags = request->fl_flags;
7199 int status;
7200
7201 request->fl_flags |= FL_ACCESS;
> 7202 if ((request->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
7203 status = posix_lock_file(request->fl_file, request, NULL);
7204 else
7205 status = locks_lock_inode_wait(state->inode, request);
7206 if (status)
7207 goto out;
7208 mutex_lock(&sp->so_delegreturn_mutex);
7209 down_read(&nfsi->rwsem);
7210 if (test_bit(NFS_DELEGATED_STATE, &state->flags)) {
7211 /* Yes: cache locks! */
7212 /* ...but avoid races with delegation recall... */
7213 request->fl_flags = fl_flags & ~FL_SLEEP;
7214 status = locks_lock_inode_wait(state->inode, request);
7215 up_read(&nfsi->rwsem);
7216 mutex_unlock(&sp->so_delegreturn_mutex);
7217 goto out;
7218 }
7219 up_read(&nfsi->rwsem);
7220 mutex_unlock(&sp->so_delegreturn_mutex);
7221 status = _nfs4_do_setlk(state, cmd, request, NFS_LOCK_NEW);
7222 out:
7223 request->fl_flags = fl_flags;
7224 return status;
7225 }
7226
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-27 17:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 10:45 [PATCH] nfs4: handle async processing of F_SETLK with FL_SLEEP Vasily Averin
2021-12-27 15:51 ` [PATCH v2] " Vasily Averin
2021-12-28 1:04 ` Vasily Averin
2021-12-29 8:24 ` [PATCH v3 1/3] nfs: local_lock: " Vasily Averin
2021-12-29 8:24 ` [PATCH v3 2/3] nfs4: " Vasily Averin
2022-01-03 19:40 ` J. Bruce Fields
2022-01-16 12:25 ` Vasily Averin
2022-01-03 19:53 ` J. Bruce Fields
2022-01-16 12:44 ` Vasily Averin
2022-01-16 18:28 ` Vasily Averin
2022-01-18 22:35 ` J. Bruce Fields
2021-12-29 8:24 ` [PATCH v3 3/3] nfs v2/3: nlmclnt_lock: " Vasily Averin
2021-12-27 17:58 ` kernel test robot [this message]
2021-12-27 17:58 ` [PATCH] nfs4: " kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-12-28 8:43 kernel test robot
2022-01-06 10:37 ` Dan Carpenter
2022-01-06 10:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112280146.yo82FThq-lkp@intel.com \
--to=lkp@intel.com \
--cc=anna.schumaker@netapp.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=trond.myklebust@hammerspace.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.