From: Xavier Drudis Ferran <xdrudis@tinet.cat>
To: Lee Jones <lee.jones@linaro.org>
Cc: sjg@chromium.org, philipp.tomsich@vrull.eu,
kever.yang@rock-chips.com, cym@rock-chips.com,
u-boot@lists.denx.de
Subject: Re: [SPAM] [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling
Date: Mon, 4 Jul 2022 11:57:01 +0200 [thread overview]
Message-ID: <20220704095701.GB1912@begut> (raw)
In-Reply-To: <20220621100729.979275-1-lee.jones@linaro.org>
El Tue, Jun 21, 2022 at 10:07:27AM +0000, Lee Jones deia:
> Functions pointed to by this op pointer can return non-zero values
> indicating an error. Ensure any error value is propagated back up the
> call-chain.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
My board doesn't suffer with the issue resolved by this series,
however I did apply it and nothing regressed.
Tested-by: Xavier Drudis Ferran <xdrudis@tinet.cat>
> ---
> drivers/ram/rockchip/sdram_rk3399.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index c0a06dcaed..0af0fa9e7b 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -3005,7 +3005,9 @@ static int sdram_init(struct dram_info *dram,
> params->base.stride = calculate_stride(params);
> dram_all_config(dram, params);
>
> - dram->ops->set_rate_index(dram, params);
> + ret = dram->ops->set_rate_index(dram, params);
> + if (ret)
> + return ret;
>
> debug("Finish SDRAM initialization...\n");
> return 0;
> --
> 2.37.0.rc0.104.g0611611a94-goog
>
prev parent reply other threads:[~2022-07-04 9:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 10:07 [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Lee Jones
2022-06-21 10:07 ` [PATCH 2/3] ram: rk3399: Fix faulty frequency change reports Lee Jones
2022-07-01 12:04 ` Kever Yang
2022-07-04 10:00 ` Xavier Drudis Ferran
2022-06-21 10:07 ` [PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz Lee Jones
2022-07-01 12:05 ` Kever Yang
2022-07-04 10:01 ` Xavier Drudis Ferran
2022-06-27 8:39 ` [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Lee Jones
2022-07-01 12:05 ` Kever Yang
2022-07-04 9:23 ` Lee Jones
2022-07-04 10:49 ` Kever Yang
2022-07-04 10:58 ` Lee Jones
2022-07-01 12:04 ` Kever Yang
2022-07-04 9:57 ` Xavier Drudis Ferran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704095701.GB1912@begut \
--to=xdrudis@tinet.cat \
--cc=cym@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=lee.jones@linaro.org \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.