From: Kever Yang <kever.yang@rock-chips.com>
To: Lee Jones <lee.jones@linaro.org>,
sjg@chromium.org, philipp.tomsich@vrull.eu
Cc: cym@rock-chips.com, u-boot@lists.denx.de
Subject: Re: [PATCH 2/3] ram: rk3399: Fix faulty frequency change reports
Date: Fri, 1 Jul 2022 20:04:54 +0800 [thread overview]
Message-ID: <c3461e85-c72f-7a4a-9804-27be1fbedc6d@rock-chips.com> (raw)
In-Reply-To: <20220621100729.979275-2-lee.jones@linaro.org>
On 2022/6/21 18:07, Lee Jones wrote:
> Frequency changes to 400MHz are presently reported as:
>
> lpddr4_set_rate_0: change freq to 400000000 mhz 0, 1
>
> This is obviously wrong by 6 orders of magnitude.
>
> Ensure frequency changes are reported accurately.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> drivers/ram/rockchip/sdram_rk3399.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index 0af0fa9e7b..34d6c93f95 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -2552,8 +2552,8 @@ static int lpddr4_set_rate(struct dram_info *dram,
> dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq);
>
> if (IS_ENABLED(CONFIG_RAM_ROCKCHIP_DEBUG))
> - printf("%s: change freq to %d mhz %d, %d\n", __func__,
> - dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq,
> + printf("%s: change freq to %dMHz %d, %d\n", __func__,
> + dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq / MHz,
> ctl_fn, phy_fn);
> }
>
next prev parent reply other threads:[~2022-07-01 12:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 10:07 [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Lee Jones
2022-06-21 10:07 ` [PATCH 2/3] ram: rk3399: Fix faulty frequency change reports Lee Jones
2022-07-01 12:04 ` Kever Yang [this message]
2022-07-04 10:00 ` Xavier Drudis Ferran
2022-06-21 10:07 ` [PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz Lee Jones
2022-07-01 12:05 ` Kever Yang
2022-07-04 10:01 ` Xavier Drudis Ferran
2022-06-27 8:39 ` [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Lee Jones
2022-07-01 12:05 ` Kever Yang
2022-07-04 9:23 ` Lee Jones
2022-07-04 10:49 ` Kever Yang
2022-07-04 10:58 ` Lee Jones
2022-07-01 12:04 ` Kever Yang
2022-07-04 9:57 ` [SPAM] " Xavier Drudis Ferran
-- strict thread matches above, loose matches on Subject: below --
2022-08-11 7:58 [PATCH 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4) Lee Jones
2022-08-11 7:58 ` [PATCH 2/3] ram: rk3399: Fix faulty frequency change reports Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3461e85-c72f-7a4a-9804-27be1fbedc6d@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=cym@rock-chips.com \
--cc=lee.jones@linaro.org \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.