From: Bernd Kuhls <bernd.kuhls@t-online.de>
To: buildroot@buildroot.org
Cc: Adrian Perez de Castro <aperez@igalia.com>
Subject: [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE
Date: Tue, 5 Jul 2022 08:41:19 +0200 [thread overview]
Message-ID: <20220705064119.1041728-1-bernd.kuhls@t-online.de> (raw)
Fixes build error
Checking for function "iconv_open" : NO
Header <iconv.h> has symbol "iconv_open" : NO
output/build/libpsl-0.21.1/meson.build:101:4:
ERROR: Problem encountered: iconv implementation not found
using this defconfig:
BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_PACKAGE_LIBPSL=y
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/libpsl/Config.in | 1 +
package/libpsl/libpsl.mk | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/package/libpsl/Config.in b/package/libpsl/Config.in
index a4cbce6b43..7b02d961c8 100644
--- a/package/libpsl/Config.in
+++ b/package/libpsl/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_LIBPSL
bool "libpsl"
depends on BR2_USE_WCHAR # libunistring, icu
+ select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
select BR2_PACKAGE_LIBIDN2 if !BR2_PACKAGE_ICU && !BR2_PACKAGE_LIBIDN
select BR2_PACKAGE_LIBUNISTRING if !BR2_PACKAGE_ICU
help
diff --git a/package/libpsl/libpsl.mk b/package/libpsl/libpsl.mk
index 5dc03a7c24..742117e8ea 100644
--- a/package/libpsl/libpsl.mk
+++ b/package/libpsl/libpsl.mk
@@ -11,6 +11,10 @@ LIBPSL_LICENSE_FILES = COPYING src/LICENSE.chromium
LIBPSL_DEPENDENCIES = host-pkgconf
LIBPSL_INSTALL_STAGING = YES
+ifeq ($(BR2_ENABLE_LOCALE),)
+LIBPSL_DEPENDENCIES += libiconv
+endif
+
# The order of checks is the same as done by libpsl when configured.
ifeq ($(BR2_PACKAGE_LIBIDN2)$(BR2_PACKAGE_LIBUNISTRING),yy)
LIBPSL_CONF_OPTS += -Druntime=libidn2 -Dbuiltin=libidn2
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2022-07-05 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 6:41 Bernd Kuhls [this message]
2022-07-05 8:16 ` [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE Adrian Perez de Castro
2022-07-20 12:48 ` Thomas Petazzoni via buildroot
2022-08-11 11:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705064119.1041728-1-bernd.kuhls@t-online.de \
--to=bernd.kuhls@t-online.de \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.