* [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE
@ 2022-07-05 6:41 Bernd Kuhls
2022-07-05 8:16 ` Adrian Perez de Castro
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bernd Kuhls @ 2022-07-05 6:41 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
Fixes build error
Checking for function "iconv_open" : NO
Header <iconv.h> has symbol "iconv_open" : NO
output/build/libpsl-0.21.1/meson.build:101:4:
ERROR: Problem encountered: iconv implementation not found
using this defconfig:
BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_PACKAGE_LIBPSL=y
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/libpsl/Config.in | 1 +
package/libpsl/libpsl.mk | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/package/libpsl/Config.in b/package/libpsl/Config.in
index a4cbce6b43..7b02d961c8 100644
--- a/package/libpsl/Config.in
+++ b/package/libpsl/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_LIBPSL
bool "libpsl"
depends on BR2_USE_WCHAR # libunistring, icu
+ select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
select BR2_PACKAGE_LIBIDN2 if !BR2_PACKAGE_ICU && !BR2_PACKAGE_LIBIDN
select BR2_PACKAGE_LIBUNISTRING if !BR2_PACKAGE_ICU
help
diff --git a/package/libpsl/libpsl.mk b/package/libpsl/libpsl.mk
index 5dc03a7c24..742117e8ea 100644
--- a/package/libpsl/libpsl.mk
+++ b/package/libpsl/libpsl.mk
@@ -11,6 +11,10 @@ LIBPSL_LICENSE_FILES = COPYING src/LICENSE.chromium
LIBPSL_DEPENDENCIES = host-pkgconf
LIBPSL_INSTALL_STAGING = YES
+ifeq ($(BR2_ENABLE_LOCALE),)
+LIBPSL_DEPENDENCIES += libiconv
+endif
+
# The order of checks is the same as done by libpsl when configured.
ifeq ($(BR2_PACKAGE_LIBIDN2)$(BR2_PACKAGE_LIBUNISTRING),yy)
LIBPSL_CONF_OPTS += -Druntime=libidn2 -Dbuiltin=libidn2
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE
2022-07-05 6:41 [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE Bernd Kuhls
@ 2022-07-05 8:16 ` Adrian Perez de Castro
2022-07-20 12:48 ` Thomas Petazzoni via buildroot
2022-08-11 11:44 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Perez de Castro @ 2022-07-05 8:16 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: buildroot
[-- Attachment #1.1: Type: text/plain, Size: 1894 bytes --]
On Tue, 05 Jul 2022 08:41:19 +0200 Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Fixes build error
>
> Checking for function "iconv_open" : NO
> Header <iconv.h> has symbol "iconv_open" : NO
>
> output/build/libpsl-0.21.1/meson.build:101:4:
> ERROR: Problem encountered: iconv implementation not found
>
> using this defconfig:
>
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> BR2_PACKAGE_LIBPSL=y
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/libpsl/Config.in | 1 +
> package/libpsl/libpsl.mk | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/package/libpsl/Config.in b/package/libpsl/Config.in
> index a4cbce6b43..7b02d961c8 100644
> --- a/package/libpsl/Config.in
> +++ b/package/libpsl/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_LIBPSL
> bool "libpsl"
> depends on BR2_USE_WCHAR # libunistring, icu
> + select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
> select BR2_PACKAGE_LIBIDN2 if !BR2_PACKAGE_ICU && !BR2_PACKAGE_LIBIDN
> select BR2_PACKAGE_LIBUNISTRING if !BR2_PACKAGE_ICU
> help
> diff --git a/package/libpsl/libpsl.mk b/package/libpsl/libpsl.mk
> index 5dc03a7c24..742117e8ea 100644
> --- a/package/libpsl/libpsl.mk
> +++ b/package/libpsl/libpsl.mk
> @@ -11,6 +11,10 @@ LIBPSL_LICENSE_FILES = COPYING src/LICENSE.chromium
> LIBPSL_DEPENDENCIES = host-pkgconf
> LIBPSL_INSTALL_STAGING = YES
>
> +ifeq ($(BR2_ENABLE_LOCALE),)
> +LIBPSL_DEPENDENCIES += libiconv
> +endif
> +
> # The order of checks is the same as done by libpsl when configured.
> ifeq ($(BR2_PACKAGE_LIBIDN2)$(BR2_PACKAGE_LIBUNISTRING),yy)
> LIBPSL_CONF_OPTS += -Druntime=libidn2 -Dbuiltin=libidn2
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE
2022-07-05 6:41 [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE Bernd Kuhls
2022-07-05 8:16 ` Adrian Perez de Castro
@ 2022-07-20 12:48 ` Thomas Petazzoni via buildroot
2022-08-11 11:44 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-20 12:48 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: Adrian Perez de Castro, buildroot
On Tue, 5 Jul 2022 08:41:19 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Fixes build error
>
> Checking for function "iconv_open" : NO
> Header <iconv.h> has symbol "iconv_open" : NO
>
> output/build/libpsl-0.21.1/meson.build:101:4:
> ERROR: Problem encountered: iconv implementation not found
>
> using this defconfig:
>
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> BR2_PACKAGE_LIBPSL=y
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libpsl/Config.in | 1 +
> package/libpsl/libpsl.mk | 4 ++++
> 2 files changed, 5 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE
2022-07-05 6:41 [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE Bernd Kuhls
2022-07-05 8:16 ` Adrian Perez de Castro
2022-07-20 12:48 ` Thomas Petazzoni via buildroot
@ 2022-08-11 11:44 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-08-11 11:44 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: Adrian Perez de Castro, buildroot
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:
> Fixes build error
> Checking for function "iconv_open" : NO
> Header <iconv.h> has symbol "iconv_open" : NO
> output/build/libpsl-0.21.1/meson.build:101:4:
> ERROR: Problem encountered: iconv implementation not found
> using this defconfig:
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> BR2_PACKAGE_LIBPSL=y
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-11 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 6:41 [Buildroot] [PATCH 1/1] package/libpsl: require libiconv if !BR2_ENABLE_LOCALE Bernd Kuhls
2022-07-05 8:16 ` Adrian Perez de Castro
2022-07-20 12:48 ` Thomas Petazzoni via buildroot
2022-08-11 11:44 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.