From: kernel test robot <lkp@intel.com>
To: Zhenneng Li <lizhenneng@kylinos.cn>,
Alex Deucher <alexander.deucher@amd.com>
Cc: kbuild-all@lists.01.org,
"Christian König" <christian.koenig@amd.com>,
"Pan Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Tao Zhou" <tao.zhou1@amd.com>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Jack Xiao" <Jack.Xiao@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Zhenneng Li" <lizhenneng@kylinos.cn>
Subject: Re: [PATCH] drm/amdgpu: use native mode for dp aux transfer
Date: Sun, 31 Jul 2022 21:38:51 +0800 [thread overview]
Message-ID: <202207312143.yefmpijn-lkp@intel.com> (raw)
In-Reply-To: <20220720021639.58406-1-lizhenneng@kylinos.cn>
Hi Zhenneng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v5.19-rc8 next-20220728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zhenneng-Li/drm-amdgpu-use-native-mode-for-dp-aux-transfer/20220720-103324
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
config: csky-randconfig-r036-20220718 (https://download.01.org/0day-ci/archive/20220731/202207312143.yefmpijn-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/8429a257cb9bf2f0e850afeef0a3dbc4cd3006da
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zhenneng-Li/drm-amdgpu-use-native-mode-for-dp-aux-transfer/20220720-103324
git checkout 8429a257cb9bf2f0e850afeef0a3dbc4cd3006da
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c:73:10: warning: no previous prototype for 'venus_mm_rreg_slow' [-Wmissing-prototypes]
73 | uint32_t venus_mm_rreg_slow(struct amdgpu_device *adev, uint32_t reg)
| ^~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c:84:6: warning: no previous prototype for 'venus_mm_wreg_slow' [-Wmissing-prototypes]
84 | void venus_mm_wreg_slow(struct amdgpu_device *adev, uint32_t reg, uint32_t v)
| ^~~~~~~~~~~~~~~~~~
vim +/venus_mm_rreg_slow +73 drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c
69
70 #define R100_MM_INDEX 0x0000
71 #define R100_MM_DATA 0x0004
72 #define AMDGPU_MIN_MMIO_SIZE 0x10000
> 73 uint32_t venus_mm_rreg_slow(struct amdgpu_device *adev, uint32_t reg)
74 {
75 unsigned long flags;
76 uint32_t ret;
77
78 spin_lock_irqsave(&adev->mmio_idx_lock, flags);
79 writel(reg, ((void __iomem *)adev->rmmio) + R100_MM_INDEX);
80 ret = readl(((void __iomem *)adev->rmmio) + R100_MM_DATA);
81 spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
82 return ret;
83 }
> 84 void venus_mm_wreg_slow(struct amdgpu_device *adev, uint32_t reg, uint32_t v)
85 {
86 unsigned long flags;
87
88 spin_lock_irqsave(&adev->mmio_idx_lock, flags);
89 writel(reg, ((void __iomem *)adev->rmmio) + R100_MM_INDEX);
90 writel(v, ((void __iomem *)adev->rmmio) + R100_MM_DATA);
91 spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
92 }
93 static inline uint32_t venus_mm_rreg(struct amdgpu_device *adev, uint32_t reg,
94 bool always_indirect)
95 {
96 /* The mmio size is 64kb at minimum. Allows the if to be optimized out. */
97 if ((reg < adev->rmmio_size || reg < AMDGPU_MIN_MMIO_SIZE) && !always_indirect)
98 return readl(((void __iomem *)adev->rmmio) + reg);
99 else
100 return venus_mm_rreg_slow(adev, reg);
101 }
102 static inline void venus_mm_wreg(struct amdgpu_device *adev, uint32_t reg, uint32_t v,
103 bool always_indirect)
104 {
105 if ((reg < adev->rmmio_size || reg < AMDGPU_MIN_MMIO_SIZE) && !always_indirect)
106 writel(v, ((void __iomem *)adev->rmmio) + reg);
107 else
108 venus_mm_wreg_slow(adev, reg, v);
109 }
110
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-31 13:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 2:16 [PATCH] drm/amdgpu: use native mode for dp aux transfer Zhenneng Li
2022-07-20 2:16 ` Zhenneng Li
2022-07-20 2:16 ` Zhenneng Li
2022-07-31 13:38 ` kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-11 7:20 Zhenneng Li
2022-08-11 7:20 ` Zhenneng Li
2022-08-11 7:20 ` Zhenneng Li
2022-08-11 13:57 ` Alex Deucher
2022-08-11 13:57 ` Alex Deucher
2022-08-11 23:42 ` kernel test robot
2022-08-11 23:42 ` kernel test robot
2022-08-12 20:00 ` kernel test robot
2022-08-12 20:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207312143.yefmpijn-lkp@intel.com \
--to=lkp@intel.com \
--cc=Felix.Kuehling@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Xiao@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhenneng@kylinos.cn \
--cc=tao.zhou1@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.