From: kernel test robot <lkp@intel.com>
To: Zhenneng Li <lizhenneng@kylinos.cn>,
Alex Deucher <alexander.deucher@amd.com>
Cc: "Jack Xiao" <Jack.Xiao@amd.com>, "Tao Zhou" <tao.zhou1@amd.com>,
kbuild-all@lists.01.org, "David Airlie" <airlied@linux.ie>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Pan Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Zhenneng Li" <lizhenneng@kylinos.cn>,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: Re: [PATCH] drm/amdgpu: use native mode for dp aux transfer
Date: Fri, 12 Aug 2022 07:42:53 +0800 [thread overview]
Message-ID: <202208120737.JG7NkugC-lkp@intel.com> (raw)
In-Reply-To: <20220811072012.962460-1-lizhenneng@kylinos.cn>
Hi Zhenneng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v5.19 next-20220811]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zhenneng-Li/drm-amdgpu-use-native-mode-for-dp-aux-transfer/20220811-193443
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220812/202208120737.JG7NkugC-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/1098c6fecb4292d634dbdccff9e720400dc7138d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zhenneng-Li/drm-amdgpu-use-native-mode-for-dp-aux-transfer/20220811-193443
git checkout 1098c6fecb4292d634dbdccff9e720400dc7138d
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/amd/amdgpu/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c:73:10: warning: no previous prototype for 'venus_mm_rreg_slow' [-Wmissing-prototypes]
73 | uint32_t venus_mm_rreg_slow(struct amdgpu_device *adev, uint32_t reg)
| ^~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c:84:6: warning: no previous prototype for 'venus_mm_wreg_slow' [-Wmissing-prototypes]
84 | void venus_mm_wreg_slow(struct amdgpu_device *adev, uint32_t reg, uint32_t v)
| ^~~~~~~~~~~~~~~~~~
vim +/venus_mm_rreg_slow +73 drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c
69
70 #define R100_MM_INDEX 0x0000
71 #define R100_MM_DATA 0x0004
72 #define AMDGPU_MIN_MMIO_SIZE 0x10000
> 73 uint32_t venus_mm_rreg_slow(struct amdgpu_device *adev, uint32_t reg)
74 {
75 unsigned long flags;
76 uint32_t ret;
77
78 spin_lock_irqsave(&adev->mmio_idx_lock, flags);
79 writel(reg, ((void __iomem *)adev->rmmio) + R100_MM_INDEX);
80 ret = readl(((void __iomem *)adev->rmmio) + R100_MM_DATA);
81 spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
82 return ret;
83 }
> 84 void venus_mm_wreg_slow(struct amdgpu_device *adev, uint32_t reg, uint32_t v)
85 {
86 unsigned long flags;
87
88 spin_lock_irqsave(&adev->mmio_idx_lock, flags);
89 writel(reg, ((void __iomem *)adev->rmmio) + R100_MM_INDEX);
90 writel(v, ((void __iomem *)adev->rmmio) + R100_MM_DATA);
91 spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
92 }
93 static inline uint32_t venus_mm_rreg(struct amdgpu_device *adev, uint32_t reg,
94 bool always_indirect)
95 {
96 /* The mmio size is 64kb at minimum. Allows the if to be optimized out. */
97 if ((reg < adev->rmmio_size || reg < AMDGPU_MIN_MMIO_SIZE) && !always_indirect)
98 return readl(((void __iomem *)adev->rmmio) + reg);
99 else
100 return venus_mm_rreg_slow(adev, reg);
101 }
102 static inline void venus_mm_wreg(struct amdgpu_device *adev, uint32_t reg, uint32_t v,
103 bool always_indirect)
104 {
105 if ((reg < adev->rmmio_size || reg < AMDGPU_MIN_MMIO_SIZE) && !always_indirect)
106 writel(v, ((void __iomem *)adev->rmmio) + reg);
107 else
108 venus_mm_wreg_slow(adev, reg, v);
109 }
110
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Zhenneng Li <lizhenneng@kylinos.cn>,
Alex Deucher <alexander.deucher@amd.com>
Cc: kbuild-all@lists.01.org, "Jack Xiao" <Jack.Xiao@amd.com>,
"Tao Zhou" <tao.zhou1@amd.com>, "David Airlie" <airlied@linux.ie>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Pan Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Zhenneng Li" <lizhenneng@kylinos.cn>,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: Re: [PATCH] drm/amdgpu: use native mode for dp aux transfer
Date: Fri, 12 Aug 2022 07:42:53 +0800 [thread overview]
Message-ID: <202208120737.JG7NkugC-lkp@intel.com> (raw)
In-Reply-To: <20220811072012.962460-1-lizhenneng@kylinos.cn>
Hi Zhenneng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v5.19 next-20220811]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zhenneng-Li/drm-amdgpu-use-native-mode-for-dp-aux-transfer/20220811-193443
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220812/202208120737.JG7NkugC-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/1098c6fecb4292d634dbdccff9e720400dc7138d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zhenneng-Li/drm-amdgpu-use-native-mode-for-dp-aux-transfer/20220811-193443
git checkout 1098c6fecb4292d634dbdccff9e720400dc7138d
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/amd/amdgpu/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c:73:10: warning: no previous prototype for 'venus_mm_rreg_slow' [-Wmissing-prototypes]
73 | uint32_t venus_mm_rreg_slow(struct amdgpu_device *adev, uint32_t reg)
| ^~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c:84:6: warning: no previous prototype for 'venus_mm_wreg_slow' [-Wmissing-prototypes]
84 | void venus_mm_wreg_slow(struct amdgpu_device *adev, uint32_t reg, uint32_t v)
| ^~~~~~~~~~~~~~~~~~
vim +/venus_mm_rreg_slow +73 drivers/gpu/drm/amd/amdgpu/amdgpu_dp_auxch.c
69
70 #define R100_MM_INDEX 0x0000
71 #define R100_MM_DATA 0x0004
72 #define AMDGPU_MIN_MMIO_SIZE 0x10000
> 73 uint32_t venus_mm_rreg_slow(struct amdgpu_device *adev, uint32_t reg)
74 {
75 unsigned long flags;
76 uint32_t ret;
77
78 spin_lock_irqsave(&adev->mmio_idx_lock, flags);
79 writel(reg, ((void __iomem *)adev->rmmio) + R100_MM_INDEX);
80 ret = readl(((void __iomem *)adev->rmmio) + R100_MM_DATA);
81 spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
82 return ret;
83 }
> 84 void venus_mm_wreg_slow(struct amdgpu_device *adev, uint32_t reg, uint32_t v)
85 {
86 unsigned long flags;
87
88 spin_lock_irqsave(&adev->mmio_idx_lock, flags);
89 writel(reg, ((void __iomem *)adev->rmmio) + R100_MM_INDEX);
90 writel(v, ((void __iomem *)adev->rmmio) + R100_MM_DATA);
91 spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
92 }
93 static inline uint32_t venus_mm_rreg(struct amdgpu_device *adev, uint32_t reg,
94 bool always_indirect)
95 {
96 /* The mmio size is 64kb at minimum. Allows the if to be optimized out. */
97 if ((reg < adev->rmmio_size || reg < AMDGPU_MIN_MMIO_SIZE) && !always_indirect)
98 return readl(((void __iomem *)adev->rmmio) + reg);
99 else
100 return venus_mm_rreg_slow(adev, reg);
101 }
102 static inline void venus_mm_wreg(struct amdgpu_device *adev, uint32_t reg, uint32_t v,
103 bool always_indirect)
104 {
105 if ((reg < adev->rmmio_size || reg < AMDGPU_MIN_MMIO_SIZE) && !always_indirect)
106 writel(v, ((void __iomem *)adev->rmmio) + reg);
107 else
108 venus_mm_wreg_slow(adev, reg, v);
109 }
110
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-08-11 23:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 7:20 [PATCH] drm/amdgpu: use native mode for dp aux transfer Zhenneng Li
2022-08-11 7:20 ` Zhenneng Li
2022-08-11 7:20 ` Zhenneng Li
2022-08-11 13:57 ` Alex Deucher
2022-08-11 13:57 ` Alex Deucher
2022-08-11 23:42 ` kernel test robot [this message]
2022-08-11 23:42 ` kernel test robot
2022-08-12 20:00 ` kernel test robot
2022-08-12 20:00 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-07-20 2:16 Zhenneng Li
2022-07-20 2:16 ` Zhenneng Li
2022-07-20 2:16 ` Zhenneng Li
2022-07-31 13:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208120737.JG7NkugC-lkp@intel.com \
--to=lkp@intel.com \
--cc=Felix.Kuehling@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Xiao@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhenneng@kylinos.cn \
--cc=tao.zhou1@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.