Re: [EXT] Re: [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support

From: Marco Felsch <m.felsch@pengutronix.de>
To: Joy Zou <joy.zou@nxp.com>
Cc: Frank Li <frank.li@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
Date: Wed, 24 Apr 2024 10:59:55 +0200	[thread overview]
Message-ID: <20240424085955.xsseqmzarh3uyfys@pengutronix.de> (raw)
In-Reply-To: <AS4PR04MB9386FB10797C0AE8A19AA88BE1102@AS4PR04MB9386.eurprd04.prod.outlook.com>

On 24-04-24, Joy Zou wrote:
> 
> > -----Original Message-----
> > From: Marco Felsch <m.felsch@pengutronix.de>
> > Sent: 2024年4月17日 12:57
> > To: Joy Zou <joy.zou@nxp.com>
> > Cc: Frank Li <frank.li@nxp.com>; Jacky Bai <ping.bai@nxp.com>;
> > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> > <linux-imx@nxp.com>; devicetree@vger.kernel.org; imx@lists.linux.dev;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> > Subject: [EXT] Re: [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add rtc
> > PCF2131 support
> > 
> > 
> > Hi Joy,
> > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > index 07e85a30a25f..bc3c9271d747 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > @@ -281,6 +281,23 @@ ldo5: LDO5 {
> > >       };
> > >  };
> > >
> > > +&lpi2c3 {
> > > +     #address-cells = <1>;
> > > +     #size-cells = <0>;
> > 
> > while reading your patch I also noticed that you had to specify these cells
> > here. It is very common to specify it within the base dtsi file imx93.dtsi. Can
> > you please provde an extra patch which adds this to the base dtsi followed by
> > this patch, which of course do need to specify it again.
> > 
> > Thanks you,
> >   Marco
> > 
> Thanks for your comments!
> Have checked the base dtsi file imx93.dtsi. The these cells already existed.

You're right, not sure why I didn't saw it in the first place.

> The current cells is same with the lpi2c3 node in imx93.dtsi. So should remove
> these cells in order to keep terse?

Yes please remove it.

Regards,
  Marco