From: Simon Horman <horms@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, Michal Schmidt <mschmidt@redhat.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/7] i40e: Refactor argument of several client notification functions
Date: Sat, 27 Apr 2024 15:56:19 +0100 [thread overview]
Message-ID: <20240427145619.GO516117@kernel.org> (raw)
In-Reply-To: <20240427072615.226151-3-ivecera@redhat.com>
On Sat, Apr 27, 2024 at 09:26:03AM +0200, Ivan Vecera wrote:
> Commit 0ef2d5afb12d ("i40e: KISS the client interface") simplified
> the client interface so in practice it supports only one client
> per i40e netdev. But we have still 2 notification functions that
> uses as parameter a pointer to VSI of netdevice associated with
> the client. After the mentioned commit only possible and used
> VSI is the main (LAN) VSI.
> So refactor these functions so they are called with PF pointer argument
> and the associated VSI (LAN) is taken inside them.
>
> Reviewed-by: Michal Schmidt <mschmidt@redhat.com>
> Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>
Cc: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>,
netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next v4 2/7] i40e: Refactor argument of several client notification functions
Date: Sat, 27 Apr 2024 15:56:19 +0100 [thread overview]
Message-ID: <20240427145619.GO516117@kernel.org> (raw)
In-Reply-To: <20240427072615.226151-3-ivecera@redhat.com>
On Sat, Apr 27, 2024 at 09:26:03AM +0200, Ivan Vecera wrote:
> Commit 0ef2d5afb12d ("i40e: KISS the client interface") simplified
> the client interface so in practice it supports only one client
> per i40e netdev. But we have still 2 notification functions that
> uses as parameter a pointer to VSI of netdevice associated with
> the client. After the mentioned commit only possible and used
> VSI is the main (LAN) VSI.
> So refactor these functions so they are called with PF pointer argument
> and the associated VSI (LAN) is taken inside them.
>
> Reviewed-by: Michal Schmidt <mschmidt@redhat.com>
> Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-04-27 14:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 7:26 [PATCH net-next v4 0/7] i40e: cleanups & refactors Ivan Vecera
2024-04-27 7:26 ` [Intel-wired-lan] " Ivan Vecera
2024-04-27 7:26 ` [PATCH net-next v4 1/7] i40e: Remove flags field from i40e_veb Ivan Vecera
2024-04-27 7:26 ` [Intel-wired-lan] " Ivan Vecera
2024-04-27 14:56 ` Simon Horman
2024-04-27 14:56 ` [Intel-wired-lan] " Simon Horman
2024-04-27 7:26 ` [PATCH net-next v4 2/7] i40e: Refactor argument of several client notification functions Ivan Vecera
2024-04-27 7:26 ` [Intel-wired-lan] " Ivan Vecera
2024-04-27 14:56 ` Simon Horman [this message]
2024-04-27 14:56 ` Simon Horman
2024-04-27 7:26 ` [PATCH net-next v4 3/7] i40e: Refactor argument of i40e_detect_recover_hung() Ivan Vecera
2024-04-27 7:26 ` [Intel-wired-lan] " Ivan Vecera
2024-04-27 14:56 ` Simon Horman
2024-04-27 14:56 ` [Intel-wired-lan] " Simon Horman
2024-04-27 7:26 ` [PATCH net-next v4 4/7] i40e: Add helper to access main VSI Ivan Vecera
2024-04-27 7:26 ` [Intel-wired-lan] " Ivan Vecera
2024-04-27 14:56 ` Simon Horman
2024-04-27 14:56 ` [Intel-wired-lan] " Simon Horman
2024-04-27 7:26 ` [PATCH net-next v4 5/7] i40e: Consolidate checks whether given VSI is main Ivan Vecera
2024-04-27 7:26 ` [Intel-wired-lan] " Ivan Vecera
2024-04-27 14:56 ` Simon Horman
2024-04-27 14:56 ` [Intel-wired-lan] " Simon Horman
2024-04-27 7:26 ` [PATCH net-next v4 6/7] i40e: Add helper to access main VEB Ivan Vecera
2024-04-27 7:26 ` [Intel-wired-lan] " Ivan Vecera
2024-04-27 14:57 ` Simon Horman
2024-04-27 14:57 ` [Intel-wired-lan] " Simon Horman
2024-04-27 7:26 ` [PATCH net-next v4 7/7] i40e: Add and use helper to reconfigure TC for given VSI Ivan Vecera
2024-04-27 7:26 ` [Intel-wired-lan] " Ivan Vecera
2024-04-27 14:57 ` Simon Horman
2024-04-27 14:57 ` [Intel-wired-lan] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240427145619.GO516117@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.