From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
wency@cn.fujitsu.com, andrew.cooper3@citrix.com,
yunhong.jiang@intel.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, eddie.dong@intel.com,
guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca
Subject: Re: [PATCH v2 6/6] libxl/save: Refactor libxl__domain_suspend_state
Date: Tue, 16 Jun 2015 14:26:55 +0100 [thread overview]
Message-ID: <21888.9247.154714.434878@mariner.uk.xensource.com> (raw)
In-Reply-To: <1433318493-24561-7-git-send-email-yanghy@cn.fujitsu.com>
Yang Hongyang writes ("[PATCH v2 6/6] libxl/save: Refactor libxl__domain_suspend_state"):
> Currently struct libxl__domain_suspend_state contains 2 type of states,
> one is save state, another is suspend state. This patch separate it out.
> The motivation of this is that COLO will need to do suspend/resume
> continuesly, we need a more common suspend state.
Currently in libxl/libxc/etc. "suspend" and "save" have referred to
the same thing, but different terminology has been used at different
layers. Ie both "suspend" and "save" each refer to either or both of
"save to disk" or "suspend for live migrate", or to the relevant
underlying mechanisms.
So I'm not sure introducing a distinction between those two terms in
libxl is really helpful. If it is to be done there should be a clear
explanation of what the difference is.
On IRC you said:
14:21 <yanghy> Diziet, currently, in libxl, suspend is used as 2
means, one is save(corrspond to libxc save), another is
suspend the guest(related to suspend callback)
That's rather different, I think. Or, at least, I'm not sure that I
understand this distinction as you are making it. The suspend
callback is part of the implementation of what at higher layers we
save/suspend/restore/migration.
AIUI this callback is related to pausing the guest, or manipulating
its VCPUs ? Perhaps we should rename this callback ? Maybe Andrew
Cooper can suggest a name ?
Forgive me if I'm confused and going off in the wrong direction...
Thanks,
Ian.
next prev parent reply other threads:[~2015-06-16 13:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 8:01 [PATCH v2 0/6] Misc cleanups for libxl Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 1/6] tools/libxl: rename libxl__domain_suspend to libxl__domain_save Yang Hongyang
2015-06-16 12:59 ` Ian Campbell
2015-06-16 13:08 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 2/6] tools/libxl: move domain suspend code into libxl_dom_suspend.c Yang Hongyang
2015-06-16 13:00 ` Ian Campbell
2015-06-16 13:51 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 3/6] tools/libxl: move domain resume " Yang Hongyang
2015-06-16 13:04 ` Ian Campbell
2015-06-16 13:50 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 4/6] tools/libxl: move remus code into libxl_remus.c Yang Hongyang
2015-06-16 13:08 ` Ian Campbell
2015-06-16 13:52 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 5/6] tools/libxl: move save/restore code into libxl_dom_save.c Yang Hongyang
2015-06-16 13:09 ` Ian Campbell
2015-06-16 13:54 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 6/6] libxl/save: Refactor libxl__domain_suspend_state Yang Hongyang
2015-06-16 13:16 ` Ian Campbell
2015-06-16 13:26 ` Ian Jackson [this message]
2015-06-16 14:35 ` Andrew Cooper
2015-06-03 10:51 ` [PATCH v2 0/6] Misc cleanups for libxl Andrew Cooper
2015-06-04 15:14 ` Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21888.9247.154714.434878@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=ian.campbell@citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.