From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, eddie.dong@intel.com, wency@cn.fujitsu.com,
andrew.cooper3@citrix.com, yunhong.jiang@intel.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca
Subject: Re: [PATCH v2 3/6] tools/libxl: move domain resume code into libxl_dom_suspend.c
Date: Tue, 16 Jun 2015 21:50:25 +0800 [thread overview]
Message-ID: <558029A1.1060505@cn.fujitsu.com> (raw)
In-Reply-To: <1434459878.13744.139.camel@citrix.com>
On 06/16/2015 09:04 PM, Ian Campbell wrote:
> On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
>> move domain resume code into libxl_dom_suspend.c.
>
> Even though it has "resume" in the name, I'm not sure that
> libxl__domain_s3_resume is a good candidate for moving to the suspend
> code, it's called only from libxl_send_trigger and IIRC we don't really
> implement s3, just a fake version where the domain is paused/unpaused
> (rather the destroyed and resumed, say.
>
> Having moved libxl__domain_resume and libxl__domain_resume_device_model
> into the same file I think the latter could become static. (If you do
> that in this patch please say something along the lines of "pure code
> motion except for making libxl__domain_resume_device_model static" in
> the commit message)
ok, will fix this in the next version, thank you for the review!
>
>
> .
>
--
Thanks,
Yang.
next prev parent reply other threads:[~2015-06-16 13:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 8:01 [PATCH v2 0/6] Misc cleanups for libxl Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 1/6] tools/libxl: rename libxl__domain_suspend to libxl__domain_save Yang Hongyang
2015-06-16 12:59 ` Ian Campbell
2015-06-16 13:08 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 2/6] tools/libxl: move domain suspend code into libxl_dom_suspend.c Yang Hongyang
2015-06-16 13:00 ` Ian Campbell
2015-06-16 13:51 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 3/6] tools/libxl: move domain resume " Yang Hongyang
2015-06-16 13:04 ` Ian Campbell
2015-06-16 13:50 ` Yang Hongyang [this message]
2015-06-03 8:01 ` [PATCH v2 4/6] tools/libxl: move remus code into libxl_remus.c Yang Hongyang
2015-06-16 13:08 ` Ian Campbell
2015-06-16 13:52 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 5/6] tools/libxl: move save/restore code into libxl_dom_save.c Yang Hongyang
2015-06-16 13:09 ` Ian Campbell
2015-06-16 13:54 ` Yang Hongyang
2015-06-03 8:01 ` [PATCH v2 6/6] libxl/save: Refactor libxl__domain_suspend_state Yang Hongyang
2015-06-16 13:16 ` Ian Campbell
2015-06-16 13:26 ` Ian Jackson
2015-06-16 14:35 ` Andrew Cooper
2015-06-03 10:51 ` [PATCH v2 0/6] Misc cleanups for libxl Andrew Cooper
2015-06-04 15:14 ` Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558029A1.1060505@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.