From: Hans de Goede <hdegoede@redhat.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jerry Snitselaar <jsnitsel@redhat.com>,
Matthew Garrett <mjg59@google.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-integrity <linux-integrity@vger.kernel.org>
Subject: Re: Recent tpm_tis IRQ handling changes are causing kernel backtraces
Date: Thu, 27 May 2021 17:27:49 +0200 [thread overview]
Message-ID: <27d71b81-1e89-1b5d-ddaf-a8928bac90fd@redhat.com> (raw)
In-Reply-To: <20210527140025.vl3ply6wnn7rsygg@kernel.org>
Hi,
On 5/27/21 4:00 PM, Jarkko Sakkinen wrote:
> On Wed, May 26, 2021 at 09:03:26PM +0200, Hans de Goede wrote:
<snip>
>> Call Trace:
>> tpm_tis_send_data+0x2b/0x230
>> ? tpm_tcg_read_bytes+0x30/0x50
>> tpm_tis_send_main+0x1e/0xe0
>> tpm_transmit+0xd6/0x3d0WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:205
>> tpm_tis_status+0x66/0x70
>
> Does the stack trace stop here for the first one?
No, it goes on below the second one which I copy and pasted, it looks like my cursor was
not at the end when I pasted the second one, sorry, let me paste the first one again:
WARNING: CPU: 5 PID: 142 at drivers/char/tpm/tpm_tis_core.c:205 tpm_tis_status+0x66/0x70
Modules linked in: uinput rfcomm snd_seq_dummy snd_hrtimer xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT nf_nat_tftp nf_conntrack_tftp bridge stp llc ccm michael_mic nft_objref nf_conntrack_netbios_ns nf_conntrack_broadcast nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct cmac nft_chain_nat ip6table_nat ip6table_mangle ip6table_raw ip6table_security iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 iptable_mangle iptable_raw iptable_security ip_set nf_tables nfnetlink ip6table_filter ip6_tables iptable_filter snd_soc_skl_hda_dsp snd_soc_hdac_hdmi qrtr_mhi bnep snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common soundwire_intel soundwire_generic_allocation soundwire_cadence sunrpc snd_sof_intel_hda snd_sof_pci iTCO_wdt snd_sof intel_pmc_bxt iTCO_vendor_support snd_sof_xtensa_dsp snd_soc_hdac_hda snd_hda_ext_core
snd_soc_acpi_intel_match snd_soc_acpi snd_soc_core mei_hdcp x86_pkg_temp_thermal qrtr snd_compress intel_pmt_telemetry intel_powerclamp intel_rapl_msr ns snd_pcm_dmaengine intel_pmt_class ac97_bus dell_laptop ath11k_pci coretemp ledtrig_audio ath11k dell_smm_hwmon kvm_intel snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi qmi_helpers kvm snd_hda_codec mac80211 snd_hda_core snd_hwdep snd_seq snd_seq_device irqbypass intel_cstate dell_wmi intel_uncore snd_pcm dell_smbios dcdbas cfg80211 snd_timer pcspkr snd wmi_bmof dell_wmi_sysman dell_wmi_descriptor i2c_i801 soundcore i2c_smbus mhi uvcvideo libarc4 hci_uart videobuf2_vmalloc videobuf2_memops mei_me videobuf2_v4l2 vfat mei videobuf2_common fat btqca joydev hid_sensor_als btrtl idma64 btbcm hid_sensor_trigger videodev hid_sensor_iio_common processor_thermal_device btintel industrialio_triggered_buffer processor_thermal_rfim kfifo_buf processor_thermal_mbox mc industrialio processor_thermal_rapl bluetooth thunderbolt
intel_rapl_common intel_pmt intel_soc_dts_iosf ecdh_generic ucsi_acpi rfkill typec_ucsi typec ecc int3403_thermal intel_hid int340x_thermal_zone sparse_keymap int3400_thermal acpi_pad acpi_tad acpi_thermal_rel zram ip_tables dm_crypt trusted hid_sensor_hub intel_ishtp_loader intel_ishtp_hid hid_multitouch i915 i2c_algo_bit rtsx_pci_sdmmc nvme drm_kms_helper mmc_core nvme_core crct10dif_pclmul crc32_pclmul crc32c_intel cec drm ghash_clmulni_intel rtsx_pci serio_raw intel_ish_ipc intel_ishtp vmd i2c_hid_acpi i2c_hid wmi video pinctrl_tigerlake fuse
CPU: 5 PID: 142 Comm: kworker/5:1 Not tainted 5.12.6-300.fc34.x86_64 #1
Hardware name: Dell Inc. XPS 13 9310/0MRT12, BIOS 2.2.0 04/06/2021
Workqueue: tpm_dev_wq tpm_dev_async_work
RIP: 0010:tpm_tis_status+0x66/0x70
Code: 23 75 05 48 83 c4 10 c3 31 c0 80 3d ca a0 55 01 00 75 f0 48 c7 c7 b4 1c 44 a6 88 44 24 07 c6 05 b6 a0 55 01 01 e8 6b f3 3c 00 <0f> 0b 0f b6 44 24 07 eb d0 90 0f 1f 44 00 00 41 57 41 56 41 55 41
RSP: 0018:ffffafc80037bd40 EFLAGS: 00010286
RAX: 000000000000001b RBX: ffff9c8c47cff000 RCX: 0000000000000027
RDX: ffff9c93af7585c8 RSI: 0000000000000001 RDI: ffff9c93af7585c0
RBP: ffff9c8c47cff000 R08: 0000000000000000 R09: ffffafc80037bb70
R10: ffffafc80037bb68 R11: ffffffffa6b45f28 R12: ffff9c8c47df5aa8
R13: ffff9c8c4d14e0ba R14: 0000000000000000 R15: ffffafc80037bdf2
FS: 0000000000000000(0000) GS:ffff9c93af740000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fadaa0bd490 CR3: 0000000170c42005 CR4: 0000000000770ee0
PKRU: 55555554
Call Trace:
tpm_tis_send_data+0x2b/0x230
? tpm_tcg_read_bytes+0x30/0x50
tpm_tis_send_main+0x1e/0xe0
tpm_transmit+0xd6/0x3d0
tpm_dev_transmit.constprop.0+0x47/0xa0
tpm_dev_async_work+0x62/0x90
process_one_work+0x1ec/0x380
worker_thread+0x53/0x3e0
? process_one_work+0x380/0x380
kthread+0x11b/0x140
? kthread_associate_blkcg+0xa0/0xa0
ret_from_fork+0x1f/0x30
This is from:
https://bugzilla.redhat.com/show_bug.cgi?id=1964974 (private)
https://retrace.fedoraproject.org/faf/reports/74723/ (public)
>> Modules linked in:
>> CPU: 2 PID: 1 Comm: swapper/0 Not tainted 5.12.6-300.fc34.x86_64 #1
>> Hardware name: Dell Inc. XPS 13 9310/0GG9PT, BIOS 2.2.0 04/06/2021
>> RIP: 0010:tpm_tis_status+0x66/0x70
>> Code: 23 75 05 48 83 c4 10 c3 31 c0 80 3d ca a0 55 01 00 75 f0 48 c7 c7 b4 1c
>> 44 a6 88 44 24 07 c6 05 b6 a0 55 01 01 e8 6b f3 3c 00 <0f> 0b 0f b6 44 24 07 eb
>> d0 90 0f 1f 44 00 00 41 57 41 56 41 55 41
>> RSP: 0018:ffffad554006bae0 EFLAGS: 00010282
>> RAX: 000000000000001b RBX: ffff96bf471d5000 RCX: ffffffffa6b15ee8
>> RDX: c0000000ffffdfff RSI: 00000000ffffdfff RDI: ffffffffa752ec6c
>> RBP: ffff96bf471d5000 R08: 0000000000000000 R09: ffffad554006b910
>> R10: ffffad554006b908 R11: ffffffffa6b45f28 R12: ffff96bf472f61a8
>> R13: ffff96bf47d87000 R14: 0000000000000000 R15: ffffad554006bb92
>> FS: 0000000000000000(0000) GS:ffff96c2bf680000(0000) knlGS:0000000000000000
>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> CR2: 00007ff201c82958 CR3: 0000000010a10001 CR4: 0000000000770ee0
>> PKRU: 55555554
>> Call Trace:
>> tpm_tis_send_data+0x2b/0x230
>> tpm_tis_send_main+0x1e/0xe0
>> tpm_transmit+0xd6/0x3d0
>> tpm_transmit_cmd+0x25/0x90
>> tpm2_pcr_extend+0x1f9/0x240
>> tpm_pcr_extend+0xa1/0xb0
>> ima_add_template_entry+0x16e/0x220
>> ? ima_store_template+0x3a/0xb0
>> ? hash_setup+0xc5/0xc5
>> ima_add_boot_aggregate+0xd4/0x13e
>> ima_init+0x51/0x94
>> init_ima+0x23/0xb5
>> ? hash_setup+0xc5/0xc5
>> do_one_initcall+0x44/0x1d0
>> kernel_init_freeable+0x1da/0x221
>> ? rest_init+0xb4/0xb4
>> kernel_init+0xa/0x11c
>> ret_from_fork+0x1f/0x30
>>
>> tpm_dev_transmit.constprop.0+0x47/0xa0
>> tpm_dev_async_work+0x62/0x90
>> process_one_work+0x1ec/0x380
>> worker_thread+0x53/0x3e0
>> ? process_one_work+0x380/0x380
>> kthread+0x11b/0x140
>> ? kthread_associate_blkcg+0xa0/0xa0
>> ret_from_fork+0x1f/0x30
>>
>>
>> Regards,
>>
>> Hans
>
> OK, this is a weird one, and *might* be something unrelated, even though
> it triggers the warning. tpm_pcr_extend() does pin the TPM chip and request
> the locality.
>
> For the 2nd one I'd be interested about the hardware specifics.
Actually I just checked and both backtrace happen on a:
"Dell Inc. XPS 13 9310"
The second backtrace is from:
https://bugzilla.redhat.com/show_bug.cgi?id=1964735 (private)
https://retrace.fedoraproject.org/faf/reports/38209/ (public)
Note there is public bugzilla, with dmesg with the same backtrace
(on the same laptop), but then with 5.12.5 here:
https://bugzilla.redhat.com/show_bug.cgi?id=1963712
There are also 2 interesting comments on the public bugzilla:
"updated to linux kernel 5.12.5 performed
sudo shutdown -r now"
"I installed Fedora 34 UEFI from USB on a Dell XPS 13 Developer Edition"
So it seems this is happening on the "Dell XPS 13 Developer
Edition".
I've also checked the BIOS versions involved in the 2 different
bugs and 1964735 has "BIOS 1.2.5 12/10/2020" where as
1963712 has "BIOS 2.2.0 04/06/2021" so this seems to be
independent of the BIOS version.
###
Interestingly enough the first backtrace is also happening on a:
"Dell Inc. XPS 13 9310/0MRT12, BIOS 2.2.0 04/06/2021"
So it seems that at least with 5.12.6 (which has the last 2 fixes)
all reports are about the XPS 13 9310. I wonder if there is an
issue with the TPM interrupt line on the XPS 13 9310; I've asked the
reporters to try adding tpm_tis.interrupts=0 to their kernel commandline.
Regards,
Hans
next prev parent reply other threads:[~2021-05-27 15:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 13:09 Recent tpm_tis IRQ handling changes are causing kernel backtraces Hans de Goede
2021-03-16 15:34 ` Hans de Goede
2021-03-16 19:18 ` Jarkko Sakkinen
2021-05-08 9:07 ` Hans de Goede
2021-05-10 17:25 ` Jarkko Sakkinen
2021-05-11 8:37 ` Hans de Goede
2021-05-11 23:48 ` Jarkko Sakkinen
2021-05-26 19:03 ` Hans de Goede
2021-05-27 14:00 ` Jarkko Sakkinen
2021-05-27 15:27 ` Hans de Goede [this message]
[not found] ` <20210531043616.u3v25qzkkrik5apq@kernel.org>
2021-05-31 8:24 ` Hans de Goede
2021-06-01 18:02 ` Jarkko Sakkinen
2021-06-01 16:04 ` Hans de Goede
2021-06-01 18:03 ` Jarkko Sakkinen
2021-06-14 13:33 ` Hans de Goede
2021-06-15 13:01 ` Jarkko Sakkinen
2021-06-15 13:59 ` Hans de Goede
2021-06-23 13:37 ` Jarkko Sakkinen
2021-06-21 12:04 ` Hans de Goede
2021-06-23 13:40 ` Jarkko Sakkinen
2021-06-23 13:54 ` Hans de Goede
2021-06-29 18:04 ` Recent tpm_tis IRQ handling changes are causing kernel backtraces] Jarkko Sakkinen
2021-06-29 19:14 ` Hans de Goede
2021-06-29 22:05 ` Jarkko Sakkinen
2021-06-30 12:47 ` Hans de Goede
2021-06-30 13:36 ` Hans de Goede
2021-07-09 18:44 ` Jarkko Sakkinen
2021-07-17 16:10 ` Hans de Goede
2021-07-27 2:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27d71b81-1e89-1b5d-ddaf-a8928bac90fd@redhat.com \
--to=hdegoede@redhat.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jarkko@kernel.org \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.