From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>,
<johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 1/2] wifi: mac80211: add a new field in ieee80211_rx_status for link id
Date: Tue, 2 Aug 2022 08:28:14 -0700 [thread overview]
Message-ID: <29694008-63ef-4cd3-a6c6-f82fc8377be6@quicinc.com> (raw)
In-Reply-To: <20220802065019.20791-2-quic_vthiagar@quicinc.com>
On 8/1/2022 11:50 PM, Vasanthakumar Thiagarajan wrote:
> In MLO, when the address translation from link to MLD is done
> in fw/hw, it is necessary to be able to have some information
> on the link on which the frame has been received. Extend the
> rx API to include link_id in ieee80211_rx_status.
>
> Signed-off-by: Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>
> ---
> include/net/mac80211.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index f198af600b5e..23bc34657b16 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -1480,6 +1480,9 @@ enum mac80211_rx_encoding {
> * each A-MPDU but the same for each subframe within one A-MPDU
> * @ampdu_delimiter_crc: A-MPDU delimiter CRC
> * @zero_length_psdu_type: radiotap type of the 0-length PSDU
> + * @link_id: id of the link used to receive the packet. Applicable only with
> + * MLO connection, valid link ids are in 0-14, link_id 15 means either the
> + * link id is not known or it is a non-MLO connection.
> */
> struct ieee80211_rx_status {
> u64 mactime;
> @@ -1504,6 +1507,7 @@ struct ieee80211_rx_status {
> s8 chain_signal[IEEE80211_MAX_CHAINS];
> u8 ampdu_delimiter_crc;
> u8 zero_length_psdu_type;
> + u8 link_id;
> };
>
> static inline u32
in other parts of the MLO code the link_id is defined as int and a value
of -1 is used for a non-MLO link. but I don't know if that is currently
universally true.
if that is curently universally true, do we want to now have divergent
definitions of a link_id?
next prev parent reply other threads:[~2022-08-02 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 6:50 [RFC 0/2] wifi: mac80211: extend rx API with link_id for MLO connection Vasanthakumar Thiagarajan
2022-08-02 6:50 ` [RFC 1/2] wifi: mac80211: add a new field in ieee80211_rx_status for link id Vasanthakumar Thiagarajan
2022-08-02 15:28 ` Jeff Johnson [this message]
2022-08-03 16:46 ` Vasanthakumar Thiagarajan
2022-08-09 18:12 ` Johannes Berg
2022-08-11 9:31 ` Vasanthakumar Thiagarajan
2022-08-02 6:50 ` [RFC 2/2] wifi: mac80211: use link_id from ieee80211_rx_status to retrieve rx link Vasanthakumar Thiagarajan
2022-08-09 18:15 ` Johannes Berg
2022-08-11 10:28 ` Vasanthakumar Thiagarajan
2023-01-19 20:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29694008-63ef-4cd3-a6c6-f82fc8377be6@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_vthiagar@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.