From: Johannes Berg <johannes@sipsolutions.net>
To: Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/2] wifi: mac80211: add a new field in ieee80211_rx_status for link id
Date: Tue, 09 Aug 2022 20:12:38 +0200 [thread overview]
Message-ID: <9e37eb24f63dbac0b13ae8b36393c8f393599d1e.camel@sipsolutions.net> (raw)
In-Reply-To: <733b6f1a-8b07-4b23-2b10-af1ce68b6227@quicinc.com>
On Wed, 2022-08-03 at 22:16 +0530, Vasanthakumar Thiagarajan wrote:
>
> > > + u8 link_id;
> > > };
> > > static inline u32
> >
> > in other parts of the MLO code the link_id is defined as int and a value
> > of -1 is used for a non-MLO link. but I don't know if that is currently
> > universally true.
> >
> > if that is curently universally true, do we want to now have divergent
> > definitions of a link_id?
>
> Good point, i see link_id is used both as unsigned and int based on
> their usage. The reason I preferred unsigned is that we can make use of
> the remaining 4-bits for some other purpose in future,
> ieee80211_rx_status has size limitation.
>
It's a bit tricky though - do we want to have 0 for all the drivers that
don't support MLO? Might not really be an issue, but OTOH not
initializing it should probably not result in a valid value otherwise
you might test something, think it's fine, and it really isn't.
I think we should spend a bit to have a validity indication in this
case. Even -1 wouldn't address it since you'd have to initialize to
that.
It works better the other way around in APIs etc. where we have a few
producers and many consumers (cfg80211 down to drivers), but less well
this way where we'd have to change drivers...
johannes
next prev parent reply other threads:[~2022-08-09 18:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 6:50 [RFC 0/2] wifi: mac80211: extend rx API with link_id for MLO connection Vasanthakumar Thiagarajan
2022-08-02 6:50 ` [RFC 1/2] wifi: mac80211: add a new field in ieee80211_rx_status for link id Vasanthakumar Thiagarajan
2022-08-02 15:28 ` Jeff Johnson
2022-08-03 16:46 ` Vasanthakumar Thiagarajan
2022-08-09 18:12 ` Johannes Berg [this message]
2022-08-11 9:31 ` Vasanthakumar Thiagarajan
2022-08-02 6:50 ` [RFC 2/2] wifi: mac80211: use link_id from ieee80211_rx_status to retrieve rx link Vasanthakumar Thiagarajan
2022-08-09 18:15 ` Johannes Berg
2022-08-11 10:28 ` Vasanthakumar Thiagarajan
2023-01-19 20:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e37eb24f63dbac0b13ae8b36393c8f393599d1e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_vthiagar@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.