From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adrien Thierry <athierry@redhat.com>, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Stefan Wahren <stefan.wahren@i2se.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gaston Gonzalez <gascoar@gmail.com>,
Ojaswin Mujoo <ojaswin98@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711
Date: Fri, 25 Mar 2022 08:16:40 +0100 [thread overview]
Message-ID: <2c6b873f-a971-e79a-6a32-f101bda46e93@kernel.org> (raw)
In-Reply-To: <fdf37f73-6b7a-a96d-6a42-35d870c96f35@kernel.org>
On 24/03/2022 19:47, Krzysztof Kozlowski wrote:
> On 24/03/2022 18:26, Adrien Thierry wrote:
>> Add a new compatible string for BCM2711. This is the chip used on the
>> Raspberry Pi 4.
>>
>> Signed-off-by: Adrien Thierry <athierry@redhat.com>
>> ---
>> Changes since v1:
>> - Removed duplicate compatible string for bcm2711
>>
>> .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> index e04439b3355b..9cb957facae0 100644
>> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> @@ -27,6 +27,11 @@ properties:
>> - brcm,bcm2836-vchiq
>> - const: brcm,bcm2835-vchiq
>>
>> + - description: BCM2711 based boards
>> + items:
>> + - enum:
>> + - brcm,bcm2711-vchiq
>
> This oneOf here - just to add description which is copy-paste of
> compatible - does not make sense. It should be just enum with
> compatibles. At least for 2711 and 2835 (and put them in alphabetical
> order).
Actually, judging by your driver and DTS, it seems that this should be
list of items bcm2711 followed by bcm2836.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adrien Thierry <athierry@redhat.com>, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Stefan Wahren <stefan.wahren@i2se.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gaston Gonzalez <gascoar@gmail.com>,
Ojaswin Mujoo <ojaswin98@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711
Date: Fri, 25 Mar 2022 08:16:40 +0100 [thread overview]
Message-ID: <2c6b873f-a971-e79a-6a32-f101bda46e93@kernel.org> (raw)
In-Reply-To: <fdf37f73-6b7a-a96d-6a42-35d870c96f35@kernel.org>
On 24/03/2022 19:47, Krzysztof Kozlowski wrote:
> On 24/03/2022 18:26, Adrien Thierry wrote:
>> Add a new compatible string for BCM2711. This is the chip used on the
>> Raspberry Pi 4.
>>
>> Signed-off-by: Adrien Thierry <athierry@redhat.com>
>> ---
>> Changes since v1:
>> - Removed duplicate compatible string for bcm2711
>>
>> .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> index e04439b3355b..9cb957facae0 100644
>> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> @@ -27,6 +27,11 @@ properties:
>> - brcm,bcm2836-vchiq
>> - const: brcm,bcm2835-vchiq
>>
>> + - description: BCM2711 based boards
>> + items:
>> + - enum:
>> + - brcm,bcm2711-vchiq
>
> This oneOf here - just to add description which is copy-paste of
> compatible - does not make sense. It should be just enum with
> compatibles. At least for 2711 and 2835 (and put them in alphabetical
> order).
Actually, judging by your driver and DTS, it seems that this should be
list of items bcm2711 followed by bcm2836.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-25 7:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 17:26 [PATCH v2 0/2] Add support for bcm2711 in vchiq_arm Adrien Thierry
2022-03-24 17:26 ` Adrien Thierry
2022-03-24 17:26 ` [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 Adrien Thierry
2022-03-24 17:26 ` Adrien Thierry
2022-03-24 18:47 ` Krzysztof Kozlowski
2022-03-24 18:47 ` Krzysztof Kozlowski
2022-03-25 7:16 ` Krzysztof Kozlowski [this message]
2022-03-25 7:16 ` Krzysztof Kozlowski
2022-03-24 17:26 ` [PATCH v2 2/2] staging: vchiq_arm: Use bcm2711 compatible string for bcm2711-based RPi Adrien Thierry
2022-03-24 17:26 ` Adrien Thierry
2022-03-24 18:49 ` Krzysztof Kozlowski
2022-03-24 18:49 ` Krzysztof Kozlowski
2022-03-26 9:04 ` [PATCH v2 0/2] Add support for bcm2711 in vchiq_arm Stefan Wahren
2022-03-26 9:04 ` Stefan Wahren
2022-04-07 14:03 ` Adrien Thierry
2022-04-07 14:03 ` Adrien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c6b873f-a971-e79a-6a32-f101bda46e93@kernel.org \
--to=krzk@kernel.org \
--cc=athierry@redhat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gascoar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.