From: Tilman Schmidt <tilman@imap.cc>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Hansjoerg Lipp <hjlipp@web.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] isdn/gigaset: drop unused ldisc methods
Date: Tue, 14 Jul 2015 00:37:13 +0200 (CEST) [thread overview]
Message-ID: <40ceea060d328b84da061f115e7ed9b99d28cf74.1436826434.git.tilman@imap.cc> (raw)
In-Reply-To: <cover.1436826434.git.tilman@imap.cc>
The line discipline read and write methods are optional so the dummy
methods in ser_gigaset are unnecessary and can be removed.
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
---
drivers/isdn/gigaset/ser-gigaset.c | 24 ------------------------
1 files changed, 0 insertions(+), 24 deletions(-)
diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c
index 3ac9c41..375be50 100644
--- a/drivers/isdn/gigaset/ser-gigaset.c
+++ b/drivers/isdn/gigaset/ser-gigaset.c
@@ -607,28 +607,6 @@ static int gigaset_tty_hangup(struct tty_struct *tty)
}
/*
- * Read on the tty.
- * Unused, received data goes only to the Gigaset driver.
- */
-static ssize_t
-gigaset_tty_read(struct tty_struct *tty, struct file *file,
- unsigned char __user *buf, size_t count)
-{
- return -EAGAIN;
-}
-
-/*
- * Write on the tty.
- * Unused, transmit data comes only from the Gigaset driver.
- */
-static ssize_t
-gigaset_tty_write(struct tty_struct *tty, struct file *file,
- const unsigned char *buf, size_t count)
-{
- return -EAGAIN;
-}
-
-/*
* Ioctl on the tty.
* Called in process context only.
* May be re-entered by multiple ioctl calling threads.
@@ -761,8 +739,6 @@ static struct tty_ldisc_ops gigaset_ldisc = {
.open = gigaset_tty_open,
.close = gigaset_tty_close,
.hangup = gigaset_tty_hangup,
- .read = gigaset_tty_read,
- .write = gigaset_tty_write,
.ioctl = gigaset_tty_ioctl,
.receive_buf = gigaset_tty_receive,
.write_wakeup = gigaset_tty_wakeup,
--
1.7.1
next prev parent reply other threads:[~2015-07-13 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 22:37 [PATCH 0/2] Fix long-standing regression in ser_gigaset ISDN driver Tilman Schmidt
2015-07-13 22:37 ` [PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset Tilman Schmidt
2015-07-13 23:14 ` Peter Hurley
2015-07-13 23:58 ` Tilman Schmidt
2015-07-14 19:01 ` Paul Bolle
2015-07-14 12:50 ` Sergei Shtylyov
2015-07-13 22:37 ` Tilman Schmidt [this message]
2015-07-14 19:03 ` [PATCH 2/2] isdn/gigaset: drop unused ldisc methods Paul Bolle
2015-07-16 0:25 ` [PATCH 0/2] Fix long-standing regression in ser_gigaset ISDN driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40ceea060d328b84da061f115e7ed9b99d28cf74.1436826434.git.tilman@imap.cc \
--to=tilman@imap.cc \
--cc=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.