From: Tilman Schmidt <tilman@imap.cc>
To: Peter Hurley <peter@hurleysoftware.com>, Paul Bolle <pebolle@tiscali.nl>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Hansjoerg Lipp <hjlipp@web.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset
Date: Tue, 14 Jul 2015 01:58:24 +0200 [thread overview]
Message-ID: <55A450A0.4080806@imap.cc> (raw)
In-Reply-To: <55A44662.4080706@hurleysoftware.com>
Am 14.07.2015 um 01:14 schrieb Peter Hurley:
> On 07/13/2015 06:37 PM, Tilman Schmidt wrote:
>> Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"),
>> first merged in kernel release 3.10, caused the following regression
>> in the Gigaset M101 driver:
>>
>> Before that commit, when closing the N_TTY line discipline in
>> preparation to switching to N_GIGASET_M101, receive_room would be
>> reset to a non-zero value by the call to n_tty_flush_buffer() in
>> n_tty's close method. With the removal of that call, receive_room
>> might be left at zero, blocking data reception on the serial line.
>
> That commit didn't cause the problem; it was a bug all along.
Sure. That's why it is correctly fixed in the Gigaset driver.
But before that commit the bug was never actually triggered.
So that commit defines the point in the commit history from
which the fix is needed, and therefore needs to be mentioned
in order to decide which stable releases will need the fix.
> Non-flow controlling line disciplines _must_ set tty->receive_room
> on line discipline open because they are declaring that every
> input they can accept that much data.
I have submitted a corresponding fix to the line discipline
documentation separately.
Thanks,
Tilman
next prev parent reply other threads:[~2015-07-14 0:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 22:37 [PATCH 0/2] Fix long-standing regression in ser_gigaset ISDN driver Tilman Schmidt
2015-07-13 22:37 ` [PATCH 2/2] isdn/gigaset: drop unused ldisc methods Tilman Schmidt
2015-07-14 19:03 ` Paul Bolle
2015-07-13 22:37 ` [PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset Tilman Schmidt
2015-07-13 23:14 ` Peter Hurley
2015-07-13 23:58 ` Tilman Schmidt [this message]
2015-07-14 19:01 ` Paul Bolle
2015-07-14 12:50 ` Sergei Shtylyov
2015-07-16 0:25 ` [PATCH 0/2] Fix long-standing regression in ser_gigaset ISDN driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A450A0.4080806@imap.cc \
--to=tilman@imap.cc \
--cc=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.