From: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue
Date: Wed, 9 Dec 2015 08:35:12 +0000 [thread overview]
Message-ID: <4837007523CC9A4B9414D20C13DE6E641363D33A@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023FEDE3@IRSMSX103.ger.corp.intel.com>
> -----Original Message-----
> From: Mcnamara, John
> Sent: Tuesday, December 8, 2015 6:00 PM
> To: Mcnamara, John <john.mcnamara@intel.com>; Azarewicz, PiotrX T
> <piotrx.t.azarewicz@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy
> issue
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> > Sent: Tuesday, December 8, 2015 2:47 PM
> > To: Azarewicz, PiotrX T; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy
> > issue
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz
> > > Sent: Tuesday, December 8, 2015 2:17 PM
> > > To: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy
> > > issue
> > >
> > > The cmds and thread_cmds both are the arrays of cmdline_parse_ctx_t.
> > > So the goal is to copy elements size of cmdline_parse_ctx_t not
> > > cmdline_parse_ctx_t*.
> > >
> > > Coverity issue: 120412
> > > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread
> > > binding
> > > dynamically")
> > >
> > > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> >
> > Acked-by: John McNamara <john.mcnamara@intel.com>
>
> Hi Piotr,
>
> This issue occurs copy and pasted in two other locations as well:
>
> examples/ip_pipeline/pipeline/pipeline_common_fe.c
> 1295: n_cmds * sizeof(cmdline_parse_ctx_t *));
>
> examples/ip_pipeline/thread_fe.c
> 340: n_cmds * sizeof(cmdline_parse_ctx_t *));
>
> examples/ip_pipeline/init.c
> 1475: n_cmds * sizeof(cmdline_parse_ctx_t *));
>
> Perhaps you could fix those in the same patch.
>
> Thanks,
>
> John
>
>
Yes, you are right, thanks. I will send v2.
Piotr
next prev parent reply other threads:[~2015-12-09 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 14:16 [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue Piotr Azarewicz
2015-12-08 14:47 ` Mcnamara, John
2015-12-08 16:59 ` Mcnamara, John
2015-12-09 8:35 ` Azarewicz, PiotrX T [this message]
2015-12-09 9:33 ` [PATCH v2 " Piotr Azarewicz
2015-12-09 10:51 ` Mcnamara, John
2015-12-09 20:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4837007523CC9A4B9414D20C13DE6E641363D33A@IRSMSX102.ger.corp.intel.com \
--to=piotrx.t.azarewicz@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.