From: Junxiao Bi <junxiao.bi@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: ocfs2-devel@oss.oracle.com, cluster-devel@redhat.com,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback
Date: Mon, 10 May 2021 15:15:27 -0700 [thread overview]
Message-ID: <4d120e2e-5eb4-1bbb-cc63-8c3b7c62dac0@oracle.com> (raw)
In-Reply-To: <20210509162306.9de66b1656f04994f3cb5730@linux-foundation.org>
On 5/9/21 4:23 PM, Andrew Morton wrote:
> On Mon, 26 Apr 2021 15:05:50 -0700 Junxiao Bi <junxiao.bi@oracle.com> wrote:
>
>> When doing truncate/fallocate for some filesytem like ocfs2, it
>> will zero some pages that are out of inode size and then later
>> update the inode size, so it needs this api to writeback eof
>> pages.
> Seems reasonable. But can we please update the
> __block_write_full_page_eof() comment? It now uses the wrong function
> name and doesn't document the new `eof' argument.
Jan suggested using sb_issue_zeroout to zero eof pages in
ocfs2_fallocate, that can
also fix the issue for ocfs2. For gfs2, i though it had the same issue,
but i didn't get
a confirm from gfs2 maintainer, if gfs2 is ok, then maybe this new api
is not necessary?
Thanks,
Junxiao.
>
WARNING: multiple messages have this Message-ID (diff)
From: Junxiao Bi <junxiao.bi@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>,
ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback
Date: Mon, 10 May 2021 15:15:27 -0700 [thread overview]
Message-ID: <4d120e2e-5eb4-1bbb-cc63-8c3b7c62dac0@oracle.com> (raw)
In-Reply-To: <20210509162306.9de66b1656f04994f3cb5730@linux-foundation.org>
On 5/9/21 4:23 PM, Andrew Morton wrote:
> On Mon, 26 Apr 2021 15:05:50 -0700 Junxiao Bi <junxiao.bi@oracle.com> wrote:
>
>> When doing truncate/fallocate for some filesytem like ocfs2, it
>> will zero some pages that are out of inode size and then later
>> update the inode size, so it needs this api to writeback eof
>> pages.
> Seems reasonable. But can we please update the
> __block_write_full_page_eof() comment? It now uses the wrong function
> name and doesn't document the new `eof' argument.
Jan suggested using sb_issue_zeroout to zero eof pages in
ocfs2_fallocate, that can
also fix the issue for ocfs2. For gfs2, i though it had the same issue,
but i didn't get
a confirm from gfs2 maintainer, if gfs2 is ok, then maybe this new api
is not necessary?
Thanks,
Junxiao.
>
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
WARNING: multiple messages have this Message-ID (diff)
From: Junxiao Bi <junxiao.bi@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback
Date: Mon, 10 May 2021 15:15:27 -0700 [thread overview]
Message-ID: <4d120e2e-5eb4-1bbb-cc63-8c3b7c62dac0@oracle.com> (raw)
In-Reply-To: <20210509162306.9de66b1656f04994f3cb5730@linux-foundation.org>
On 5/9/21 4:23 PM, Andrew Morton wrote:
> On Mon, 26 Apr 2021 15:05:50 -0700 Junxiao Bi <junxiao.bi@oracle.com> wrote:
>
>> When doing truncate/fallocate for some filesytem like ocfs2, it
>> will zero some pages that are out of inode size and then later
>> update the inode size, so it needs this api to writeback eof
>> pages.
> Seems reasonable. But can we please update the
> __block_write_full_page_eof() comment? It now uses the wrong function
> name and doesn't document the new `eof' argument.
Jan suggested using sb_issue_zeroout to zero eof pages in
ocfs2_fallocate, that can
also fix the issue for ocfs2. For gfs2, i though it had the same issue,
but i didn't get
a confirm from gfs2 maintainer, if gfs2 is ok, then maybe this new api
is not necessary?
Thanks,
Junxiao.
>
next prev parent reply other threads:[~2021-05-10 22:16 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 22:05 [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback Junxiao Bi
2021-04-26 22:05 ` [Cluster-devel] " Junxiao Bi
2021-04-26 22:05 ` [Ocfs2-devel] " Junxiao Bi
2021-04-26 22:05 ` [PATCH 2/3] ocfs2: allow writing back pages out of inode size Junxiao Bi
2021-04-26 22:05 ` [Cluster-devel] " Junxiao Bi
2021-04-26 22:05 ` [Ocfs2-devel] " Junxiao Bi
2021-04-28 16:00 ` Junxiao Bi
2021-04-28 16:00 ` [Cluster-devel] " Junxiao Bi
2021-04-28 16:00 ` [Ocfs2-devel] " Junxiao Bi
2021-04-29 13:09 ` Joseph Qi
2021-04-29 13:09 ` [Cluster-devel] " Joseph Qi
2021-04-29 13:09 ` Joseph Qi
2021-04-26 22:05 ` [PATCH 3/3] gfs2: fix out of inode size writeback Junxiao Bi
2021-04-26 22:05 ` [Cluster-devel] " Junxiao Bi
2021-04-26 22:05 ` [Ocfs2-devel] " Junxiao Bi
2021-04-28 16:02 ` Junxiao Bi
2021-04-28 16:02 ` [Cluster-devel] " Junxiao Bi
2021-04-28 16:02 ` Junxiao Bi
2021-04-29 11:58 ` [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback Joseph Qi
2021-04-29 11:58 ` [Cluster-devel] " Joseph Qi
2021-04-29 11:58 ` Joseph Qi
2021-04-29 17:14 ` [Cluster-devel] " Andreas Gruenbacher
2021-04-29 17:14 ` Andreas Gruenbacher
2021-04-29 17:14 ` [Ocfs2-devel] " Andreas Gruenbacher
2021-04-29 18:07 ` Junxiao Bi
2021-04-29 18:07 ` Junxiao Bi
2021-04-29 18:07 ` Junxiao Bi
2021-04-30 12:47 ` Jan Kara
2021-04-30 12:47 ` Jan Kara
2021-04-30 12:47 ` [Ocfs2-devel] " Jan Kara
2021-04-30 21:18 ` Junxiao Bi
2021-04-30 21:18 ` Junxiao Bi
2021-04-30 21:18 ` Junxiao Bi
2021-05-03 10:29 ` Jan Kara
2021-05-03 10:29 ` Jan Kara
2021-05-03 10:29 ` [Ocfs2-devel] " Jan Kara
2021-05-03 17:25 ` Junxiao Bi
2021-05-03 17:25 ` Junxiao Bi
2021-05-03 17:25 ` [Ocfs2-devel] " Junxiao Bi
2021-05-04 9:02 ` Jan Kara
2021-05-04 9:02 ` Jan Kara
2021-05-04 9:02 ` Jan Kara
2021-05-04 23:35 ` [Ocfs2-devel] " Junxiao Bi
2021-05-04 23:35 ` Junxiao Bi
2021-05-04 23:35 ` Junxiao Bi
2021-05-05 11:43 ` [Ocfs2-devel] " Jan Kara
2021-05-05 11:43 ` Jan Kara
2021-05-05 11:43 ` Jan Kara
2021-05-05 15:54 ` [Ocfs2-devel] " Junxiao Bi
2021-05-05 15:54 ` Junxiao Bi
2021-05-05 15:54 ` Junxiao Bi
2021-05-09 23:23 ` [Ocfs2-devel] " Andrew Morton
2021-05-09 23:23 ` [Cluster-devel] " Andrew Morton
2021-05-09 23:23 ` Andrew Morton
2021-05-10 22:15 ` Junxiao Bi [this message]
2021-05-10 22:15 ` [Cluster-devel] " Junxiao Bi
2021-05-10 22:15 ` Junxiao Bi
2021-05-11 12:19 ` Bob Peterson
2021-05-11 12:19 ` [Cluster-devel] " Bob Peterson
2021-05-11 12:19 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d120e2e-5eb4-1bbb-cc63-8c3b7c62dac0@oracle.com \
--to=junxiao.bi@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.