From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Martin Povišer" <povik+lin@cutebit.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
asahi@lists.linux.dev, Alyssa Rosenzweig <alyssa@rosenzweig.io>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: sound: Add Apple MCA I2S transceiver
Date: Fri, 19 Aug 2022 16:09:05 +0300 [thread overview]
Message-ID: <4ff71939-d366-4949-755b-f251168c9aa7@linaro.org> (raw)
In-Reply-To: <8472463e-d99a-d0f6-9551-45a79a15f567@linaro.org>
On 19/08/2022 16:08, Krzysztof Kozlowski wrote:
> On 19/08/2022 15:58, Martin Povišer wrote:
>>
>>> On 19. 8. 2022, at 14:54, Martin Povišer <povik+lin@cutebit.org> wrote:
>>>
>>> Add binding schema for MCA I2S transceiver found on Apple M1 and other
>>> chips.
>>>
>>> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
>>> ---
>>> .../devicetree/bindings/sound/apple,mca.yaml | 131 ++++++++++++++++++
>>> 1 file changed, 131 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/sound/apple,mca.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/apple,mca.yaml b/Documentation/devicetree/bindings/sound/apple,mca.yaml
>>> new file mode 100644
>>> index 000000000000..7b4f348c2be3
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/sound/apple,mca.yaml
>>> @@ -0,0 +1,131 @@
>>
>>
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - enum:
>>> + - apple,t8103-mca
>>> + - apple,t6000-mca
>>
>> Since it was brought up last time but I didn’t respond: the
>> nonalphabetical order is as the chips were introduced (and
>> matches other schemas).
>
> Sure, just keep that order for future compatibles as well - so always
> put them according to verifiable time of market introduction...
>
> This is very poor reason, instead of alphabetical order. Even worse
> reason is repeating wrong pattern just because someone else did it.
Ah, and the alphabetical order has clear advantage - reduces conflicts.
"Time" has clear disadvantage - increases conflicts.
So switch to alphabetical order.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Martin Povišer" <povik+lin@cutebit.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
asahi@lists.linux.dev, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: sound: Add Apple MCA I2S transceiver
Date: Fri, 19 Aug 2022 16:09:05 +0300 [thread overview]
Message-ID: <4ff71939-d366-4949-755b-f251168c9aa7@linaro.org> (raw)
In-Reply-To: <8472463e-d99a-d0f6-9551-45a79a15f567@linaro.org>
On 19/08/2022 16:08, Krzysztof Kozlowski wrote:
> On 19/08/2022 15:58, Martin Povišer wrote:
>>
>>> On 19. 8. 2022, at 14:54, Martin Povišer <povik+lin@cutebit.org> wrote:
>>>
>>> Add binding schema for MCA I2S transceiver found on Apple M1 and other
>>> chips.
>>>
>>> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
>>> ---
>>> .../devicetree/bindings/sound/apple,mca.yaml | 131 ++++++++++++++++++
>>> 1 file changed, 131 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/sound/apple,mca.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/apple,mca.yaml b/Documentation/devicetree/bindings/sound/apple,mca.yaml
>>> new file mode 100644
>>> index 000000000000..7b4f348c2be3
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/sound/apple,mca.yaml
>>> @@ -0,0 +1,131 @@
>>
>>
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - enum:
>>> + - apple,t8103-mca
>>> + - apple,t6000-mca
>>
>> Since it was brought up last time but I didn’t respond: the
>> nonalphabetical order is as the chips were introduced (and
>> matches other schemas).
>
> Sure, just keep that order for future compatibles as well - so always
> put them according to verifiable time of market introduction...
>
> This is very poor reason, instead of alphabetical order. Even worse
> reason is repeating wrong pattern just because someone else did it.
Ah, and the alphabetical order has clear advantage - reduces conflicts.
"Time" has clear disadvantage - increases conflicts.
So switch to alphabetical order.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-19 13:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 12:54 [PATCH v2 0/4] ASoC platform driver for Apple MCA Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-19 12:54 ` [PATCH v2 1/4] dt-bindings: sound: Add Apple MCA I2S transceiver Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-19 12:58 ` Martin Povišer
2022-08-19 12:58 ` Martin Povišer
2022-08-19 13:08 ` Krzysztof Kozlowski
2022-08-19 13:08 ` Krzysztof Kozlowski
2022-08-19 13:09 ` Krzysztof Kozlowski [this message]
2022-08-19 13:09 ` Krzysztof Kozlowski
2022-08-19 14:14 ` Martin Povišer
2022-08-19 14:14 ` Martin Povišer
2022-08-19 14:17 ` Krzysztof Kozlowski
2022-08-19 14:17 ` Krzysztof Kozlowski
2022-08-22 18:59 ` Rob Herring
2022-08-22 18:59 ` Rob Herring
2022-08-19 12:54 ` [PATCH v2 2/4] arm64: dts: apple: t8103: Add MCA and its support Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-19 13:12 ` Krzysztof Kozlowski
2022-08-19 13:12 ` Krzysztof Kozlowski
2022-08-19 14:24 ` Martin Povišer
2022-08-19 14:24 ` Martin Povišer
2022-08-23 11:02 ` Krzysztof Kozlowski
2022-08-23 11:02 ` Krzysztof Kozlowski
2022-08-19 12:54 ` [PATCH v2 3/4] ASoC: apple: mca: Start new platform driver Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-22 17:39 ` Mark Brown
2022-08-22 17:39 ` Mark Brown
2022-08-23 7:33 ` Martin Povišer
2022-08-23 7:33 ` Martin Povišer
2022-08-23 11:31 ` Mark Brown
2022-08-23 11:31 ` Mark Brown
2022-08-23 11:51 ` Martin Povišer
2022-08-23 11:51 ` Martin Povišer
2022-08-23 11:53 ` Martin Povišer
2022-08-23 11:53 ` Martin Povišer
2022-08-19 12:54 ` [PATCH v2 4/4] ASoC: apple: mca: Add locks on foreign cluster access Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-22 17:45 ` Mark Brown
2022-08-22 17:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff71939-d366-4949-755b-f251168c9aa7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=p.zabel@pengutronix.de \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.