From: Daniel Mack <zonque@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: snd-usb: "delay: estimated 0, actual 352"
Date: Thu, 06 Sep 2012 16:40:18 +0200 [thread overview]
Message-ID: <5048B5D2.5030105@gmail.com> (raw)
In-Reply-To: <s5hharbxlxf.wl%tiwai@suse.de>
On 06.09.2012 16:31, Takashi Iwai wrote:
> At Thu, 6 Sep 2012 15:17:58 +0200,
> Markus Trippelsdorf wrote:
>>
>> On 2012.09.06 at 15:08 +0200, Takashi Iwai wrote:
>>> At Thu, 6 Sep 2012 11:43:48 +0200,
>>> Markus Trippelsdorf wrote:
>>>>
>>>> On 2012.09.06 at 10:21 +0200, Takashi Iwai wrote:
>>>>> At Thu, 06 Sep 2012 09:35:26 +0200,
>>>>> Takashi Iwai wrote:
>>>>>
>>>>> In short, a patch like below may fix the issue (note: completely
>>>>> untested!)
>>>>
>>>> No it doesn't, unfortunately...
>>>
>>> OK, I start tracking down the problem a bit more deeply now.
>>>
>>> The issue happens when the first two URBs are passed to
>>> retire_playback_urb(). These are URBs filled before start_endpoints()
>>> are set, so they contain actually zero size. Even though these are
>>> a sort of dummy packets, the driver still tries to check with the
>>> queued delay account, and gives bogus errors.
>>>
>>> So, essentially the messages are harmless and nothing to worry too
>>> much, but surely it doesn't look sexy.
>>>
>>> The patch below should fix the problem. Please give it a try.
>>
>> Yes, your patch finally fixes the problem.
>> Thank you Takashi-san.
>
> Thanks for your quick test!
>
> If Daniel has no objection with that patch, I'm going to merge it.
No objections from my side. I also gave it a quick test, and even though
I never saw the problem Markus was seeing, I agree to your findings.
Many thanks, everyone :)
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Mack <zonque@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Markus Trippelsdorf <markus@trippelsdorf.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: snd-usb: "delay: estimated 0, actual 352"
Date: Thu, 06 Sep 2012 16:40:18 +0200 [thread overview]
Message-ID: <5048B5D2.5030105@gmail.com> (raw)
In-Reply-To: <s5hharbxlxf.wl%tiwai@suse.de>
On 06.09.2012 16:31, Takashi Iwai wrote:
> At Thu, 6 Sep 2012 15:17:58 +0200,
> Markus Trippelsdorf wrote:
>>
>> On 2012.09.06 at 15:08 +0200, Takashi Iwai wrote:
>>> At Thu, 6 Sep 2012 11:43:48 +0200,
>>> Markus Trippelsdorf wrote:
>>>>
>>>> On 2012.09.06 at 10:21 +0200, Takashi Iwai wrote:
>>>>> At Thu, 06 Sep 2012 09:35:26 +0200,
>>>>> Takashi Iwai wrote:
>>>>>
>>>>> In short, a patch like below may fix the issue (note: completely
>>>>> untested!)
>>>>
>>>> No it doesn't, unfortunately...
>>>
>>> OK, I start tracking down the problem a bit more deeply now.
>>>
>>> The issue happens when the first two URBs are passed to
>>> retire_playback_urb(). These are URBs filled before start_endpoints()
>>> are set, so they contain actually zero size. Even though these are
>>> a sort of dummy packets, the driver still tries to check with the
>>> queued delay account, and gives bogus errors.
>>>
>>> So, essentially the messages are harmless and nothing to worry too
>>> much, but surely it doesn't look sexy.
>>>
>>> The patch below should fix the problem. Please give it a try.
>>
>> Yes, your patch finally fixes the problem.
>> Thank you Takashi-san.
>
> Thanks for your quick test!
>
> If Daniel has no objection with that patch, I'm going to merge it.
No objections from my side. I also gave it a quick test, and even though
I never saw the problem Markus was seeing, I agree to your findings.
Many thanks, everyone :)
Daniel
next prev parent reply other threads:[~2012-09-06 14:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 14:40 [GIT PULL] sound fixes for 3.6-rc5 Takashi Iwai
2012-09-06 6:02 ` Markus Trippelsdorf
2012-09-06 6:33 ` Re: Daniel Mack
2012-09-06 6:33 ` (no subject) Daniel Mack
2012-09-06 6:45 ` Markus Trippelsdorf
2012-09-06 6:48 ` Re: Takashi Iwai
2012-09-06 6:48 ` (no subject) Takashi Iwai
2012-09-06 6:53 ` Markus Trippelsdorf
2012-09-06 7:08 ` snd-usb: "delay: estimated 0, actual 352" Daniel Mack
2012-09-06 7:08 ` Daniel Mack
2012-09-06 7:17 ` Markus Trippelsdorf
2012-09-06 7:35 ` Takashi Iwai
2012-09-06 7:35 ` Takashi Iwai
2012-09-06 8:21 ` Takashi Iwai
2012-09-06 8:21 ` Takashi Iwai
2012-09-06 9:43 ` Markus Trippelsdorf
2012-09-06 13:08 ` Takashi Iwai
2012-09-06 13:08 ` Takashi Iwai
2012-09-06 13:17 ` Markus Trippelsdorf
2012-09-06 14:31 ` Takashi Iwai
2012-09-06 14:31 ` Takashi Iwai
2012-09-06 14:40 ` Daniel Mack [this message]
2012-09-06 14:40 ` Daniel Mack
2014-01-08 20:43 ` Andreas Mohr
2012-09-06 10:25 ` Daniel Mack
2012-09-06 10:25 ` Daniel Mack
2012-09-06 10:30 ` Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5048B5D2.5030105@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.