From: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND)
Date: Tue, 16 Jun 2015 22:37:55 +0900 [thread overview]
Message-ID: <558026B3.9080206@toshiba.co.jp> (raw)
In-Reply-To: <1434096662.2271.130.camel@x220>
On 2015/06/12 17:11, Paul Bolle wrote:
> On Fri, 2015-06-12 at 01:00 +0900, KOBAYASHI Yoshitake wrote:
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index 5897d8d..050f0e9 100644
>
>> +config MTD_NAND_BENAND
>> + tristate
>> + depends on MTD_NAND_BENAND_ENABLE
>> + default MTD_NAND
>> +
>> +config MTD_NAND_BENAND_ENABLE
>> + bool "Support for Toshiba BENAND (Built-in ECC NAND)"
>> + default y
>
> Why do you default to 'y'?
Setting the config to 'y' will not affect the SLCNAND operation.
I thought it is common to use BENAND and other vendor SLCNAND together
in the same model with same software build.
>> --- /dev/null
>> +++ b/drivers/mtd/nand/nand_benand.c
>
>> +EXPORT_SYMBOL(nand_benand_status_chk);
>
> I didn't spot any users of nand_benand_status_chk() outside of this
> file. Why is this export needed?
I agree with you. Thanks for checking.
I will delete this in next patch.
-- Yoshi
WARNING: multiple messages have this Message-ID (diff)
From: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND)
Date: Tue, 16 Jun 2015 22:37:55 +0900 [thread overview]
Message-ID: <558026B3.9080206@toshiba.co.jp> (raw)
In-Reply-To: <1434096662.2271.130.camel@x220>
On 2015/06/12 17:11, Paul Bolle wrote:
> On Fri, 2015-06-12 at 01:00 +0900, KOBAYASHI Yoshitake wrote:
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index 5897d8d..050f0e9 100644
>
>> +config MTD_NAND_BENAND
>> + tristate
>> + depends on MTD_NAND_BENAND_ENABLE
>> + default MTD_NAND
>> +
>> +config MTD_NAND_BENAND_ENABLE
>> + bool "Support for Toshiba BENAND (Built-in ECC NAND)"
>> + default y
>
> Why do you default to 'y'?
Setting the config to 'y' will not affect the SLCNAND operation.
I thought it is common to use BENAND and other vendor SLCNAND together
in the same model with same software build.
>> --- /dev/null
>> +++ b/drivers/mtd/nand/nand_benand.c
>
>> +EXPORT_SYMBOL(nand_benand_status_chk);
>
> I didn't spot any users of nand_benand_status_chk() outside of this
> file. Why is this export needed?
I agree with you. Thanks for checking.
I will delete this in next patch.
-- Yoshi
next prev parent reply other threads:[~2015-06-16 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 16:00 [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND) KOBAYASHI Yoshitake
2015-06-12 8:11 ` Paul Bolle
2015-06-12 8:11 ` Paul Bolle
2015-06-16 13:37 ` KOBAYASHI Yoshitake [this message]
2015-06-16 13:37 ` KOBAYASHI Yoshitake
2015-06-12 9:49 ` Richard Weinberger
2015-06-12 9:49 ` Richard Weinberger
2015-06-16 13:33 ` KOBAYASHI Yoshitake
2015-06-16 13:33 ` KOBAYASHI Yoshitake
2015-06-16 13:53 ` Richard Weinberger
2015-06-16 13:53 ` Richard Weinberger
2015-06-19 14:46 ` KOBAYASHI Yoshitake
2015-06-19 14:46 ` KOBAYASHI Yoshitake
2015-07-24 17:42 ` [PATCH REPOST v3] mtd: nand " KOBAYASHI Yoshitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558026B3.9080206@toshiba.co.jp \
--to=yoshitake.kobayashi@toshiba.co.jp \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.