From: Jiang Liu <jiang.liu@linux.intel.com>
To: Robert Richter <robert.richter@caviumnetworks.com>,
Tejun Heo <tj@kernel.org>
Cc: Robert Richter <rric@kernel.org>,
Sunil Goutham <sgoutham@cavium.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org
Subject: Re: [PATCH] ahci, msix: Fix build error for !PCI_MSI
Date: Wed, 17 Jun 2015 17:02:20 +0800 [thread overview]
Message-ID: <5581379C.3090607@linux.intel.com> (raw)
In-Reply-To: <20150617084852.GL4914@rric.localhost>
On 2015/6/17 16:48, Robert Richter wrote:
> From fd984f3be22f27b8d3c4cf577dbbf0a39792ea89 Mon Sep 17 00:00:00 2001
> From: Robert Richter <rrichter@cavium.com>
> Date: Wed, 17 Jun 2015 10:33:22 +0200
> Subject: [PATCH] ahci, msix: Fix build error for !PCI_MSI
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Fixing a build error if PCI_MSI is unset:
>
> drivers/ata/ahci.c: In function ‘msix_get_desc’:
> drivers/ata/ahci.c:1210:2: error: ‘struct pci_dev’ has no member named ‘msi_list’
>
> Catched by Fengguang's build bot.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> ---
> drivers/ata/ahci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index bdedaa4f9d7b..99cc9526ae95 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1205,13 +1205,14 @@ static inline void ahci_gtf_filter_workaround(struct ata_host *host)
>
> static struct msi_desc *msix_get_desc(struct pci_dev *dev, u16 entry)
> {
> +#ifdef CONFIG_PCI_MSI
> struct msi_desc *desc;
>
> list_for_each_entry(desc, &dev->msi_list, list) {
> if (desc->msi_attrib.entry_nr == entry)
> return desc;
> }
> -
> +#endif
Hi Robert,
While at it, could you please help to use for_each_pci_msi_entry()
from include/linux/msi.h instead of hard-coding? We are trying to refine
the msi_list related code,
so we don't need to touch this code again later.
Thanks!
Gerry
> return NULL;
> }
>
>
WARNING: multiple messages have this Message-ID (diff)
From: jiang.liu@linux.intel.com (Jiang Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ahci, msix: Fix build error for !PCI_MSI
Date: Wed, 17 Jun 2015 17:02:20 +0800 [thread overview]
Message-ID: <5581379C.3090607@linux.intel.com> (raw)
In-Reply-To: <20150617084852.GL4914@rric.localhost>
On 2015/6/17 16:48, Robert Richter wrote:
> From fd984f3be22f27b8d3c4cf577dbbf0a39792ea89 Mon Sep 17 00:00:00 2001
> From: Robert Richter <rrichter@cavium.com>
> Date: Wed, 17 Jun 2015 10:33:22 +0200
> Subject: [PATCH] ahci, msix: Fix build error for !PCI_MSI
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Fixing a build error if PCI_MSI is unset:
>
> drivers/ata/ahci.c: In function ?msix_get_desc?:
> drivers/ata/ahci.c:1210:2: error: ?struct pci_dev? has no member named ?msi_list?
>
> Catched by Fengguang's build bot.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> ---
> drivers/ata/ahci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index bdedaa4f9d7b..99cc9526ae95 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1205,13 +1205,14 @@ static inline void ahci_gtf_filter_workaround(struct ata_host *host)
>
> static struct msi_desc *msix_get_desc(struct pci_dev *dev, u16 entry)
> {
> +#ifdef CONFIG_PCI_MSI
> struct msi_desc *desc;
>
> list_for_each_entry(desc, &dev->msi_list, list) {
> if (desc->msi_attrib.entry_nr == entry)
> return desc;
> }
> -
> +#endif
Hi Robert,
While at it, could you please help to use for_each_pci_msi_entry()
from include/linux/msi.h instead of hard-coding? We are trying to refine
the msi_list related code,
so we don't need to touch this code again later.
Thanks!
Gerry
> return NULL;
> }
>
>
next prev parent reply other threads:[~2015-06-17 9:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 17:49 [PATCH v5 0/2] ahci: Add generic MSI-X support for single interrupts to SATA PCI Robert Richter
2015-06-05 17:49 ` Robert Richter
2015-06-05 17:49 ` [PATCH v5 1/2] ahci: Add generic MSI-X support for single interrupts to SATA PCI driver Robert Richter
2015-06-05 17:49 ` Robert Richter
2015-06-05 17:49 ` [PATCH v5 2/2] ahci: Add support for Cavium's ThunderX host controller Robert Richter
2015-06-05 17:49 ` Robert Richter
2015-06-16 13:24 ` [PATCH v5 0/2] ahci: Add generic MSI-X support for single interrupts to SATA PCI Robert Richter
2015-06-16 13:24 ` Robert Richter
2015-06-16 13:24 ` Robert Richter
2015-06-16 20:13 ` Tejun Heo
2015-06-16 20:13 ` Tejun Heo
2015-06-17 8:48 ` [PATCH] ahci, msix: Fix build error for !PCI_MSI Robert Richter
2015-06-17 8:48 ` Robert Richter
2015-06-17 8:48 ` Robert Richter
2015-06-17 9:02 ` Jiang Liu [this message]
2015-06-17 9:02 ` Jiang Liu
2015-06-17 13:30 ` [PATCH v2] " Robert Richter
2015-06-17 13:30 ` Robert Richter
2015-06-17 13:30 ` Robert Richter
2015-06-17 18:17 ` Tejun Heo
2015-06-17 18:17 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5581379C.3090607@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.richter@caviumnetworks.com \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.