From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
<linux-arm-kernel@lists.infradead.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
Josh Wu <josh.wu@atmel.com>, <linux-kernel@vger.kernel.org>,
<mturquette@baylibre.com>
Subject: Re: [PATCH] clk: at91: add generated clock driver
Date: Thu, 18 Jun 2015 14:40:48 +0200 [thread overview]
Message-ID: <5582BC50.1050801@atmel.com> (raw)
In-Reply-To: <1434614090.2385.19.camel@x220>
Le 18/06/2015 09:54, Paul Bolle a écrit :
> Hi Nicolas,
>
> On Thu, 2015-06-18 at 09:40 +0200, Nicolas Ferre wrote:
>> I am in the process, with my colleagues, of building bricks for our
>> upcoming SoC the sama5d2. So, the basic support for this chip will come
>> in the next weeks and will select this Kconfig option.
>
> Perhaps that could be added, say below the --- marker in the patch.
Yep, I should have added that, for sure!
> Maybe I missed something to that effect. Anyhow, I didn't spot in the
> patch that this was done deliberately. It had all the looks of a silly
> mistake.
>
>> I'd like though that this matter of fact doesn't block this piece of
>> code from being reviewed or even better merged in order to ease this new
>> SoC landing...
>
> The other side of that is that the sama5d2 might never make it, or take
> very long to make it, into mainline. And this would then end up being
> yet another chunk of code adding no value to mainline.
C'mon Paul, it's a simple chicken and egg problem... I have several
options here:
1/ I send the clock patch early and benefit from early review and a
comfortable landing strip
2/ I send the SoC early and have the very same remark concerning the
"+ select HAVE_AT91_GENERATED" line in my patch
3/ I do it in several separated series... but at the price of additional
synchronization between subsystems, additional dumb patches with so
little benefit in my opinion.
Ok, so I post sama5d2 early support today so that we can agree it's not
necessary to add superfluous steps.
Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: at91: add generated clock driver
Date: Thu, 18 Jun 2015 14:40:48 +0200 [thread overview]
Message-ID: <5582BC50.1050801@atmel.com> (raw)
In-Reply-To: <1434614090.2385.19.camel@x220>
Le 18/06/2015 09:54, Paul Bolle a ?crit :
> Hi Nicolas,
>
> On Thu, 2015-06-18 at 09:40 +0200, Nicolas Ferre wrote:
>> I am in the process, with my colleagues, of building bricks for our
>> upcoming SoC the sama5d2. So, the basic support for this chip will come
>> in the next weeks and will select this Kconfig option.
>
> Perhaps that could be added, say below the --- marker in the patch.
Yep, I should have added that, for sure!
> Maybe I missed something to that effect. Anyhow, I didn't spot in the
> patch that this was done deliberately. It had all the looks of a silly
> mistake.
>
>> I'd like though that this matter of fact doesn't block this piece of
>> code from being reviewed or even better merged in order to ease this new
>> SoC landing...
>
> The other side of that is that the sama5d2 might never make it, or take
> very long to make it, into mainline. And this would then end up being
> yet another chunk of code adding no value to mainline.
C'mon Paul, it's a simple chicken and egg problem... I have several
options here:
1/ I send the clock patch early and benefit from early review and a
comfortable landing strip
2/ I send the SoC early and have the very same remark concerning the
"+ select HAVE_AT91_GENERATED" line in my patch
3/ I do it in several separated series... but at the price of additional
synchronization between subsystems, additional dumb patches with so
little benefit in my opinion.
Ok, so I post sama5d2 early support today so that we can agree it's not
necessary to add superfluous steps.
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2015-06-18 12:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 13:23 [PATCH] clk: at91: add generated clock driver Nicolas Ferre
2015-06-17 13:23 ` Nicolas Ferre
2015-06-18 7:12 ` Paul Bolle
2015-06-18 7:12 ` Paul Bolle
2015-06-18 7:33 ` Boris Brezillon
2015-06-18 7:33 ` Boris Brezillon
2015-06-18 7:40 ` Nicolas Ferre
2015-06-18 7:40 ` Nicolas Ferre
2015-06-18 7:54 ` Paul Bolle
2015-06-18 7:54 ` Paul Bolle
2015-06-18 12:40 ` Nicolas Ferre [this message]
2015-06-18 12:40 ` Nicolas Ferre
2015-06-18 14:46 ` Paul Bolle
2015-06-18 14:46 ` Paul Bolle
2015-06-18 12:59 ` Alexandre Belloni
2015-06-18 12:59 ` Alexandre Belloni
2015-06-18 13:28 ` Nicolas Ferre
2015-06-18 13:28 ` Nicolas Ferre
2015-06-18 15:11 ` Paul Bolle
2015-06-18 15:11 ` Paul Bolle
2015-06-18 7:44 ` Paul Bolle
2015-06-18 7:44 ` Paul Bolle
2015-06-18 15:25 ` Boris Brezillon
2015-06-18 15:25 ` Boris Brezillon
2015-06-22 16:50 ` Nicolas Ferre
2015-06-22 16:50 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5582BC50.1050801@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=mturquette@baylibre.com \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.