From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
"Ludovic Desroches" <ludovic.desroches@atmel.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ARM: at91/soc: add basic support for new sama5d2 SoC
Date: Mon, 29 Jun 2015 14:46:51 +0200 [thread overview]
Message-ID: <55913E3B.6060009@atmel.com> (raw)
In-Reply-To: <20150618152105.GK27492@piout.net>
Le 18/06/2015 17:21, Alexandre Belloni a écrit :
> Hi,
>
> On 18/06/2015 at 15:18:28 +0200, Nicolas Ferre wrote :
>> diff --git a/Documentation/arm/Atmel/README b/Documentation/arm/Atmel/README
>> index c53a19b4aab2..6650a8ffaa64 100644
>> --- a/Documentation/arm/Atmel/README
>> +++ b/Documentation/arm/Atmel/README
>> @@ -90,6 +90,12 @@ the Atmel website: http://www.atmel.com.
>> + Datasheet
>> http://www.atmel.com/Images/Atmel-11238-32-bit-Cortex-A5-Microcontroller-SAMA5D4_Datasheet.pdf
>>
>> + * ARM Cortex-A5 + NEON based SoCs
>> + - sama5d2 family
>> + - sama5d27
>> + + Datasheet
>> + Coming soon
>
> Shouldn't that go directly before or after the sama5d4 family ?
This is "after" sama5d4: I sorted this file according to SoC release
date whereas I sorted the other entries in alpa-numerial order (sama5d2
placed before sama5d3).
Is it what you answered?
>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>> index f1b157971366..140228d033c2 100644
>> --- a/arch/arm/Kconfig.debug
>> +++ b/arch/arm/Kconfig.debug
>> @@ -141,6 +141,12 @@ choice
>> depends on ARCH_AT91
>> depends on SOC_SAMA5
>>
>> + config AT91_DEBUG_LL_DBGU3
>> + bool "Kernel low-level debugging on sama5d2"
>> + select DEBUG_AT91_UART
>> + depends on ARCH_AT91
>> + depends on SOC_SAMA5
>> +
>
> I think that at some point we'll have to kill those AT91_DEBUG_LL_*
> which are actually board specific and not soc specific. I already have a
> patch for that that I need to rebase.
Ok, it could definitively simplify the last weird bits of our
sub-architecture ;-)
>> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
>> index 43ec794d1057..e53780a28605 100644
>> --- a/arch/arm/mach-at91/Kconfig
>> +++ b/arch/arm/mach-at91/Kconfig
>> @@ -8,6 +8,18 @@ menuconfig ARCH_AT91
>> select SOC_BUS
>>
>> if ARCH_AT91
>> +config SOC_SAMA5D2
>> + bool "SAMA5D2 family" if ARCH_MULTI_V7
>> + select SOC_SAMA5
>> + select CACHE_L2X0
>> + select HAVE_FB_ATMEL
>> + select HAVE_AT91_UTMI
>> + select HAVE_AT91_USB_CLK
>> + select HAVE_AT91_H32MX
>> + select HAVE_AT91_GENERATED
>
> Seeing that, I think HAVE_AT91_GENERATED should include CLK somewhere in
> the name as this is only related to clocks.
Absolutely, I changed it to HAVE_AT91_GENERATED_CLK which is somehow
better. Also changed in my "generated clock" series sent to Boris.
Thanks for your review. Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: at91/soc: add basic support for new sama5d2 SoC
Date: Mon, 29 Jun 2015 14:46:51 +0200 [thread overview]
Message-ID: <55913E3B.6060009@atmel.com> (raw)
In-Reply-To: <20150618152105.GK27492@piout.net>
Le 18/06/2015 17:21, Alexandre Belloni a ?crit :
> Hi,
>
> On 18/06/2015 at 15:18:28 +0200, Nicolas Ferre wrote :
>> diff --git a/Documentation/arm/Atmel/README b/Documentation/arm/Atmel/README
>> index c53a19b4aab2..6650a8ffaa64 100644
>> --- a/Documentation/arm/Atmel/README
>> +++ b/Documentation/arm/Atmel/README
>> @@ -90,6 +90,12 @@ the Atmel website: http://www.atmel.com.
>> + Datasheet
>> http://www.atmel.com/Images/Atmel-11238-32-bit-Cortex-A5-Microcontroller-SAMA5D4_Datasheet.pdf
>>
>> + * ARM Cortex-A5 + NEON based SoCs
>> + - sama5d2 family
>> + - sama5d27
>> + + Datasheet
>> + Coming soon
>
> Shouldn't that go directly before or after the sama5d4 family ?
This is "after" sama5d4: I sorted this file according to SoC release
date whereas I sorted the other entries in alpa-numerial order (sama5d2
placed before sama5d3).
Is it what you answered?
>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>> index f1b157971366..140228d033c2 100644
>> --- a/arch/arm/Kconfig.debug
>> +++ b/arch/arm/Kconfig.debug
>> @@ -141,6 +141,12 @@ choice
>> depends on ARCH_AT91
>> depends on SOC_SAMA5
>>
>> + config AT91_DEBUG_LL_DBGU3
>> + bool "Kernel low-level debugging on sama5d2"
>> + select DEBUG_AT91_UART
>> + depends on ARCH_AT91
>> + depends on SOC_SAMA5
>> +
>
> I think that at some point we'll have to kill those AT91_DEBUG_LL_*
> which are actually board specific and not soc specific. I already have a
> patch for that that I need to rebase.
Ok, it could definitively simplify the last weird bits of our
sub-architecture ;-)
>> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
>> index 43ec794d1057..e53780a28605 100644
>> --- a/arch/arm/mach-at91/Kconfig
>> +++ b/arch/arm/mach-at91/Kconfig
>> @@ -8,6 +8,18 @@ menuconfig ARCH_AT91
>> select SOC_BUS
>>
>> if ARCH_AT91
>> +config SOC_SAMA5D2
>> + bool "SAMA5D2 family" if ARCH_MULTI_V7
>> + select SOC_SAMA5
>> + select CACHE_L2X0
>> + select HAVE_FB_ATMEL
>> + select HAVE_AT91_UTMI
>> + select HAVE_AT91_USB_CLK
>> + select HAVE_AT91_H32MX
>> + select HAVE_AT91_GENERATED
>
> Seeing that, I think HAVE_AT91_GENERATED should include CLK somewhere in
> the name as this is only related to clocks.
Absolutely, I changed it to HAVE_AT91_GENERATED_CLK which is somehow
better. Also changed in my "generated clock" series sent to Boris.
Thanks for your review. Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2015-06-29 12:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 13:18 [PATCH 0/3] introducing Atmel sama5d2 SoC Nicolas Ferre
2015-06-18 13:18 ` Nicolas Ferre
2015-06-18 13:18 ` [PATCH 1/3] ARM: at91/soc: add basic support for new " Nicolas Ferre
2015-06-18 13:18 ` Nicolas Ferre
2015-06-18 15:21 ` Alexandre Belloni
2015-06-18 15:21 ` Alexandre Belloni
2015-06-29 12:46 ` Nicolas Ferre [this message]
2015-06-29 12:46 ` Nicolas Ferre
2015-06-29 15:04 ` Alexandre Belloni
2015-06-29 15:04 ` Alexandre Belloni
2015-07-28 8:54 ` Nicolas Ferre
2015-07-28 8:54 ` Nicolas Ferre
2015-07-28 9:38 ` Nicolas Ferre
2015-07-28 9:38 ` Nicolas Ferre
2015-06-18 13:18 ` [PATCH 2/3] ARM: at91/dt: add basic dtsi for " Nicolas Ferre
2015-06-18 13:18 ` Nicolas Ferre
2015-06-18 13:18 ` [PATCH 3/3] ARM: at91/dt: add minimal sama5d2 Xplained board Nicolas Ferre
2015-06-18 13:18 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55913E3B.6060009@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.