From: Hans Verkuil <hverkuil@xs4all.nl>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Mats Randgaard <matrandg@cisco.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 5/5] [media] tc358743: allow event subscription
Date: Fri, 17 Jul 2015 16:58:53 +0200 [thread overview]
Message-ID: <55A9182D.2020800@xs4all.nl> (raw)
In-Reply-To: <1436868609.3793.25.camel@pengutronix.de>
On 07/14/2015 12:10 PM, Philipp Zabel wrote:
> Am Montag, den 13.07.2015, 13:07 +0200 schrieb Hans Verkuil:
>> On 07/10/2015 03:11 PM, Philipp Zabel wrote:
>>> This is useful to subscribe to HDMI hotplug events via the
>>> V4L2_CID_DV_RX_POWER_PRESENT control.
>>>
>>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>>> ---
>>> drivers/media/i2c/tc358743.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
>>> index 4a889d4..91fffa8 100644
>>> --- a/drivers/media/i2c/tc358743.c
>>> +++ b/drivers/media/i2c/tc358743.c
>>> @@ -40,6 +40,7 @@
>>> #include <media/v4l2-dv-timings.h>
>>> #include <media/v4l2-device.h>
>>> #include <media/v4l2-ctrls.h>
>>> +#include <media/v4l2-event.h>
>>> #include <media/v4l2-of.h>
>>> #include <media/tc358743.h>
>>>
>>> @@ -1604,6 +1605,8 @@ static const struct v4l2_subdev_core_ops tc358743_core_ops = {
>>> .s_register = tc358743_s_register,
>>> #endif
>>> .interrupt_service_routine = tc358743_isr,
>>> + .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
>>
>> Ah, they are set here.
>>
>> But note that v4l2_ctrl_subdev_subscribe_event is not enough, since this driver
>> also issues the V4L2_EVENT_SOURCE_CHANGE event.
>>
>> See this patch on how to do that:
>>
>> http://git.linuxtv.org/cgit.cgi/hverkuil/media_tree.git/commit/?h=for-v4.3a&id=85c9b0b83795dac3d27043619a727af5c7313fe7
>>
>> Note: requires the new v4l2_subdev_notify_event function that's not yet
>> merged (just posted the pull request for that).
>
> Ok, I think I'll split this up and send patch 5 separately, then.
FYI: the v4l2_subdev_notify_event was just merged today.
Regards,
Hans
next prev parent reply other threads:[~2015-07-17 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 13:11 [PATCH 1/5] [media] tc358743: register v4l2 asynchronous subdevice Philipp Zabel
2015-07-10 13:11 ` [PATCH 2/5] [media] tc358743: enable v4l2 subdevice devnode Philipp Zabel
[not found] ` <1436533897-3060-2-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-07-13 10:59 ` Hans Verkuil
2015-07-13 10:59 ` Hans Verkuil
2015-07-10 13:11 ` [PATCH 3/5] [media] tc358743: support probe from device tree Philipp Zabel
2015-07-13 10:57 ` Hans Verkuil
2015-07-14 10:10 ` Philipp Zabel
2015-07-14 10:15 ` Hans Verkuil
2015-07-17 11:00 ` Philipp Zabel
2015-07-10 13:11 ` [PATCH 4/5] [media] tc358743: add direct interrupt handling Philipp Zabel
2015-07-10 13:11 ` [PATCH 5/5] [media] tc358743: allow event subscription Philipp Zabel
2015-07-13 11:07 ` Hans Verkuil
2015-07-14 10:10 ` Philipp Zabel
2015-07-17 14:58 ` Hans Verkuil [this message]
2015-07-13 10:47 ` [PATCH 1/5] [media] tc358743: register v4l2 asynchronous subdevice Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A9182D.2020800@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=matrandg@cisco.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.