From: Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, Mats Randgaard <matrandg-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org Subject: Re: [PATCH 2/5] [media] tc358743: enable v4l2 subdevice devnode Date: Mon, 13 Jul 2015 12:59:26 +0200 [thread overview] Message-ID: <55A39A0E.50809@xs4all.nl> (raw) In-Reply-To: <1436533897-3060-2-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> On 07/10/2015 03:11 PM, Philipp Zabel wrote: > Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > --- > drivers/media/i2c/tc358743.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c > index 48d1575..0be6d9f 100644 > --- a/drivers/media/i2c/tc358743.c > +++ b/drivers/media/i2c/tc358743.c > @@ -1668,7 +1668,7 @@ static int tc358743_probe(struct i2c_client *client, > state->i2c_client = client; > sd = &state->sd; > v4l2_i2c_subdev_init(sd, client, &tc358743_ops); > - sd->flags |= V4L2_SUBDEV_FL_HAS_EVENTS; > + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; Note: HAS_EVENTS won't do much since there are no .subscribe_event or .unsubscribe_event ops. You should add those. Regards, Hans > > /* i2c access */ > if ((i2c_rd16(sd, CHIPID) & MASK_CHIPID) != 0) { > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl> To: Philipp Zabel <p.zabel@pengutronix.de>, Mats Randgaard <matrandg@cisco.com> Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 2/5] [media] tc358743: enable v4l2 subdevice devnode Date: Mon, 13 Jul 2015 12:59:26 +0200 [thread overview] Message-ID: <55A39A0E.50809@xs4all.nl> (raw) In-Reply-To: <1436533897-3060-2-git-send-email-p.zabel@pengutronix.de> On 07/10/2015 03:11 PM, Philipp Zabel wrote: > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/media/i2c/tc358743.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c > index 48d1575..0be6d9f 100644 > --- a/drivers/media/i2c/tc358743.c > +++ b/drivers/media/i2c/tc358743.c > @@ -1668,7 +1668,7 @@ static int tc358743_probe(struct i2c_client *client, > state->i2c_client = client; > sd = &state->sd; > v4l2_i2c_subdev_init(sd, client, &tc358743_ops); > - sd->flags |= V4L2_SUBDEV_FL_HAS_EVENTS; > + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; Note: HAS_EVENTS won't do much since there are no .subscribe_event or .unsubscribe_event ops. You should add those. Regards, Hans > > /* i2c access */ > if ((i2c_rd16(sd, CHIPID) & MASK_CHIPID) != 0) { >
next prev parent reply other threads:[~2015-07-13 10:59 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-10 13:11 [PATCH 1/5] [media] tc358743: register v4l2 asynchronous subdevice Philipp Zabel 2015-07-10 13:11 ` [PATCH 2/5] [media] tc358743: enable v4l2 subdevice devnode Philipp Zabel [not found] ` <1436533897-3060-2-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2015-07-13 10:59 ` Hans Verkuil [this message] 2015-07-13 10:59 ` Hans Verkuil 2015-07-10 13:11 ` [PATCH 3/5] [media] tc358743: support probe from device tree Philipp Zabel 2015-07-13 10:57 ` Hans Verkuil 2015-07-14 10:10 ` Philipp Zabel 2015-07-14 10:15 ` Hans Verkuil 2015-07-17 11:00 ` Philipp Zabel 2015-07-10 13:11 ` [PATCH 4/5] [media] tc358743: add direct interrupt handling Philipp Zabel 2015-07-10 13:11 ` [PATCH 5/5] [media] tc358743: allow event subscription Philipp Zabel 2015-07-13 11:07 ` Hans Verkuil 2015-07-14 10:10 ` Philipp Zabel 2015-07-17 14:58 ` Hans Verkuil 2015-07-13 10:47 ` [PATCH 1/5] [media] tc358743: register v4l2 asynchronous subdevice Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55A39A0E.50809@xs4all.nl \ --to=hverkuil-qwit8jrvyhvmr6xm/wnwpw@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=matrandg-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \ --cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.