From: Eric Nelson <eric@nelint.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] mmc erase fails from U-Boot command line
Date: Fri, 4 Dec 2015 15:42:33 -0700 [thread overview]
Message-ID: <566216D9.4030202@nelint.com> (raw)
In-Reply-To: <5661C0CB.2040900@nelint.com>
Hi all,
On 12/04/2015 09:35 AM, Eric Nelson wrote:
> Hi Fabio,
>
> On 12/02/2015 12:53 PM, Fabio Estevam wrote:
>> On Wed, Dec 2, 2015 at 5:28 PM, Eric Nelson <eric@nelint.com> wrote:
>>
> ...
>>>
>>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>>> index 53084a7..8f5d9e1 100644
>>> --- a/drivers/mmc/mmc.c
>>> +++ b/drivers/mmc/mmc.c
>>> @@ -105,6 +105,9 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd
>>> *cmd, struct mmc_data *data)
>>> #else
>>> ret = mmc->cfg->ops->send_cmd(mmc, cmd, data);
>>> #endif
>>> + if (ret)
>>> + printf("error %d from CMD_SEND:%d\n", ret, cmd->cmdidx);
>>> +
>>> return ret;
>>
>> Applying this change on top of head I get:
>>
>> => mmc erase 4000 1000
>>
>> MMC erase: dev # 2, block # 16384, count 4096 ... Timeout waiting for DAT0 to go
>> high!
>> error -19 from CMD_SEND:38
>> mmc erase failed
>> 0 blocks erased: ERROR
>
> How easy is this for you to reproduce?
>
> I'm only seeing the error sporadically, which makes it difficult to
> test.
>
I've figured out a way to repeat this on my machine.
If I write 0xff's to the eMMC blocks, then issue an erase for the same,
I get the problem with each MMC_ERASE command.
I've also found something that fixes the issue in my testing.
Changing SECURE_ERASE to 0 from 0x80000000 in include/mmc.h allows
things to function for me.
Page 115 of the JEDEC eMMC 4.5 spec says that bit 31 is obsolete and
should be zero:
http://www.jedec.org/sites/default/files/docs/jesd84-B45.pdf
Hector and Fabio, can you test that change?
Please advise,
Eric
diff --git a/include/mmc.h b/include/mmc.h
index cda9a19..b1528d4 100644
--- a/include/mmc.h
+++ b/include/mmc.h
@@ -121,7 +121,7 @@
#define OCR_VOLTAGE_MASK 0x007FFF80
#define OCR_ACCESS_MODE 0x60000000
-#define SECURE_ERASE 0x80000000
+#define SECURE_ERASE 0x00000000
next prev parent reply other threads:[~2015-12-04 22:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 11:46 [U-Boot] mmc erase fails from U-Boot command line Cliff Brust
2015-10-19 11:06 ` Hector Palacios
2015-11-12 20:56 ` Fabio Estevam
2015-11-13 12:26 ` Palacios, Hector
2015-11-13 14:37 ` Fabio Estevam
2015-11-16 15:23 ` Fabio Estevam
2015-11-16 15:30 ` Fabio Estevam
2015-12-01 19:05 ` Eric Nelson
2015-12-02 17:23 ` Fabio Estevam
2015-12-02 18:47 ` Eric Nelson
2015-12-02 18:52 ` Fabio Estevam
2015-12-02 19:28 ` Eric Nelson
2015-12-02 19:53 ` Fabio Estevam
2015-12-04 16:35 ` Eric Nelson
2015-12-04 16:37 ` Fabio Estevam
2015-12-04 22:42 ` Eric Nelson [this message]
2015-12-05 0:19 ` Fabio Estevam
2015-12-07 0:21 ` Fabio Estevam
2015-12-07 14:36 ` Eric Nelson
2015-12-02 19:37 ` Michael Trimarchi
2015-12-02 19:54 ` Fabio Estevam
2015-12-02 20:00 ` Michael Trimarchi
2015-12-04 16:08 ` Eric Nelson
2015-12-04 16:50 ` Eric Nelson
2015-12-04 17:06 ` Michael Trimarchi
2015-12-07 14:50 ` [U-Boot] [PATCH] mmc: update MMC_ERASE argument to match Linux kernel Eric Nelson
2015-12-09 10:55 ` Hector Palacios
2015-12-22 9:55 ` Fabio Estevam
2016-01-04 22:23 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566216D9.4030202@nelint.com \
--to=eric@nelint.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.