From: Michael Trimarchi <michael@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] mmc erase fails from U-Boot command line
Date: Fri, 4 Dec 2015 18:06:23 +0100 [thread overview]
Message-ID: <CAOf5uwmkdeZN58V9X-0trJ622=OFdQBNGc4EYx-GvKibhrUnpg@mail.gmail.com> (raw)
In-Reply-To: <5661C454.5030706@nelint.com>
Hi
On Dec 4, 2015 5:50 PM, "Eric Nelson" <eric@nelint.com> wrote:
>
> Hi all,
>
> On 12/04/2015 09:08 AM, Eric Nelson wrote:
> ...
> >
> > I think you're onto something.
> >
> > According to the i.MX35 reference manual, which I think was the origin
> > of this patch, the low four bits of the SYSCTL register of the SDHC5
> > 3 - SDCLKEN
> > 2 - PEREN
> > 1 - HCKEN
> > 0 - IPGEN
> >
> > See page 603 of
> > http://cache.freescale.com/files/dsp/doc/ref_manual/IMX35RM.pdf
> >
> > But in the i.MX6 reference manual, the low four bits are reserved and
> > say "Always write as 1".
> >
> > See pages 5679-5680 of
> > http://cache.freescale.com/files/32bit/doc/ref_manual/IMX6DQRM.pdf
> >
> > It appears that when this patch was ported from the Freescale version,
> > the test for "is_usdhc" was lost.
> >
> >
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=7a5b80297bc6cef0c10e5f57ac0450678dc7bc5e
> >
> >
>
Happy if you fix down your problem
Michael
> Following up, this code is bugged on i.MX6:
>
>
http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/mmc/fsl_esdhc.c;h=c5054d66bdcda029f0485958c87bd5154ccee591;hb=HEAD#l505
>
> As are a couple of other things in the driver, as seen by
> trying to compile without the constants for the low 4 bits:
>
> diff --git a/include/fsl_esdhc.h b/include/fsl_esdhc.h
> index aa1b4cf..a4b87ce 100644
> --- a/include/fsl_esdhc.h
> +++ b/include/fsl_esdhc.h
> @@ -25,10 +25,12 @@
> #define SYSCTL_INITA 0x08000000
> #define SYSCTL_TIMEOUT_MASK 0x000f0000
> #define SYSCTL_CLOCK_MASK 0x0000fff0
> +#if !defined(CONFIG_MX6)
> #define SYSCTL_CKEN 0x00000008
> #define SYSCTL_PEREN 0x00000004
> #define SYSCTL_HCKEN 0x00000002
> #define SYSCTL_IPGEN 0x00000001
> +#endif
> #define SYSCTL_RSTA 0x01000000
> #define SYSCTL_RSTC 0x02000000
> #define SYSCTL_RSTD 0x04000000
>
next prev parent reply other threads:[~2015-12-04 17:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 11:46 [U-Boot] mmc erase fails from U-Boot command line Cliff Brust
2015-10-19 11:06 ` Hector Palacios
2015-11-12 20:56 ` Fabio Estevam
2015-11-13 12:26 ` Palacios, Hector
2015-11-13 14:37 ` Fabio Estevam
2015-11-16 15:23 ` Fabio Estevam
2015-11-16 15:30 ` Fabio Estevam
2015-12-01 19:05 ` Eric Nelson
2015-12-02 17:23 ` Fabio Estevam
2015-12-02 18:47 ` Eric Nelson
2015-12-02 18:52 ` Fabio Estevam
2015-12-02 19:28 ` Eric Nelson
2015-12-02 19:53 ` Fabio Estevam
2015-12-04 16:35 ` Eric Nelson
2015-12-04 16:37 ` Fabio Estevam
2015-12-04 22:42 ` Eric Nelson
2015-12-05 0:19 ` Fabio Estevam
2015-12-07 0:21 ` Fabio Estevam
2015-12-07 14:36 ` Eric Nelson
2015-12-02 19:37 ` Michael Trimarchi
2015-12-02 19:54 ` Fabio Estevam
2015-12-02 20:00 ` Michael Trimarchi
2015-12-04 16:08 ` Eric Nelson
2015-12-04 16:50 ` Eric Nelson
2015-12-04 17:06 ` Michael Trimarchi [this message]
2015-12-07 14:50 ` [U-Boot] [PATCH] mmc: update MMC_ERASE argument to match Linux kernel Eric Nelson
2015-12-09 10:55 ` Hector Palacios
2015-12-22 9:55 ` Fabio Estevam
2016-01-04 22:23 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOf5uwmkdeZN58V9X-0trJ622=OFdQBNGc4EYx-GvKibhrUnpg@mail.gmail.com' \
--to=michael@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.