From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] edid-decode: new package
Date: Wed, 9 Dec 2015 11:11:50 +0000 [thread overview]
Message-ID: <56680C76.7040909@imgtec.com> (raw)
In-Reply-To: <1449522884-8290-1-git-send-email-ps.report@gmx.net>
Dear Peter Seiderer,
On 07/12/15 21:14, Peter Seiderer wrote:
[snip]
> diff --git a/package/edid-decode/edid-decode.mk b/package/edid-decode/edid-decode.mk
> new file mode 100644
> index 0000000..da6a1d1
> --- /dev/null
> +++ b/package/edid-decode/edid-decode.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# edid-decode
> +#
> +################################################################################
> +
> +EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
> +EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
> +EDID_DECODE_LICENSE = MIT
I'm not sure if we should write MIT or MIT-like here. Can anyone else
have a look to this, please?
> +EDID_DECODE_LICENSE_FILES = edid-decode.c
> +
> +define EDID_DECODE_BUILD_CMDS
> + $(MAKE) -C $(@D) CC="$(TARGET_CC)" edid-decode
You are missing the $(TARGET_MAKE_ENV) variable in front of $(MAKE).
Also, if you want, you can use $(TARGET_CONFIGURE_OPTS) which will do
the CC="$(TARGET_CC)" (among other things) for you.
Regards,
Vincent.
> +endef
> +
> +define EDID_DECODE_INSTALL_TARGET_CMDS
> + $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> +endef
> +
> +$(eval $(generic-package))
>
next prev parent reply other threads:[~2015-12-09 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 21:14 [Buildroot] [PATCH v1] edid-decode: new package Peter Seiderer
2015-12-09 11:11 ` Vicente Olivert Riera [this message]
2015-12-09 13:15 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56680C76.7040909@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.