* [Buildroot] [PATCH v1] edid-decode: new package
@ 2015-12-07 21:14 Peter Seiderer
2015-12-09 11:11 ` Vicente Olivert Riera
2015-12-09 13:15 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Peter Seiderer @ 2015-12-07 21:14 UTC (permalink / raw)
To: buildroot
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/Config.in | 1 +
package/edid-decode/Config.in | 6 ++++++
package/edid-decode/edid-decode.mk | 20 ++++++++++++++++++++
3 files changed, 27 insertions(+)
create mode 100644 package/edid-decode/Config.in
create mode 100644 package/edid-decode/edid-decode.mk
diff --git a/package/Config.in b/package/Config.in
index 38436e2..07461e5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -338,6 +338,7 @@ endif
source "package/dtv-scan-tables/Config.in"
source "package/dvb-apps/Config.in"
source "package/dvbsnoop/Config.in"
+ source "package/edid-decode/Config.in"
source "package/eeprog/Config.in"
source "package/eudev/Config.in"
source "package/evemu/Config.in"
diff --git a/package/edid-decode/Config.in b/package/edid-decode/Config.in
new file mode 100644
index 0000000..64297b4
--- /dev/null
+++ b/package/edid-decode/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EDID_DECODE
+ bool "edid-decode"
+ help
+ Decode EDID data in human-readable format.
+
+ http://cgit.freedesktop.org/xorg/app/edid-decode/
diff --git a/package/edid-decode/edid-decode.mk b/package/edid-decode/edid-decode.mk
new file mode 100644
index 0000000..da6a1d1
--- /dev/null
+++ b/package/edid-decode/edid-decode.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# edid-decode
+#
+################################################################################
+
+EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
+EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
+EDID_DECODE_LICENSE = MIT
+EDID_DECODE_LICENSE_FILES = edid-decode.c
+
+define EDID_DECODE_BUILD_CMDS
+ $(MAKE) -C $(@D) CC="$(TARGET_CC)" edid-decode
+endef
+
+define EDID_DECODE_INSTALL_TARGET_CMDS
+ $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] edid-decode: new package
2015-12-07 21:14 [Buildroot] [PATCH v1] edid-decode: new package Peter Seiderer
@ 2015-12-09 11:11 ` Vicente Olivert Riera
2015-12-09 13:15 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Vicente Olivert Riera @ 2015-12-09 11:11 UTC (permalink / raw)
To: buildroot
Dear Peter Seiderer,
On 07/12/15 21:14, Peter Seiderer wrote:
[snip]
> diff --git a/package/edid-decode/edid-decode.mk b/package/edid-decode/edid-decode.mk
> new file mode 100644
> index 0000000..da6a1d1
> --- /dev/null
> +++ b/package/edid-decode/edid-decode.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# edid-decode
> +#
> +################################################################################
> +
> +EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
> +EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
> +EDID_DECODE_LICENSE = MIT
I'm not sure if we should write MIT or MIT-like here. Can anyone else
have a look to this, please?
> +EDID_DECODE_LICENSE_FILES = edid-decode.c
> +
> +define EDID_DECODE_BUILD_CMDS
> + $(MAKE) -C $(@D) CC="$(TARGET_CC)" edid-decode
You are missing the $(TARGET_MAKE_ENV) variable in front of $(MAKE).
Also, if you want, you can use $(TARGET_CONFIGURE_OPTS) which will do
the CC="$(TARGET_CC)" (among other things) for you.
Regards,
Vincent.
> +endef
> +
> +define EDID_DECODE_INSTALL_TARGET_CMDS
> + $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> +endef
> +
> +$(eval $(generic-package))
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] edid-decode: new package
2015-12-07 21:14 [Buildroot] [PATCH v1] edid-decode: new package Peter Seiderer
2015-12-09 11:11 ` Vicente Olivert Riera
@ 2015-12-09 13:15 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2015-12-09 13:15 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/Config.in | 1 +
> package/edid-decode/Config.in | 6 ++++++
> package/edid-decode/edid-decode.mk | 20 ++++++++++++++++++++
> 3 files changed, 27 insertions(+)
> create mode 100644 package/edid-decode/Config.in
> create mode 100644 package/edid-decode/edid-decode.mk
> diff --git a/package/Config.in b/package/Config.in
> index 38436e2..07461e5 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -338,6 +338,7 @@ endif
> source "package/dtv-scan-tables/Config.in"
> source "package/dvb-apps/Config.in"
> source "package/dvbsnoop/Config.in"
> + source "package/edid-decode/Config.in"
> source "package/eeprog/Config.in"
> source "package/eudev/Config.in"
> source "package/evemu/Config.in"
> diff --git a/package/edid-decode/Config.in b/package/edid-decode/Config.in
> new file mode 100644
> index 0000000..64297b4
> --- /dev/null
> +++ b/package/edid-decode/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_EDID_DECODE
> + bool "edid-decode"
> + help
> + Decode EDID data in human-readable format.
> +
> + http://cgit.freedesktop.org/xorg/app/edid-decode/
> diff --git a/package/edid-decode/edid-decode.mk b/package/edid-decode/edid-decode.mk
> new file mode 100644
> index 0000000..da6a1d1
> --- /dev/null
> +++ b/package/edid-decode/edid-decode.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# edid-decode
> +#
> +################################################################################
> +
> +EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
> +EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
> +EDID_DECODE_LICENSE = MIT
> +EDID_DECODE_LICENSE_FILES = edid-decode.c
> +
> +define EDID_DECODE_BUILD_CMDS
> + $(MAKE) -C $(@D) CC="$(TARGET_CC)" edid-decode
We should also use our CFLAGS / LDFLAGS. The Makefile doesn't directly
provide support for this, so I've changed it to pass it in CC="".
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-09 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-07 21:14 [Buildroot] [PATCH v1] edid-decode: new package Peter Seiderer
2015-12-09 11:11 ` Vicente Olivert Riera
2015-12-09 13:15 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.