From: Frank Crawford <frank@crawford.emu.id.au>
To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 0/4] hwmon (it87): Correct handling for configuration mode
Date: Sat, 27 Apr 2024 19:58:48 +1000 [thread overview]
Message-ID: <67469410c2cccaf993171bbfcae5b7f0de94d674.camel@crawford.emu.id.au> (raw)
In-Reply-To: <20240427083317.2077175-1-frank@crawford.emu.id.au>
On Sat, 2024-04-27 at 18:33 +1000, Frank Crawford wrote:
> On various Gigabyte boards, incorrectly entering configuration mode
> causes the second Super-IO chip to generate LPC bus access errors.
> This was preivously fixed by ensuring that the second chip receives
> the
> code to enter configuration mode before the first chip.
>
> On discussion with people who have access to the specification
> documents
> it was noted that this is wrong, and you should not enter or leave
> configuration mode for the second chip, as it is enable during
> initialisation and should not be changed.
>
> In particular, this was found to be the case on the Gigabyte X670E
> Aorus
> Master board, where it was reporting a totally wrong chip ID (0x8883)
> using the previous method. This was corrected by not entering
> configuration mode, and this has been found to still work with older
> boards.
>
> ---
Sorry, I forgot to add what the changes are since v1:
- renamed the feature to FEAT_NOCONF and macro to has_noconf.
- reworked patch descriptions to be more explicit about the actions and
remove any reference to the BIOS.
There is no code changes of any significance.
> Frank Crawford (4):
> Rename FEAT_CONF_NOEXIT to FEAT_NOCONF as more descriptive of
> requirement
> Do not enter configuration mode for some chiptypes
> Test for chipset before entering configuration mode
> Remove tests nolonger required
>
> drivers/hwmon/it87.c | 127 +++++++++++++++++++++--------------------
> --
> 1 file changed, 61 insertions(+), 66 deletions(-)
>
next prev parent reply other threads:[~2024-04-27 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 8:33 [PATCH v2 0/4] hwmon (it87): Correct handling for configuration mode Frank Crawford
2024-04-27 8:33 ` [PATCH v2 1/4] hwmon (it87): Rename FEAT_CONF_NOEXIT to FEAT_NOCONF as more descriptive of requirement Frank Crawford
2024-04-27 8:33 ` [PATCH v2 2/4] hwmon (it87): Do not enter configuration mode for some chiptypes Frank Crawford
2024-04-27 8:33 ` [PATCH v2 3/4] hwmon (it87): Test for chipset before entering configuration mode Frank Crawford
2024-04-27 11:11 ` Guenter Roeck
2024-04-27 11:53 ` Frank Crawford
2024-04-27 17:00 ` Guenter Roeck
2024-04-28 4:31 ` Frank Crawford
2024-04-28 7:03 ` Guenter Roeck
2024-04-28 7:35 ` Frank Crawford
2024-04-27 8:33 ` [PATCH v2 4/4] hwmon (it87): Remove tests nolonger required Frank Crawford
2024-04-27 9:58 ` Frank Crawford [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-28 6:03 [PATCH v2 0/4] hwmon (it87): Correct handling for configuration mode Frank Crawford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67469410c2cccaf993171bbfcae5b7f0de94d674.camel@crawford.emu.id.au \
--to=frank@crawford.emu.id.au \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.