From: Frank Crawford <frank@crawford.emu.id.au>
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 3/4] hwmon (it87): Test for chipset before entering configuration mode
Date: Sun, 28 Apr 2024 17:35:24 +1000 [thread overview]
Message-ID: <f155d740ff3def717c16d8a215359479a9fb6526.camel@crawford.emu.id.au> (raw)
In-Reply-To: <46cd36bc-83f1-4d4e-ac1d-1524882e9b52@roeck-us.net>
On Sun, 2024-04-28 at 00:03 -0700, Guenter Roeck wrote:
> On 4/27/24 21:31, Frank Crawford wrote:
...
> > In fact, I think in this case that entire expression can be
> > simplified
> > to just "!opened", as we only want to perform the exit code when
> > the
> > entry code was given, and it is only set to true in those cases.
> >
>
> Not really, because it is at least theoretically possible that it was
> necessary to enter configuration mode to determine that the chip
> is one of the broken ones. I'll leave that up to you to make the
> call,
> though.
I guess it is theoretically possible, if some other driver has done
something, but as well I guess this patch is different in that it
doesn't do the second chip first, and so is still different.
However, in the only chipset we have been able to reliably lock up
lately we haven't been able to read the chipID even after trying to
enter configuration mode, when we have locked up the chip, so I don't
think this issue will actually happen in practice.
I will still try to get hold of the configuration documentation, to see
any additional notes from the vendor. I don't expect that soon though.
>
> Guenter
Regards
Frank
next prev parent reply other threads:[~2024-04-28 7:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 8:33 [PATCH v2 0/4] hwmon (it87): Correct handling for configuration mode Frank Crawford
2024-04-27 8:33 ` [PATCH v2 1/4] hwmon (it87): Rename FEAT_CONF_NOEXIT to FEAT_NOCONF as more descriptive of requirement Frank Crawford
2024-04-27 8:33 ` [PATCH v2 2/4] hwmon (it87): Do not enter configuration mode for some chiptypes Frank Crawford
2024-04-27 8:33 ` [PATCH v2 3/4] hwmon (it87): Test for chipset before entering configuration mode Frank Crawford
2024-04-27 11:11 ` Guenter Roeck
2024-04-27 11:53 ` Frank Crawford
2024-04-27 17:00 ` Guenter Roeck
2024-04-28 4:31 ` Frank Crawford
2024-04-28 7:03 ` Guenter Roeck
2024-04-28 7:35 ` Frank Crawford [this message]
2024-04-27 8:33 ` [PATCH v2 4/4] hwmon (it87): Remove tests nolonger required Frank Crawford
2024-04-27 9:58 ` [PATCH v2 0/4] hwmon (it87): Correct handling for configuration mode Frank Crawford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f155d740ff3def717c16d8a215359479a9fb6526.camel@crawford.emu.id.au \
--to=frank@crawford.emu.id.au \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.